From 19b4b6b9d7b687f893b69f70fe839f6340c867fb Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 2 Nov 2025 21:32:03 +0000
Subject: [PATCH 1/2] Initial plan


From 316c3f2c5a2dd1a3e4b7e0c3ef6039aab5310cab Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Sun, 2 Nov 2025 21:35:35 +0000
Subject: [PATCH 2/2] refactor: extract Bech32 charset to class constant

Co-authored-by: tcheeric <6341500+tcheeric@users.noreply.github.com>
---
 .../compile/default-compile/inputFiles.lst       |   7 +++++++
 .../xyz/tcheeric/phoenixd/mock/MockLnServer.java |  12 +++++-------
 .../xyz/tcheeric/phoenixd/mock/Main.class        | Bin 0 -> 2963 bytes
 .../tcheeric/phoenixd/mock/MockLnServer.class    | Bin 0 -> 6572 bytes
 .../compile/default-compile/createdFiles.lst     |   2 ++
 .../compile/default-compile/inputFiles.lst       |   2 ++
 6 files changed, 16 insertions(+), 7 deletions(-)
 create mode 100644 phoenixd-base/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
 create mode 100644 phoenixd-mock/target/classes/xyz/tcheeric/phoenixd/mock/Main.class
 create mode 100644 phoenixd-mock/target/classes/xyz/tcheeric/phoenixd/mock/MockLnServer.class
 create mode 100644 phoenixd-mock/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst
 create mode 100644 phoenixd-mock/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst

diff --git a/phoenixd-base/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst b/phoenixd-base/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
new file mode 100644
index 0000000..a88bf28
--- /dev/null
+++ b/phoenixd-base/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
@@ -0,0 +1,7 @@
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-base/src/main/java/xyz/tcheeric/phoenixd/common/rest/Operation.java
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-base/src/main/java/xyz/tcheeric/phoenixd/common/rest/VoidRequestParam.java
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-base/src/main/java/xyz/tcheeric/phoenixd/common/rest/Request.java
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-base/src/main/java/xyz/tcheeric/phoenixd/common/rest/Response.java
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-base/src/main/java/xyz/tcheeric/phoenixd/common/rest/VoidResponse.java
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-base/src/main/java/xyz/tcheeric/phoenixd/common/rest/util/Configuration.java
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-base/src/main/java/xyz/tcheeric/phoenixd/common/rest/util/Constants.java
diff --git a/phoenixd-mock/src/main/java/xyz/tcheeric/phoenixd/mock/MockLnServer.java b/phoenixd-mock/src/main/java/xyz/tcheeric/phoenixd/mock/MockLnServer.java
index 885933f..aa0ce21 100644
--- a/phoenixd-mock/src/main/java/xyz/tcheeric/phoenixd/mock/MockLnServer.java
+++ b/phoenixd-mock/src/main/java/xyz/tcheeric/phoenixd/mock/MockLnServer.java
@@ -12,6 +12,8 @@
 
 @RequiredArgsConstructor
 public class MockLnServer {
+    private static final String BECH32_CHARSET = "qpzry9x8gf2tvdw0s3jn54khce6mua7l";
+    
     private HttpServer server;
 
     private final int port;
@@ -64,14 +66,12 @@ private String generateValidBolt11Invoice() {
 
         // Generate random payment hash (32 bytes = 52 chars in bech32, roughly)
         // For a minimal valid invoice, we need at least timestamp + payment hash
-        // Bech32 charset: qpzry9x8gf2tvdw0s3jn54khce6mua7l
         SecureRandom random = new SecureRandom();
         StringBuilder data = new StringBuilder();
-        String charset = "qpzry9x8gf2tvdw0s3jn54khce6mua7l";
 
         // Generate 52 random bech32 characters (represents ~32 bytes of data)
         for (int i = 0; i < 52; i++) {
-            data.append(charset.charAt(random.nextInt(charset.length())));
+            data.append(BECH32_CHARSET.charAt(random.nextInt(BECH32_CHARSET.length())));
         }
 
         // Calculate and append Bech32 checksum (6 characters)
@@ -85,8 +85,6 @@ private String generateValidBolt11Invoice() {
      * Simplified implementation for mock purposes.
      */
     private String calculateBech32Checksum(String hrp, String data) {
-        String charset = "qpzry9x8gf2tvdw0s3jn54khce6mua7l";
-
         // Expand HRP
         int[] values = new int[hrp.length() * 2 + 1 + data.length() + 6];
         int idx = 0;
@@ -98,7 +96,7 @@ private String calculateBech32Checksum(String hrp, String data) {
             values[idx++] = hrp.charAt(i) & 31;
         }
         for (int i = 0; i < data.length(); i++) {
-            values[idx++] = charset.indexOf(data.charAt(i));
+            values[idx++] = BECH32_CHARSET.indexOf(data.charAt(i));
         }
         for (int i = 0; i < 6; i++) {
             values[idx++] = 0;
@@ -109,7 +107,7 @@ private String calculateBech32Checksum(String hrp, String data) {
 
         StringBuilder checksum = new StringBuilder();
         for (int i = 0; i < 6; i++) {
-            checksum.append(charset.charAt((polymod >> (5 * (5 - i))) & 31));
+            checksum.append(BECH32_CHARSET.charAt((polymod >> (5 * (5 - i))) & 31));
         }
 
         return checksum.toString();
diff --git a/phoenixd-mock/target/classes/xyz/tcheeric/phoenixd/mock/Main.class b/phoenixd-mock/target/classes/xyz/tcheeric/phoenixd/mock/Main.class
new file mode 100644
index 0000000000000000000000000000000000000000..4ecc7042b20f7d9ddd02098b9edc53e9bfa1eb12
GIT binary patch
literal 2963
zcmb7GYjYD-7=BKZcGGmBG*FNhXt<S9Lc^_~1QjSPL{dP4RY1jUa+)kncH{20v>@K^
z_dDX{gEP+fg>eR*fdVsr^n>G1a>VCs(so<0gCDY+b9vwQd7t-r&z?X3x&1qUNAW`x
zbqHw)>!?SAz>@RExRERwRv~$O_`J+{0uB32%k&--2z6~9iXwtW4N)CU&;>dsCNCzv
zTv1BL%q1&DTUzEsK3TSNqsc+Tv;?$*^iJ3g{m?ue0`A^zq>pADOVGl}l3fspWo)OA
zbW0<<&L=Z=p&*@91WN_Brmb<KWai@)de|Gkbh#(qKT#nnnU6cfDEG#<Z`-k}r)PI>
z@6O&RTCrTi3LOt&r9jJUDrw7;bV@XIHztpd2rTbPZ_eDaBh`d<tkSSr#~O5yj`_F*
z>ZRk@bhW7~V4n3H(<-C_GgbCdim|m=r(wO04cIt`;OwO9$+AFLPMG8;OhiK(HqrG$
ztdiP{m6gu8bfW0QW>vV2QEWj%!&V(VNX|+9<e24|WhoG4A!Y`xUBTpQ(<u$x=Kwra
zbfl4wQ7Aig>_RWg<&3eW`@7Pa2ZWfK7soP&OOnOiBe2LVj(K_eg0;11+oMrz!y_t}
zy#kwq)Dm3PC_rwFZbj}E?9-`Z%Cp(X=d(4JN9a+YHRz|Bj9-vW?ALKX$-Un749AP0
zj~bj-?>VL3b4qclbp1L8aF|^{`lK~3&>3_(4dh;IQKa#NhNC(%7@Wgu)rML$-TrdL
zoAf*5j1up09VhUlK%`<guB2$^r7#^Wts%?an^o_zvGTBV25hHnc>NPOS@BHUir^`M
zJ=2WDU9(^rrMM$=(j1rho_N-?D;26X?)qYi+m_#Es>^zMR3AL8;~CWiVbdD1mDbMa
zIICC-yEKj9IdWbVVq8sB=v0}VQ)Vyx2XqR2SYYWabe6@wphOWtUZA~SHCOyX(JaZT
z(^-JZ_lW9C9vI#CDMFwIGfw?-n>epwR7VMHwiWX`dceqew!<nkvclEFM_^;ne_zRP
zT?%==Wr}!ft;2K5bWLV)z_M)5Q1rX%SS#7(VS6-rSX$CCcxurk+-K+6j?Ed<lGVDM
zQtA7LV9qEF8IGyOwaKtoH0f#Wg8jyWRyi*F2k!E&vjHZiB{Rfz!zs|!()%oPQR!Vk
zq^b0(9@vHp1`V7;48ADq8M)Cxqf)~iosprd;nnGin|3mNd}f8=nD*KL+WYF5-eZA1
zwTu|DWR!>V#s-!4hHd;<{GU^ad<fNE0mrkVVF&KZm1<wTXx1Kca&mx*q(;<7tw*Vs
zEq&0oJ=b%L%AoX$cHV7nz(-Mhj88Ots^c?!F0gJ^=%zJpkIH1m2TcoOWLkJl<>2VA
zp!8}+)c{8fD_@fCh71q4u}bh`Q{yC%%pAj0lNA}<{@{z%kPF)ePxzYWKBH91nx0H8
zK?7O&O5Ga1*6}9Z6428Yo5AlXNo`zZv)x0|{qoiDoxqxfw^F=Sa(Hk@c(DNl+SEmZ
zZ;PV_zHPqi`Q~+p&k9FLzJ;3Yz6o)if9miepK2L&<M63hH^7C*Q6t7M&Rxp*7dqmt
z28XAh?Q3rd<3}{M#}@sB)?cwW7HglvvRh~iAv}fn9dw><zlpBFDRke#w$ts2+t>lb
zcHhLqH;_u)z~d@>$Pd4cp}|{L7>kL&86C`HJ(eMX6*$QJ2C&YD7O#fK1x#>%7=4(;
zMZ!(+xV(gy2=g-MHPrph`&J8H_BRQ<f~dN}aihxOb-oo{9kGK`ICQl84@A3f;K)^I
zEuH$c?kOC*mQnw>traWD>B$<(Hqr!a<g=3~H*vL_t6La5;iFqlx9vprnjfNpwv%{+
z77EiMgosH)I&?_G$t6*xj~bpUbgx)VC=yS#`6Ld7u;m6$tC?qS;rTlJjOIZ#$|Y_=
zhH#y>z$y}D)WEG_+F;1VgcKu;Rq9g5XB?{uv15k5IGK1G@AwQPeEMj{1QdN@n!a-y
zj3(CP-5K4i^#f84vB(sPzhSW|o(O11BaZhtSBLlU0pE)44>|V*zU1!;XQG_>2H)a)
Gto#=M*7_^}

literal 0
HcmV?d00001

diff --git a/phoenixd-mock/target/classes/xyz/tcheeric/phoenixd/mock/MockLnServer.class b/phoenixd-mock/target/classes/xyz/tcheeric/phoenixd/mock/MockLnServer.class
new file mode 100644
index 0000000000000000000000000000000000000000..c8436de643c51b1a3b7c26602538211223753cab
GIT binary patch
literal 6572
zcmcIpd3+pKeg8h~F{|~&mRDNGYsZSRxulik^%dEXh>0X@OO9+Mma#E5*rVC8cCFo+
z&F-ut$&CTWfwUaq2#^HAVIbjZA%SdylR9mIlv3IPz1z^xgwTtt^Z?v6;``q0uGW#_
z>Ysi-*1UQ1-us>3-|^PpeCg~t05^y$H8cpUI%XU<lD6e0hxr(D%t_1bPo)Z0vDgSd
z0vdukG=v1MotmCWx@Ow43K=t*Pdk>KnMx&dJd)hS$A~><6^>g40e{{pxB_B041utY
zCC~+eugcgNcPm%hhdcI#u@uWRH0fB5h`<%5lS>v$wh|=my7{6al^o)0m1@u|ScYo}
z4788Dve13Q9V7oIu|BC<i;gH(P%w{|z?F+Q7{W?{OOg|oo3#zkOc7dhm5$Z8jI`2*
zoyt<i(e{x=nyc@k@(w9_g+6JoRvnk4jqE)`3_7-JP0`MWD)z`4_C#{bEoAJ8zKf|+
zrFl`t73zH<#HGS{W4caZ!X|{P1(qf~Q8M;%Cu3R>G{}W^xsb9<CuP+Zd~%^vK;uHz
za=FznzpSOnNSmmNAb?d;%k?@oV57j2qUCOzvdog}5K{4qjwLsfO`48vmI?*Sc9Yc|
zeIBH))6s*?0)e7yNC^7cz3<oS=#?P!7hNYG!m9)#&z*W|<MmsP88;Sbu}N!f&I(he
ztvX(f8_E5)LdLZ`V+!=PU(BA{rcAnh!s_#2S?`99eIX18#7@KumYK<CC~|+!DcSCr
z;l_K{ue)9He2tE6l4qmhxwGilVeG(=hG88$ag#ukg1bj|y69Rtfsk$3&fZLpP@|4J
z!`Ox08b)>8j9X~_xdS7PJwbI`XULkWsuOMB*)d;MDax3Ry?8C%J7L*Yfzh_l$YxRl
zPS#z&e%N!eKuh}qry~erzmC`8fWW0WW6~mkOvBxuanpRGJ8ZWouw@~r&Iwxq?*imQ
zI7skh?QwJcI$OgVs)?&efY4LZ$uaq2?P0h$xiAjluuMCfH5e4<<qQT&nQY1`gmDCi
zLr4j<-I|{%OkY2>W#Z@t_ju~Ib;XUx?CUm7rcJ9SS28wd!#Iiw4QU-29J|mVD&7d=
ztYuHQY2^;)y+g?A$ib%2HiLB7CKzSn<I+*&b=(SqI!N3U`YS7gQXE%D3CFo&<nxwI
z$u4UjoNtYa{7ec*Fr{N!dMxBRp7o>~Pw4m!<p|Trnx!oLIAEFSjT;8jmN{80<s!`J
zC#AFAB(QT)E}0LP`C?I?qj-ysQ%dcOowBAzk4kY)>$nqdr77}Gb~@)!tw8%h+QQd&
zZ2u#^Yi@p5&e!_!*m>U#0~^2ROSFuC$tPxKXG3_GK=+Bbp#nxm%er-4@sw3G3z@u|
zaqM_+e0|$MmZirq&5Z5DZx7+!gy)Gk;pUc#T=$YqO0K;3!WETtEUtuc58kig13Es4
zdszf7Qaq}G&g{Vgu*WLqiEL}gG6*JuJI=UxrPJOXX4Crxbd_6ew|nn&-U{Kv#1q|}
z%`jZ3Rq~ih03X3eHGE9R$8koW_2Og+I@Tgq=ta4*V_zdaiBD;GP{%{~G>fl_4?E)|
zB_5e}Swt8|Mj<um&8b`9wR^W8-omJ>l-|0{l}*a~pVjd>e4c2eeFmmoizizvLe<l+
z9_ctZAkF_fI=+A}3N#mq`FUmyv=8r;S^OS6qT@^WvcR%B>kl}oX@Qm1ltj5kOK!g8
zG8il)N1@7iOvB?kzJjwvfKv5ko2Z@2yb6{Bl2sW`>iAt%NX)ELv@|?L>E_bN-gLpa
z%^1(JWSqnA>-YnFl|_<17%S!TvURfPjg|G@sGU%S>gzbH;pq$V$msYn%Va88I<ReU
zXyb;%gG2p$#<uMx)aHjCc~x^N^K*$cz(2@hOT&z0Y-@KZH*OX7O7Y}rhdE%MQOL-7
z<)hzCXXu%ZMYkyI;)s1qMO{(DcdEvqA%{n6D-?^sF(-E!`3j?$*ADHl+>y*g+O^r4
zRC-H+_QloIj(tRvRjIH7SHEI}u~V$ZXCEuB$N6SsdOqi7Z*5SuleMbWSm{-U>AK*!
zs(5T+GmNctA<s_*Ra%&lJ%21%c*xkFGF;Z2*gUUQlQz|153SNLsUDa9qc0i`4wF+R
zHKpNszOYLn8r33aEXI7A=}Fq%ll?WSyQ;~qSHH^Eiq*cVJo_q2BohibIApWJ6YFIG
zAjKY6aTFN$g0|t{fQFw7tlq<3g<S?YWr`UhsNc37CRgSuQj3gao!q!HncPw77E+`X
z9&<_s)7qYq@LOJgF<2`Dh@c;E9JlBejQlRkO*^ULvLMcf@jrM`!~g1d3A0S4bFn7f
zGHE48jNEw2;0fcXVX`G;&@ai=&%RY3Zk0nGgCW&J7q1#|oXJvtfiA7iR~H<V`MG}k
z;uk%Z7e8BHKr567jcj&|eP>@2{$g1`G_ZIIpN>CQvw)oOGWOSM7Lv0@9e<-{OXN(~
z@vmyORL+*^_%}6ME@u%PKjJJXTEZeKR%qf<mVd#!%vJL&?X?kJ`?kGm>wEwIt?Tja
zJ6PupFDdedG*8Hyr9xtrz~*X~P-&~X;=Hfq*lZ6O#WdT1GzSsyiu0zIVM9B^y5AcY
z><R?$Y<{s`2v+4`n=S8P)?oH7YT|O{nt5Co!jmShV3E7{RtCBUK3u_e=<B>N@;-z=
z#5Z_9{v*yBVDgW*QNGLGEW~js*LauV_iu9c9i9^$??^lWaUk(!_#Q)}?{Qr6D4IEI
zj$E2Jix^nB*6dgFD>%QhZhjT#*VN6g<-DVAp5VNzZr;s#a&9ilSSRV0vFTxo(SSeZ
zGl4LlE6|LU<Q2n4DmBQ9@E9(mLTgY&D^BpvdJ1j$7I*5N3iuQJDQADiKdIEW`PWND
zg;I1cX-h?;lH1d0l7p{|EeSzQC2OBzE$@#YQw>*P8LmbPuB~Gct+4p6+Ams2lQC2=
z<&7lKz=cqvGtyVa4RiX0)%OI6b}C{kynPj7Jb}N&Us1X_$s1%eE<m@xjKP=FT}!&j
zMbl+mSLo)bs#G@iIJQ5IkzI*0_Uuk{c6Fb{KIx!3MxIqRlF=p_`#QR%M=?xz1Zs-J
zDvD@C+uss}4cvVR{*G_H3zXwsu;P{%NFhKWc1K=6@&pbYcnojc^#qP^9N+Eh@kjkl
zo6g{}?ugkHG0U*Zm@LC7qqzUHUpzGXe4?|vjN8hX>Gi9(nExzp2fnEMBcT*mnC~b5
zZM?T_C!~f6pq*I9u?M@+&x@^u&{keER}fBr&;8OUyDK{Ra1)+U@w9{x{2u;+IyIvY
z&*J-}*-!2Mk*j`4M8wcAOCtPf%dg?6hC>>T5OU{<)CPHP@>CYTAS)S&&va6uK-zz#
zi{p`|;E^Z8Qe|IHAR3TMXRxw6>ZhKa(EybW&5WK7Q0EuCkG|2mjj{TTO_!hacK$%^
zkkrp$wYP(IRK&`7v$y9twWld~2Ft5-6_=kRXxKaar+NYvZ}bLzJz7+gJKJKxh#3up
zLQyT1o*}!cOEil2Y%EBR%sF5m(+{Y7GhR>I9Hc`IVLivqcq4xiIZX2&;p{LBjPqV=
z;!PaygoV3#=ldYX2XG7zBFjcT$5z{BROc8gw<@R25MD9n0_n5>254vREyZ-`z1>Cb
z-rFM#X!)i|%hv$=OvSnK+p`L=%}kun;dwfD1)jza6dWETRPIzfzJP8z{QLBvba*$y
zFCnJk1tHF3&5H<gXnm2tex660H?+Kj79nA9o;jsK-c~Ch=pbfflFNsl3?J}C-Zpx`
zAGvGvKp^s)qX&YK-x@ujMczKT%fGd=*B|qr>k0UJg3(|!a0WNV{L$dr9&JriY^Eo)
zCi0Gxp{b~LYOAlOG1?e9gH_Q`v~k9N@;-#ubVVE2p4xi4k#70n=^&p^t@%88dYNu5
z;{ljrG)&WQGuXnEx|J{;VgTKOlXQx7#qCIQ&Bh(d;6pUuO*|nD*~r}q{E%-Uo?VB3
z;wX)quNgP53@NyO4F61%HjvLP_!sW;Df3;8z${5<DqdcYW>lsGTeUV;&K18zfd6=m
z-3OntT-E2;cV3X9yd3*Big1?_bul@Xear%M?_PlJ+e!Bwi>AwtXaTzKS%B`{r2Fng
z)8(&u6}qpZ34OFjgo)yPk^3SaD&qmB?hC5UQnllKbn`v@G5r0COPhD9=AuX?VaxX5
z#|r=THHg1hdi+EK;VPZGqw5iTqKwb%?p%&<bf3GkjNhgN4@;0TUpyM~KaFc*{xY6;
z2(7&VIc=#-_1<7CAald-#R5+~OtLE(xShP_ZeS|t<>;ZZRk6937`cxk-OpVg;=T`a
z=l#sy4=5!z5fm%27C*sHRj%GqQ)fp_ogMg@QYXYD^Y8dMsmp-vgMXH!ybOJhO49$K
zvD6WG=VsX%1r-$M7Wi4Mg?>eW=Pbi30yB??$gLb@)ek2g!`Bk4ABAtOJ_i}>V2O|g
z#=~Q{CTf_9hPeKpT$B6$i=z+!&1VCCfnRdm$@O2s$IBwS$jY0)_NLX|!nL<cYHv+E
X)y#u2^;|91kRJcjM6`-F5l8IT(29PQ

literal 0
HcmV?d00001

diff --git a/phoenixd-mock/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst b/phoenixd-mock/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst
new file mode 100644
index 0000000..f7becd1
--- /dev/null
+++ b/phoenixd-mock/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst
@@ -0,0 +1,2 @@
+xyz/tcheeric/phoenixd/mock/MockLnServer.class
+xyz/tcheeric/phoenixd/mock/Main.class
diff --git a/phoenixd-mock/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst b/phoenixd-mock/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
new file mode 100644
index 0000000..1616b0c
--- /dev/null
+++ b/phoenixd-mock/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
@@ -0,0 +1,2 @@
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-mock/src/main/java/xyz/tcheeric/phoenixd/mock/MockLnServer.java
+/home/runner/work/phoenixd-java/phoenixd-java/phoenixd-mock/src/main/java/xyz/tcheeric/phoenixd/mock/Main.java