From 7005fffc8fb47f11c36705709674a32e89456012 Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Wed, 17 Dec 2025 19:50:52 +0100 Subject: [PATCH 1/3] Add cmake option to toggle code gen for schema evolution tests --- tests/schema_evolution/CMakeLists.txt | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/tests/schema_evolution/CMakeLists.txt b/tests/schema_evolution/CMakeLists.txt index a3f0c9a78..61d4f922c 100644 --- a/tests/schema_evolution/CMakeLists.txt +++ b/tests/schema_evolution/CMakeLists.txt @@ -1,2 +1,6 @@ +option(PODIO_ENABLE_SCHEMA_EVOLUTION_TESTS "Enable the building and running of schema evolution related tests" OFF) + add_subdirectory(detection) -add_subdirectory(code_gen) +if (PODIO_ENABLE_SCHEMA_EVOLUTION_TESTS) + add_subdirectory(code_gen) +endif() From 456f3ec7c6f293f3deaa193d9c13a64b0e8fb3d5 Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Wed, 17 Dec 2025 19:53:04 +0100 Subject: [PATCH 2/3] Turn new option on for CI --- .github/workflows/edm4hep.yaml | 1 + .github/workflows/key4hep.yml | 1 + .github/workflows/pre-commit.yml | 1 + .github/workflows/sanitizers.yaml | 2 +- .github/workflows/test.yml | 1 + .github/workflows/ubuntu.yml | 1 + 6 files changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/workflows/edm4hep.yaml b/.github/workflows/edm4hep.yaml index 3f766ea77..a73d4361f 100644 --- a/.github/workflows/edm4hep.yaml +++ b/.github/workflows/edm4hep.yaml @@ -61,6 +61,7 @@ jobs: -DUSE_EXTERNAL_CATCH2=ON \ -DBUILD_TESTING=ON \ -DPODIO_RUN_STRACE_TEST=ON \ + -DPODIO_ENABLE_SCHEMA_EVOLUTION_TESTS=ON \ -G Ninja .. ninja -k0 echo "::endgroup::" diff --git a/.github/workflows/key4hep.yml b/.github/workflows/key4hep.yml index 50d231a30..0d1c43d85 100644 --- a/.github/workflows/key4hep.yml +++ b/.github/workflows/key4hep.yml @@ -51,6 +51,7 @@ jobs: -DENABLE_DATASOURCE=ON \ -DPODIO_SET_RPATH=ON \ -DPODIO_RUN_STRACE_TEST=ON \ + -DPODIO_ENABLE_SCHEMA_EVOLUTION_TESTS=ON \ -G Ninja .. echo "::endgroup::" echo "::group::Build" diff --git a/.github/workflows/pre-commit.yml b/.github/workflows/pre-commit.yml index e88fa61c2..d992dc59d 100644 --- a/.github/workflows/pre-commit.yml +++ b/.github/workflows/pre-commit.yml @@ -34,6 +34,7 @@ jobs: -DCMAKE_CXX_STANDARD=20 \ -DCMAKE_CXX_FLAGS=" -fdiagnostics-color=always -Werror "\ -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \ + -DPODIO_ENABLE_SCHEMA_EVOLUTION_TESTS=ON \ -DUSE_EXTERNAL_CATCH2=OFF ln -s $(pwd)/compile_commands.json ../ cd .. diff --git a/.github/workflows/sanitizers.yaml b/.github/workflows/sanitizers.yaml index 1bc398c40..aa0d74b83 100644 --- a/.github/workflows/sanitizers.yaml +++ b/.github/workflows/sanitizers.yaml @@ -52,7 +52,7 @@ jobs: -DENABLE_JULIA=OFF \ -DENABLE_RNTUPLE=ON \ -DENABLE_DATASOURCE=ON \ - -DPODIO_NO_MEMLIMIT_SCHEMA_EVOL_TESTS=ON \ + -DPODIO_ENABLE_SCHEMA_EVOLUTION_TESTS=ON \ -G Ninja .. echo "::endgroup::" echo "::group::Build" diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 3be5236aa..ea8b98009 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -47,6 +47,7 @@ jobs: -DCMAKE_CXX_FLAGS=" -fdiagnostics-color=always -Werror -Wno-error=deprecated-declarations " \ -DUSE_EXTERNAL_CATCH2=AUTO \ -DPODIO_USE_CLANG_FORMAT=AUTO \ + -DPODIO_ENABLE_SCHEMA_EVOLUTION_TESTS=ON \ -G Ninja .. echo "::endgroup::" echo "::group::Build" diff --git a/.github/workflows/ubuntu.yml b/.github/workflows/ubuntu.yml index f11764ea3..4187e4180 100644 --- a/.github/workflows/ubuntu.yml +++ b/.github/workflows/ubuntu.yml @@ -43,6 +43,7 @@ jobs: -DPODIO_SET_RPATH=ON \ -DPODIO_RUN_STRACE_TEST=ON \ -DENABLE_RNTUPLE=ON \ + -DPODIO_ENABLE_SCHEMA_EVOLUTION_TESTS=ON \ -G Ninja .. echo "::endgroup::" echo "::group::Build" From 260a4244f12a88d6b7471bafd0661e51e313e4f1 Mon Sep 17 00:00:00 2001 From: Thomas Madlener Date: Thu, 18 Dec 2025 15:47:21 +0100 Subject: [PATCH 3/3] Turn option ON by default --- tests/schema_evolution/CMakeLists.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/schema_evolution/CMakeLists.txt b/tests/schema_evolution/CMakeLists.txt index 61d4f922c..dfe7c668d 100644 --- a/tests/schema_evolution/CMakeLists.txt +++ b/tests/schema_evolution/CMakeLists.txt @@ -1,4 +1,4 @@ -option(PODIO_ENABLE_SCHEMA_EVOLUTION_TESTS "Enable the building and running of schema evolution related tests" OFF) +option(PODIO_ENABLE_SCHEMA_EVOLUTION_TESTS "Enable the building and running of schema evolution related tests" ON) add_subdirectory(detection) if (PODIO_ENABLE_SCHEMA_EVOLUTION_TESTS)