[BUG] Workspace diagnostics return the wrong logger ID

[guythetechie]

Release version

APIOps Toolkit for Azure APIM v7.0.0-alpha.1.0.3

Describe the bug

The extractor writes the wrong loggerId for workspace-scoped diagnostics that reference workspace-scoped loggers. This causes the publisher to fail when publishing the diagnostic.

Expected behavior

The diagnosticInformation.json file should look like:

{
  "properties": {
    "loggerId": "/workspaces/[workspacename]/loggers/[name]"
  }
}

Actual behavior

The diagnosticInformation.json file looks like:

{
  "properties": {
    "loggerId": "/loggers/[name]"
  }
}

Reproduction Steps

1. Add an application insights resource to the workspace (workspace -> Application insights).
2. Create a diagnostic that references the application insights resource (workspace -> APIs -> All APIs -> Settings).
3. Run the extractor. /artifacts/workspaces/workspaceName/diagnostics/diagnosticName/diagnosticInformation.json will have a service-level loggerId, not a workspace-level loggerId.
4. Run the publisher. It will fail with:

Could not obtain mandatory reference to WorkspaceLoggerResource in property LoggerId of DTO workspaces/name/diagnostics/name. Expected '/loggers/name' to match the format '.../workspaces/workspaceName/loggers/{name}'.'

[github-actions]

  Thank you for opening this issue! Please be patient while we will look into it and get back to you as this is an open source project. In the meantime make sure you take a look at the [closed issues](https://github.com/Azure/apiops/issues?q=is%3Aissue+is%3Aclosed) in case your question has already been answered. Don't forget to provide any additional information if needed (e.g. scrubbed logs, detailed feature requests,etc.).
  Whenever it's feasible, please don't hesitate to send a Pull Request (PR) our way. We'd greatly appreciate it, and we'll gladly assess and incorporate your changes.

[guythetechie]

Looks like a bug in the APIM REST API.

Listing all workspace diagnostics (GET /subscriptions/***/resourceGroups/***/providers/Microsoft.ApiManagement/service/***/workspaces/***/diagnostics?api-version=2024-05-01) strips out the workspace reference in loggerId.

{
  "value": [
...
        "loggerId": "/subscriptions/***/resourceGroups/***/providers/Microsoft.ApiManagement/service/***/loggers/name",
...
}

Getting the specific workspace diagnostic (GET /subscriptions/***/resourceGroups/***/providers/Microsoft.ApiManagement/service/***/workspaces/***/diagnostics/name?api-version=2024-05-01) returns the correct reference.

{
...
    "loggerId": "/subscriptions/***/resourceGroups/***/providers/Microsoft.ApiManagement/service/***/workspaces/***/loggers/name",
...
}

Seeing a similar bug in the REST API for workspace API diagnostics. Rather than deal with other potential bugs, will update the logic in workspace resources from "List all DTOs" to "List all DTOs, get names, get DTO for each name". Can significantly increase the number of API calls, but correctness matters more than performance.