Skip to content

add AKS Swiftv2 Manifold E2E in ACN pipeline #4128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sharifnasser wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add AKS Swiftv2 Manifold E2E in ACN pipeline #4128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a452830
add AKS Swiftv2 Manifold E2E in ACN pipeline
sharifnasser Nov 20, 2025
4b8616c
add AKS Swiftv2 Singularity E2E to ACN PR pipeline schedule
sharifnasser Nov 24, 2025
505bf8e
remove test schedule
sharifnasser Nov 24, 2025
ec71c51
limit run to one region
sharifnasser Dec 2, 2025
4690cce
use master branch
sharifnasser Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .pipelines/multitenancy/swiftv2-manifold-e2e.stages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
parameters:
name: ""
dependsOn: ""

stages:
- stage: manifolde2e
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stage name inconsistency: the stage is named "manifolde2e" (line 6) but it's missing an underscore. Consider changing to "manifold_e2e" to match the naming convention used for other E2E stages (e.g., "linux_azure_overlay_e2e", "aks_swift_e2e", etc.).

Suggested change
- stage: manifolde2e
- stage: manifold_e2e

Copilot uses AI. Check for mistakes.
displayName: E2E - AKS Swiftv2 Manifold
variables:
TAG: $[ stageDependencies.setup.env.outputs['EnvironmentalVariables.Tag'] ]
IMAGE_REPO_PATH: $[ format('{0}/', stageDependencies.setup.env.outputs['EnvironmentalVariables.imageRepositoryPath']) ]
${{ if eq(parameters.dependsOn, 'publish') }}:
IMAGE_REPO_PATH_REF: 'azure-'
${{ else }}:
IMAGE_REPO_PATH_REF: $(IMAGE_REPO_PATH)
dependsOn:
- ${{ parameters.dependsOn }}
- setup
jobs:
- job: ${{ parameters.name }}
displayName: AKS Swiftv2 Multitenancy Manifold E2E Test Suite - (${{ parameters.name }})
timeoutInMinutes: 210
pool:
name: $(BUILD_POOL_NAME_DEFAULT)
isCustom: true
type: linux
steps:
- task: TriggerBuild@3
inputs:
buildDefinition: '391699'
Copy link
Contributor

@kmurudi kmurudi Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if possible, add a comment somewhere in file on the URL of our runner that this will trigger, if not add in PR summary description

Copy link
Contributor Author

@sharifnasser sharifnasser Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runner is implied in the buildDefinition value, as the URL would be:
https://msazure.visualstudio.com/One/_build?**definitionId=391699**

Copy link
Contributor

@kmurudi kmurudi Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just add it in description if not already

templateParameters: 'regions: ["westus2"], useAcnPublic: true, cnscniversion: $(TAG), cnscniversionwindows: $(TAG), cnscniImagePrefix: $(IMAGE_REPO_PATH_REF)'
useSameBranch: false
queueBuildForUserThatTriggeredBuild: true
branchToUse: 'refs/heads/master'
waitForQueuedBuildsToFinish: true
authenticationMethod: 'OAuth Token'

Comment on lines +35 to +36
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected on this line. Please remove the trailing whitespace for consistency with the rest of the codebase.

Suggested change
authenticationMethod: 'OAuth Token'
authenticationMethod: 'OAuth Token'

Copilot uses AI. Check for mistakes.
7 changes: 7 additions & 0 deletions .pipelines/pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,6 +488,13 @@ stages:
dependsOn: ["test"]
scaleup: 50

- ${{ if eq(variables['Build.Reason'], 'Schedule') }}:
Copy link
Contributor

@kmurudi kmurudi Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this condition?

Copy link
Contributor Author

@sharifnasser sharifnasser Dec 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the ACN PR pipeline. We don't have enough infra (SKU quota, TiP sessions) for that many parallel runs (for every PR) on the Singularity Runners. Instead, this stage will only be included in Nightly Run schedule (once a day).

# AKS Swiftv2 Singularity E2E tests
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment indentation appears incorrect within the conditional block. The comment should be indented at the same level as the template inclusion below it (line 493). Both should be indented relative to the ${{ if ... }} conditional on line 491.

Suggested change
# AKS Swiftv2 Singularity E2E tests
# AKS Swiftv2 Singularity E2E tests

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions "Singularity" but the tests are actually "Manifold" E2E tests. Please update the comment to "# AKS Swiftv2 Manifold E2E tests" to match the actual functionality.

Suggested change
# AKS Swiftv2 Singularity E2E tests
# AKS Swiftv2 Manifold E2E tests

Copilot uses AI. Check for mistakes.
- template: multitenancy/swiftv2-manifold-e2e.stages.yaml
parameters:
name: "swiftv2_manifold_e2e"
dependsOn: publish

Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing whitespace detected on this line. Please remove the trailing whitespace for consistency with the rest of the codebase.

Suggested change

Copilot uses AI. Check for mistakes.
- stage: delete
displayName: Delete Clusters
condition: always()
Expand Down
7 changes: 6 additions & 1 deletion .pipelines/run-pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,12 @@ stages:
vmSize: Standard_B2ms
dependsOn: manifests
scaleup: 50


# AKS Swiftv2 Singularity E2E tests
Copy link

Copilot AI Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentions "Singularity" but the tests are actually "Manifold" E2E tests. Please update the comment to "# AKS Swiftv2 Manifold E2E tests" to match the actual functionality.

Suggested change
# AKS Swiftv2 Singularity E2E tests
# AKS Swiftv2 Manifold E2E tests

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@kmurudi kmurudi Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 let's have uniformity in naming

- template: multitenancy/swiftv2-manifold-e2e.stages.yaml
parameters:
name: "swiftv2_manifold_e2e"
dependsOn: manifests

- stage: delete
displayName: Delete Clusters
Expand Down
Loading