test #4148
Open
test #4148
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/azp run NPM Scale Test, NPM Conformance Tests |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Copilot finished reviewing on behalf of
rejain789
November 26, 2025 21:08
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds an extra period to a comment in the translatePolicy.go file, changing "destination side." to "destination side.." However, this appears to be unintentional as it results in a double period at the end of the comment, which is a spelling/punctuation error.
- Single character change: Added an extra period to a comment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| func portRule(ruleIPSets []*ipsets.TranslatedIPSet, acl *policies.ACLPolicy, portRule *networkingv1.NetworkPolicyPort, portType netpolPortType) []*ipsets.TranslatedIPSet { | ||
| // port rule is always applied to destination side. | ||
| // port rule is always applied to destination side.. |
There was a problem hiding this comment.
Extra period at the end of the comment. The comment should end with a single period.
Suggested change
| // port rule is always applied to destination side.. | |
| // port rule is always applied to destination side. |
Contributor
|
Being nit picky here, can you give this PR an appropriate title? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Issue Fixed:
Requirements:
Notes: