Align agent validation tests with structured_output rules

Author: brandonkachen

common/src/__tests__/agent-validation.test.ts

@@ -750,7 +750,7 @@ describe('Agent Validation', () => {
       expect(typeof result.templates['test-agent'].handleSteps).toBe('string')
     })
 
-    test('should require set_output tool for handleSteps with json output mode', () => {
+    test('allows handleSteps with structured_output without set_output (LLM handles output)', () => {
       const {
         DynamicAgentTemplateSchema,
       } = require('../types/dynamic-agent-template')
@@ -765,18 +765,14 @@ describe('Agent Validation', () => {
         systemPrompt: 'Test',
         instructionsPrompt: 'Test',
         stepPrompt: 'Test',
-        toolNames: ['end_turn'], // Missing set_output
+        toolNames: ['end_turn'], // set_output not required in current validation
         spawnableAgents: [],
         handleSteps:
           'function* () { yield { toolName: "set_output", input: {} } }',
       }
 
       const result = DynamicAgentTemplateSchema.safeParse(agentConfig)
-      expect(result.success).toBe(false)
-      if (!result.success) {
-        const errorMessage = result.error.issues[0]?.message || ''
-        expect(errorMessage).toContain('set_output')
-      }
+      expect(result.success).toBe(true)
     })
 
     // Note: The validation that rejected set_output without structured_output mode was

common/src/__tests__/dynamic-agent-template-schema.test.ts

@@ -248,27 +248,15 @@ describe('DynamicAgentDefinitionSchema', () => {
       })
     })
 
-    it('should reject template with outputMode structured_output but missing set_output tool', () => {
+    it('allows structured_output without set_output tool (LLM handles output)', () => {
       const template = {
         ...validBaseTemplate,
         outputMode: 'structured_output' as const,
         toolNames: ['end_turn', 'read_files'], // Missing set_output
       }
 
       const result = DynamicAgentTemplateSchema.safeParse(template)
-      expect(result.success).toBe(false)
-      if (!result.success) {
-        // Find the specific error about set_output tool
-        const setOutputError = result.error.issues.find((issue) =>
-          issue.message.includes(
-            "outputMode 'structured_output' requires the 'set_output' tool",
-          ),
-        )
-        expect(setOutputError).toBeDefined()
-        expect(setOutputError?.message).toContain(
-          "outputMode 'structured_output' requires the 'set_output' tool",
-        )
-      }
+      expect(result.success).toBe(true)
     })
 
     it('should accept template with outputMode structured_output and set_output tool', () => {

common/src/__tests__/handlesteps-parsing.test.ts

@@ -143,7 +143,7 @@ describe('handleSteps Parsing Tests', () => {
     expect(typeof result.templates['test-agent'].handleSteps).toBe('string')
   })
 
-  test('should require set_output tool for handleSteps with json output mode', () => {
+  test('allows handleSteps with structured_output without set_output (LLM handles output)', () => {
     const {
       DynamicAgentTemplateSchema,
     } = require('../types/dynamic-agent-template')
@@ -155,7 +155,7 @@ describe('handleSteps Parsing Tests', () => {
       spawnerPrompt: 'Testing handleSteps',
       model: 'claude-3-5-sonnet-20241022',
       outputMode: 'structured_output' as const,
-      toolNames: ['end_turn'], // Missing set_output
+      toolNames: ['end_turn'], // set_output not required in current validation
       spawnableAgents: [],
       systemPrompt: 'Test',
       instructionsPrompt: 'Test',
@@ -166,11 +166,7 @@ describe('handleSteps Parsing Tests', () => {
     }
 
     const result = DynamicAgentTemplateSchema.safeParse(agentConfig)
-    expect(result.success).toBe(false)
-    if (!result.success) {
-      const errorMessage = result.error.issues[0]?.message || ''
-      expect(errorMessage).toContain('set_output')
-    }
+    expect(result.success).toBe(true)
   })
 
   test('should validate that handleSteps is a generator function', async () => {