Skip to content

Add IResourceWithServiceDiscovery to BunAppResource and VS Code extension recommendations #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+20 −1
Closed

Add IResourceWithServiceDiscovery to BunAppResource and VS Code extension recommendations #1036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5d9479
Initial plan
Copilot Dec 4, 2025
54bb32c
Add IResourceWithServiceDiscovery to BunAppResource and VS Code exten…
Copilot Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions examples/bun/api/.vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"recommendations": ["oven.bun-vscode"]
}
2 changes: 1 addition & 1 deletion src/CommunityToolkit.Aspire.Hosting.Bun/BunAppResource.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@ namespace Aspire.Hosting.ApplicationModel;
/// <param name="name">The name of the resource.</param>
/// <param name="workingDirectory">The working directory for the Bun app to launch from.</param>
public class BunAppResource(string name, string workingDirectory) :
ExecutableResource(name, "bun", workingDirectory);
ExecutableResource(name, "bun", workingDirectory), IResourceWithServiceDiscovery;
16 changes: 16 additions & 0 deletions tests/CommunityToolkit.Aspire.Hosting.Bun.Tests/AddBunAppTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,4 +159,20 @@ public void BunAppWithPackageInstallationCreatesInstallerResource()
Assert.Equal("bun-bun-install", installerResource.Name);
Assert.Equal("bun", installerResource.Command);
}

[Fact]
public void BunAppResourceImplementsIResourceWithServiceDiscovery()
{
var builder = DistributedApplication.CreateBuilder();

builder.AddBunApp("bun");

using var app = builder.Build();

var appModel = app.Services.GetRequiredService<DistributedApplicationModel>();

var resource = Assert.Single(appModel.Resources.OfType<BunAppResource>());

Assert.IsAssignableFrom<IResourceWithServiceDiscovery>(resource);
}
}