From 03034138e991bf9b9f84ba930779ef915f1a5c7f Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Sat, 28 Dec 2024 03:09:14 +0200 Subject: [PATCH 01/16] feat: upgrade sfml to 3 and imgui to 1.91 and other to exp --- external/CMakeLists.txt | 8 ++++---- include/Audio.h | 2 +- include/Interface.h | 2 +- include/Program.h | 2 +- src/Audio.cpp | 4 ++-- src/Interface.cpp | 8 ++++---- src/Program.cpp | 26 ++++++++++++++------------ src/SortingAlgorithm.cpp | 2 +- 8 files changed, 28 insertions(+), 26 deletions(-) diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt index 089b36c..12b7450 100644 --- a/external/CMakeLists.txt +++ b/external/CMakeLists.txt @@ -4,13 +4,13 @@ Set(FETCHCONTENT_QUIET FALSE) FetchContent_Declare(SFML GIT_REPOSITORY https://github.com/SFML/SFML.git - GIT_TAG 2.6.1 + GIT_TAG 3.0.0 GIT_PROGRESS TRUE) FetchContent_MakeAvailable(SFML) FetchContent_Declare(ImGui GIT_REPOSITORY https://github.com/ocornut/imgui - GIT_TAG v1.88 + GIT_TAG v1.91.1 GIT_PROGRESS TRUE) FetchContent_MakeAvailable(ImGui) @@ -19,13 +19,13 @@ set(IMGUI_SFML_FIND_SFML OFF) set(IMGUI_SFML_IMGUI_DEMO ON) FetchContent_Declare(ImGui-SFML GIT_REPOSITORY https://github.com/eliasdaler/imgui-sfml - GIT_TAG v2.6 + GIT_TAG 3eb1ece0fed8351e89e69d4f72cf762ac1c4f4cf GIT_PROGRESS TRUE) FetchContent_MakeAvailable(ImGui-SFML) FetchContent_Declare(ImPlot GIT_REPOSITORY https://github.com/epezent/implot - GIT_TAG v0.16 + GIT_TAG f1b0792cd3e239f615d4f20b9647d37594de8c56 GIT_PROGRESS TRUE) FetchContent_MakeAvailable(ImPlot) diff --git a/include/Audio.h b/include/Audio.h index 1d3f692..ffe10f9 100644 --- a/include/Audio.h +++ b/include/Audio.h @@ -10,7 +10,7 @@ class Audio static sf::Sound& sound(); static sf::SoundBuffer& buffer(); - inline static sf::Int16 samples[44100]; + inline static std::int16_t samples[44100]; public: inline static bool enabled = true; diff --git a/include/Interface.h b/include/Interface.h index 43c46fb..2460dff 100644 --- a/include/Interface.h +++ b/include/Interface.h @@ -33,6 +33,6 @@ class Interface static void shutdown(); static void draw(sf::RenderWindow& window); - static void pollEvent(sf::Event& theEvent); + static void pollEvent(sf::RenderWindow& window, sf::Event& theEvent); static void update(sf::RenderWindow& window, sf::Time diffTime); }; \ No newline at end of file diff --git a/include/Program.h b/include/Program.h index f0917b6..1b56f36 100644 --- a/include/Program.h +++ b/include/Program.h @@ -15,7 +15,7 @@ class Program inline static sf::Time lastTime; static void draw(sf::RenderWindow& window); - static void pollEvent(sf::Event& theEvent); + static void pollEvent(sf::RenderWindow& window, sf::Event& theEvent); static void update(sf::RenderWindow& window); public: diff --git a/src/Audio.cpp b/src/Audio.cpp index 34a3d1a..81e0d85 100644 --- a/src/Audio.cpp +++ b/src/Audio.cpp @@ -9,7 +9,7 @@ constexpr auto TWOPI = 6.283185307f; sf::Sound& Audio::sound() { - static sf::Sound theSound; + static sf::Sound theSound(Audio::buffer()); return theSound; } @@ -60,7 +60,7 @@ void Audio::play(unsigned value) { } sound().stop(); - buffer().loadFromSamples(&samples[0], 44100, 1, 44100); + bool might = buffer().loadFromSamples(&samples[0], 44100, 1, 44100, std::vector{sf::SoundChannel::FrontCenter}); sound().setPitch(pitch); sound().play(); } diff --git a/src/Interface.cpp b/src/Interface.cpp index 4c48253..8d91d88 100644 --- a/src/Interface.cpp +++ b/src/Interface.cpp @@ -55,7 +55,7 @@ void Interface::changedAlgorithm() { } void Interface::initialize(sf::RenderWindow& window) { - ImGui::SFML::Init(window); + bool might = ImGui::SFML::Init(window); ImGui::CreateContext(); ImPlot::CreateContext(); @@ -364,7 +364,7 @@ void Interface::draw(sf::RenderWindow& window) { unsigned numbersSize = Settings::NUMBERS_DOWNSAMPLE == Settings::SAMPLING::NONE ? unsigned(sorterNumbers->size()) : unsigned(downsampledNumbers.size()); const unsigned* numbers = Settings::NUMBERS_DOWNSAMPLE == Settings::SAMPLING::NONE ? sorterNumbers->data() : downsampledNumbers.data(); - float plotSizeHeight = ImGui::GetWindowContentRegionMax().y - ImGui::GetTextLineHeightWithSpacing() - 40; + float plotSizeHeight = ImGui::GetContentRegionAvail().y - ImGui::GetTextLineHeightWithSpacing() - 40; ImPlotAxisFlags axisFlags = ImPlotAxisFlags_NoGridLines | ImPlotAxisFlags_NoSideSwitch | ImPlotAxisFlags_NoHighlight; if(Settings::PLOT_SHOW_SCALE && Settings::PLOT_TYPE == Settings::PLOT_TYPES::HEATMAP) { @@ -467,8 +467,8 @@ void Interface::draw(sf::RenderWindow& window) { ImGui::SFML::Render(window); } -void Interface::pollEvent(sf::Event& theEvent) { - ImGui::SFML::ProcessEvent(theEvent); +void Interface::pollEvent(sf::RenderWindow& window, sf::Event& theEvent) { + ImGui::SFML::ProcessEvent(window, theEvent); } void Interface::update(sf::RenderWindow& window, sf::Time diffTime) { diff --git a/src/Program.cpp b/src/Program.cpp index 8e8b2dd..d5bcf1c 100644 --- a/src/Program.cpp +++ b/src/Program.cpp @@ -13,8 +13,8 @@ void Program::draw(sf::RenderWindow& window) { Interface::draw(window); } -void Program::pollEvent(sf::Event& theEvent) { - Interface::pollEvent(theEvent); +void Program::pollEvent(sf::RenderWindow& window, sf::Event& theEvent) { + Interface::pollEvent(window, theEvent); } void Program::update(sf::RenderWindow& window) { @@ -26,8 +26,8 @@ void Program::update(sf::RenderWindow& window) { int Program::start() { sf::ContextSettings contextSettings; - contextSettings.antialiasingLevel = 16; - sf::RenderWindow window(sf::VideoMode(1290, 720), "ImGui-Visualizer", sf::Style::Default, contextSettings); + contextSettings.antiAliasingLevel = 16; + sf::RenderWindow window(sf::VideoMode(sf::Vector2u(1290, 720)), "ImGui-Visualizer", sf::Style::Default, sf::State::Windowed, contextSettings); window.setVerticalSyncEnabled(true); Manager::initialize(); @@ -35,15 +35,17 @@ int Program::start() { Audio::initialize(); while (window.isOpen()) { - sf::Event theEvent; - while (window.pollEvent(theEvent)) { - if (theEvent.type == sf::Event::Closed) { - Interface::shutdown(); - window.close(); - return 0; + while (const std::optional mightEvent = window.pollEvent()) { + if (mightEvent) { + sf::Event theEvent = mightEvent.value(); + if (theEvent.is()) { + Interface::shutdown(); + window.close(); + return 0; + } + + Program::pollEvent(window, theEvent); } - - Program::pollEvent(theEvent); } Program::update(window); diff --git a/src/SortingAlgorithm.cpp b/src/SortingAlgorithm.cpp index 0661341..f073ad5 100644 --- a/src/SortingAlgorithm.cpp +++ b/src/SortingAlgorithm.cpp @@ -40,7 +40,7 @@ SortingAlgorithm::stepState SortingAlgorithm::checkStep() { //else stats.sortTimeMs = stats.sortTimeMs + theClock.getElapsedTime().asSeconds() * 1000; - sf::sleep(sf::microseconds(sf::Int64(Manager::delayMs * 1000))); + sf::sleep(sf::microseconds(std::int64_t(Manager::delayMs * 1000))); theClock.restart(); if (m_doStep) { From 520c7548acadf20597dbf123106fec7430e6fb57 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 22:07:21 +0300 Subject: [PATCH 02/16] stable imgui-sfml v3 and latest implot --- external/CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt index 12b7450..9a2d07d 100644 --- a/external/CMakeLists.txt +++ b/external/CMakeLists.txt @@ -19,13 +19,13 @@ set(IMGUI_SFML_FIND_SFML OFF) set(IMGUI_SFML_IMGUI_DEMO ON) FetchContent_Declare(ImGui-SFML GIT_REPOSITORY https://github.com/eliasdaler/imgui-sfml - GIT_TAG 3eb1ece0fed8351e89e69d4f72cf762ac1c4f4cf + GIT_TAG v3.0 GIT_PROGRESS TRUE) FetchContent_MakeAvailable(ImGui-SFML) FetchContent_Declare(ImPlot GIT_REPOSITORY https://github.com/epezent/implot - GIT_TAG f1b0792cd3e239f615d4f20b9647d37594de8c56 + GIT_TAG 3da8bd34299965d3b0ab124df743fe3e076fa222 GIT_PROGRESS TRUE) FetchContent_MakeAvailable(ImPlot) From ed42bad5d06b9b5769b189e046a014f9775dd597 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:00:42 +0300 Subject: [PATCH 03/16] fix sounds not sounding --- src/Audio.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/Audio.cpp b/src/Audio.cpp index 81e0d85..99b2818 100644 --- a/src/Audio.cpp +++ b/src/Audio.cpp @@ -6,6 +6,8 @@ #include "Utilities.h" #include "Settings.h" +#include + constexpr auto TWOPI = 6.283185307f; sf::Sound& Audio::sound() { @@ -59,8 +61,12 @@ void Audio::play(unsigned value) { samples[i] = SquareWave(i, freq, amp); } + static auto channelMap = std::vector{ + sf::SoundChannel::Mono, + }; + sound().stop(); - bool might = buffer().loadFromSamples(&samples[0], 44100, 1, 44100, std::vector{sf::SoundChannel::FrontCenter}); + bool _might = buffer().loadFromSamples(samples, 44100, 1, 44100, channelMap); sound().setPitch(pitch); sound().play(); } From d90f057fe4fb89434ee4b26d052bffb955c0585b Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:01:06 +0300 Subject: [PATCH 04/16] remove iostream redundant include --- src/Audio.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/Audio.cpp b/src/Audio.cpp index 99b2818..faf09f5 100644 --- a/src/Audio.cpp +++ b/src/Audio.cpp @@ -6,8 +6,6 @@ #include "Utilities.h" #include "Settings.h" -#include - constexpr auto TWOPI = 6.283185307f; sf::Sound& Audio::sound() { From c6e283a360aab7020866b9c7c0cde56875511879 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:22:29 +0300 Subject: [PATCH 05/16] remove unused imgui-sfml v3 flag --- external/CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/external/CMakeLists.txt b/external/CMakeLists.txt index 9a2d07d..ef1e70d 100644 --- a/external/CMakeLists.txt +++ b/external/CMakeLists.txt @@ -16,7 +16,6 @@ FetchContent_MakeAvailable(ImGui) set(IMGUI_DIR "${imgui_SOURCE_DIR}") set(IMGUI_SFML_FIND_SFML OFF) -set(IMGUI_SFML_IMGUI_DEMO ON) FetchContent_Declare(ImGui-SFML GIT_REPOSITORY https://github.com/eliasdaler/imgui-sfml GIT_TAG v3.0 From 24c4ef5eb35be5b8ee8b0d56c918d792ccf6e66e Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:33:14 +0300 Subject: [PATCH 06/16] add missing x11 sfml dependency on linux --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8764f25..749c468 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Install Linux Dependencies if: runner.os == 'Linux' - run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libopenal-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev + run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libopenal-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libx11-dev - name: Checkout uses: actions/checkout@v3 From 165e635cc1f337dd46cd845ae25d7d97bc214246 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:34:12 +0300 Subject: [PATCH 07/16] ci: remove unused openal linux dependency --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 749c468..57c2d1b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Install Linux Dependencies if: runner.os == 'Linux' - run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libopenal-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libx11-dev + run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libx11-dev - name: Checkout uses: actions/checkout@v3 From 3b0960cc8acf4e0fe673b0facf59d8839cf259ef Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:38:56 +0300 Subject: [PATCH 08/16] something something linux pls compile --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 57c2d1b..8c2c289 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Install Linux Dependencies if: runner.os == 'Linux' - run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libx11-dev + run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libx11-dev libxi-dev - name: Checkout uses: actions/checkout@v3 From 498c8ab479ba2c3dc16a8f3b87935897d02fbc12 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:40:28 +0300 Subject: [PATCH 09/16] unneeded dep? --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8c2c289..8899d1e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Install Linux Dependencies if: runner.os == 'Linux' - run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libx11-dev libxi-dev + run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libxi-dev - name: Checkout uses: actions/checkout@v3 From 459cf5a2e6407b17d900bb26f5442118634d0460 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:41:27 +0300 Subject: [PATCH 10/16] freetype linux dep --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8899d1e..daa7504 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Install Linux Dependencies if: runner.os == 'Linux' - run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libxi-dev + run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libxi-dev libfreetype-dev - name: Checkout uses: actions/checkout@v3 From 483a53dd7331a259d1fc9c63fb6c6b40523badf8 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:44:38 +0300 Subject: [PATCH 11/16] maybe mesa isnt needed? --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index daa7504..d8ab384 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Install Linux Dependencies if: runner.os == 'Linux' - run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libxi-dev libfreetype-dev + run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libxi-dev libfreetype-dev - name: Checkout uses: actions/checkout@v3 From 551e686211a6485187bcc574f1b842b51f4dad50 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:46:21 +0300 Subject: [PATCH 12/16] yes we need opengl lol --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index d8ab384..daa7504 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -19,7 +19,7 @@ jobs: steps: - name: Install Linux Dependencies if: runner.os == 'Linux' - run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libxi-dev libfreetype-dev + run: sudo apt-get update && sudo apt-get install libxrandr-dev libxcursor-dev libudev-dev libflac-dev libvorbis-dev libgl1-mesa-dev libegl1-mesa-dev libxi-dev libfreetype-dev - name: Checkout uses: actions/checkout@v3 From 6644e454889189f392615769c68b3106c12bb7c9 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:52:54 +0300 Subject: [PATCH 13/16] update the readme --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index f99c0f6..db1ab94 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # StylishVisualizer This is a program which visualizes a bunch of [sorting algorithms](https://en.wikipedia.org/wiki/Sorting_algorithm). -Made in C++17 using [SFML](https://github.com/SFML/SFML) 2.6.1, [ImGui](https://github.com/ocornut/imgui) 1.88 (+[imgui-sfml](https://github.com/eliasdaler/imgui-sfml) 2.6) and [ImPlot](https://github.com/epezent/implot) 0.16, the code is completely cross platform (checkout the [releases](https://github.com/CosminPerRam/StylishVisualizer/releases) page)! +Made in C++17 using [SFML](https://github.com/SFML/SFML) 3.0.0, [ImGui](https://github.com/ocornut/imgui) 1.91.1 (+[imgui-sfml](https://github.com/eliasdaler/imgui-sfml) 3.0) and [ImPlot](https://github.com/epezent/implot) (`master`), the code is completely cross platform! ![Default Interface](.github/readme/interface_default.png) ![Sorting ](.github/readme/sorters_variety.jpg) @@ -39,7 +39,7 @@ cmake -B build cmake --build build --config Release ``` *Note:* Every dependency is handled by cmake. -*Windows note:* After building, you need to copy `openal32.dll` (it's at `build\_deps\sfml-src\extlibs\bin\`) to the `sorting-visualizer.exe`'s directory. +*Linux note:* Additional system dependencies are needed for SFML, check [the docs](https://www.sfml-dev.org/tutorials/3.0/getting-started/build-from-source/#introduction) or the [github actions workflow file](.github/workflows/ci.yml). ## Special thanks [@ChrisTrasher](https://github.com/ChrisThrasher) - for the cmake script, CI script and testing. From 0ac15e2be0e9d1cd257478b7e1ba01f6ca10b11e Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:54:21 +0300 Subject: [PATCH 14/16] specify implot master commit hash --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index db1ab94..24d5d9d 100644 --- a/README.md +++ b/README.md @@ -1,6 +1,6 @@ # StylishVisualizer This is a program which visualizes a bunch of [sorting algorithms](https://en.wikipedia.org/wiki/Sorting_algorithm). -Made in C++17 using [SFML](https://github.com/SFML/SFML) 3.0.0, [ImGui](https://github.com/ocornut/imgui) 1.91.1 (+[imgui-sfml](https://github.com/eliasdaler/imgui-sfml) 3.0) and [ImPlot](https://github.com/epezent/implot) (`master`), the code is completely cross platform! +Made in C++17 using [SFML](https://github.com/SFML/SFML) 3.0.0, [ImGui](https://github.com/ocornut/imgui) 1.91.1 (+[imgui-sfml](https://github.com/eliasdaler/imgui-sfml) 3.0) and [ImPlot](https://github.com/epezent/implot) (`master 3da8bd3`), the code is completely cross platform! ![Default Interface](.github/readme/interface_default.png) ![Sorting ](.github/readme/sorters_variety.jpg) From 63887cba6dbd2ae05358b025f04939552f9cfd8f Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:55:39 +0300 Subject: [PATCH 15/16] add file endline to Interface.h --- include/Interface.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/Interface.h b/include/Interface.h index 2460dff..9546f80 100644 --- a/include/Interface.h +++ b/include/Interface.h @@ -35,4 +35,4 @@ class Interface static void draw(sf::RenderWindow& window); static void pollEvent(sf::RenderWindow& window, sf::Event& theEvent); static void update(sf::RenderWindow& window, sf::Time diffTime); -}; \ No newline at end of file +}; From f26c2fabce5e18d8d14cd755f3eafb894e7b2d15 Mon Sep 17 00:00:00 2001 From: CosminPerRam Date: Tue, 15 Apr 2025 23:56:37 +0300 Subject: [PATCH 16/16] add _ prefix to unchecked var --- src/Interface.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Interface.cpp b/src/Interface.cpp index 8d91d88..8098a42 100644 --- a/src/Interface.cpp +++ b/src/Interface.cpp @@ -55,7 +55,7 @@ void Interface::changedAlgorithm() { } void Interface::initialize(sf::RenderWindow& window) { - bool might = ImGui::SFML::Init(window); + bool _might = ImGui::SFML::Init(window); ImGui::CreateContext(); ImPlot::CreateContext();