From f39a194b2abb1e900e48b3d2849d221714d4b483 Mon Sep 17 00:00:00 2001 From: TaprootFreak <142087526+TaprootFreak@users.noreply.github.com> Date: Fri, 2 Jan 2026 11:54:59 +0100 Subject: [PATCH 1/2] fix(swap): correct misleading includeTx default value The controller always passes an explicit boolean via `includeTx === 'true'`, so the service default was never used. Change from `true` to `false` to accurately reflect the actual behavior (depositTx is only included when explicitly requested via ?includeTx=true). --- src/subdomains/core/buy-crypto/routes/swap/swap.service.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/subdomains/core/buy-crypto/routes/swap/swap.service.ts b/src/subdomains/core/buy-crypto/routes/swap/swap.service.ts index ee33e1fea9..08e97714fb 100644 --- a/src/subdomains/core/buy-crypto/routes/swap/swap.service.ts +++ b/src/subdomains/core/buy-crypto/routes/swap/swap.service.ts @@ -163,7 +163,7 @@ export class SwapService { }); } - async createSwapPaymentInfo(userId: number, dto: GetSwapPaymentInfoDto, includeTx = true): Promise { + async createSwapPaymentInfo(userId: number, dto: GetSwapPaymentInfoDto, includeTx = false): Promise { const swap = await Util.retry( () => this.createSwap(userId, dto.sourceAsset.blockchain, dto.targetAsset, true), 2, From cdd5a3d8493048ed934b3cae27f112b1d44f0973 Mon Sep 17 00:00:00 2001 From: TaprootFreak <142087526+TaprootFreak@users.noreply.github.com> Date: Fri, 2 Jan 2026 13:30:31 +0100 Subject: [PATCH 2/2] fix(custody): pass explicit includeTx=false to swap service Make custody order swap calls explicit about not including depositTx, matching the pattern used for sell orders. This ensures the default value change in swap.service.ts has no functional impact. Affected calls: - CustodyOrderType.SWAP - CustodyOrderType.SEND - CustodyOrderType.RECEIVE --- src/subdomains/core/custody/services/custody-order.service.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/subdomains/core/custody/services/custody-order.service.ts b/src/subdomains/core/custody/services/custody-order.service.ts index c7cdadabc7..5eba45ff65 100644 --- a/src/subdomains/core/custody/services/custody-order.service.ts +++ b/src/subdomains/core/custody/services/custody-order.service.ts @@ -114,6 +114,7 @@ export class CustodyOrderService { const swapPaymentInfo = await this.swapService.createSwapPaymentInfo( jwt.user, GetCustodyOrderDtoMapper.getSwapPaymentInfo(dto, sourceAsset, targetAsset), + false, ); orderDto.swap = await this.swapService.getById(swapPaymentInfo.routeId); @@ -142,6 +143,7 @@ export class CustodyOrderService { const swapPaymentInfo = await this.swapService.createSwapPaymentInfo( targetUser.id, GetCustodyOrderDtoMapper.getSwapPaymentInfo(dto, sourceAsset, targetAsset), + false, ); orderDto.swap = await this.swapService.getById(swapPaymentInfo.routeId); @@ -160,6 +162,7 @@ export class CustodyOrderService { const swapPaymentInfo = await this.swapService.createSwapPaymentInfo( jwt.user, GetCustodyOrderDtoMapper.getSwapPaymentInfo(dto, sourceAsset, targetAsset), + false, ); orderDto.swap = await this.swapService.getById(swapPaymentInfo.routeId);