forked from mempool/mempool
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentationhelp wantedExtra attention is neededExtra attention is neededinvalidThis doesn't seem rightThis doesn't seem rightquestionFurther information is requestedFurther information is requested
Description
Reviewer's Guide
This PR corrects a redirect path calculation in the frontend utilities and adds a comprehensive suite of CI/CD configurations (GitHub Actions and CircleCI) alongside a security policy document.
Sequence diagram for corrected demo redirect logic in frontend
sequenceDiagram
participant "User (browser)" as User
participant "handleDemoRedirect()" as HandleDemoRedirect
participant "window.location" as WindowLocation
User->>HandleDemoRedirect: Navigates to demo route
HandleDemoRedirect->>HandleDemoRedirect: Calculate current and next path
HandleDemoRedirect->>WindowLocation: setTimeout (15s) to redirect to `${path[index]}?next=${nextPath}`
WindowLocation->>User: Browser navigates to new path
File-Level Changes
| Change | Details | Files |
|---|---|---|
| Fix redirect URL calculation for demo routing |
|
frontend/src/app/shared/common.utils.ts |
| Add GitHub Actions workflows for various build and deploy pipelines |
|
.github/workflows/google.yml.github/workflows/octopusdeploy.yml.github/workflows/jekyll-gh-pages.yml.github/workflows/static.yml.github/workflows/jekyll-docker.yml |
| Introduce CircleCI configurations for Rust and sample pipelines |
|
.circleci/cargo.yml.circleci/config.yml.circleci/web3_defi_gamefi.yml |
| Add Security Policy documentation |
|
SECURITY.md |
Possibly linked issues
- Create cargo.yml #24: The PR adds the CircleCI Rust build and test job, covering formatting, testing, and caching, as detailed in the issue. However, it also includes other unrelated changes.
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summaryon the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Originally posted by @sourcery-ai[bot] in #41 (comment)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdocumentationImprovements or additions to documentationImprovements or additions to documentationhelp wantedExtra attention is neededExtra attention is neededinvalidThis doesn't seem rightThis doesn't seem rightquestionFurther information is requestedFurther information is requested
Projects
Status
Backlog
Status
Todo