forked from mempool/mempool
-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Labels
bugSomething isn't workingSomething isn't workingdependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersinvalidThis doesn't seem rightThis doesn't seem rightjavascriptPull requests that update javascript codePull requests that update javascript codequestionFurther information is requestedFurther information is requested
Description
Reviewer's Guide
This PR refactors the asset synchronization script into a promise-driven, modular implementation with environment-based configuration, enhances transaction acceleration flows in the frontend to use a new dedicated endpoint and improved retry/filter logic, introduces a new acceleration lookup endpoint and indexing optimizations in the backend (along with raising express payload limits to 10 MB), and adjusts CI/CD workflows and a minor UI partner update.
Sequence diagram for new transaction acceleration data flow (frontend/backend)
sequenceDiagram
participant F as "Frontend (TransactionComponent)"
participant S as "ServicesApiService"
participant B as "Backend API"
participant R as "AccelerationRepository"
F->>S: getAccelerationDataForTxid$(txid)
S->>B: GET /services/accelerator/accelerations/:txid
B->>R: $getAccelerationInfoForTxid(txid)
R-->>B: Acceleration data or null
B-->>S: Acceleration data or 404
S-->>F: Acceleration data or null
F->>F: Update acceleration info, handle retry/filter logic
Class diagram for new and updated backend acceleration API and repository
classDiagram
class AccelerationRoutes {
+initRoutes(app: Application): void
-$getAcceleratorAcceleration(req: Request, res: Response): Promise<void>
...
}
class AccelerationRepository {
+$getAccelerationInfoForTxid(txid: string): Promise<PublicAcceleration | null>
+$getAccelerationInfo(poolSlug: string | null, height: number | null, interval: string | null): Promise<PublicAcceleration[]>
...
}
AccelerationRoutes --> AccelerationRepository: uses
Class diagram for updated ServicesApiService (frontend)
classDiagram
class ServicesApiService {
+getAccelerationDataForTxid$(txid: string)
+getAllAccelerationHistory$(params, limit?, findTxid?): Observable<Acceleration[]>
...
}
File-Level Changes
| Change | Details | Files |
|---|---|---|
| sync-assets.js rewritten for modular utilities, async/await, and env-based config |
|
frontend/sync-assets.js |
| Transaction/tracker components updated to use new acceleration endpoint and logic |
|
frontend/src/app/components/transaction/transaction.component.tsfrontend/src/app/components/tracker/tracker.component.tsfrontend/src/app/services/services-api.service.ts |
| Backend adds /accelerations/:txid endpoint, indexing rules, and body parser limit |
|
backend/src/repositories/AccelerationRepository.tsbackend/src/api/acceleration/acceleration.routes.tsbackend/src/api/chain-tips.tsbackend/src/repositories/BlocksRepository.tsbackend/src/api/blocks.tsbackend/src/index.ts |
| CI/CD workflows adjusted for tagging logic and toolchain pinning |
|
.github/workflows/on-tag.yml.github/workflows/ci.yml |
| About component partner link updated |
|
frontend/src/app/components/about/about.component.html |
Tips and commands
Interacting with Sourcery
- Trigger a new review: Comment
@sourcery-ai reviewon the pull request. - Continue discussions: Reply directly to Sourcery's review comments.
- Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with@sourcery-ai issueto create an issue from it. - Generate a pull request title: Write
@sourcery-aianywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai titleon the pull request to (re-)generate the title at any time. - Generate a pull request summary: Write
@sourcery-ai summaryanywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment@sourcery-ai summaryon the pull request to
(re-)generate the summary at any time. - Generate reviewer's guide: Comment
@sourcery-ai guideon the pull
request to (re-)generate the reviewer's guide at any time. - Resolve all Sourcery comments: Comment
@sourcery-ai resolveon the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore. - Dismiss all Sourcery reviews: Comment
@sourcery-ai dismisson the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai reviewto trigger a new review!
Customizing Your Experience
Access your dashboard to:
- Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others. - Change the review language.
- Add, remove or edit custom review instructions.
- Adjust other review settings.
Getting Help
- Contact our support team for questions or feedback.
- Visit our documentation for detailed guides and information.
- Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.
Originally posted by @sourcery-ai[bot] in #69 (comment)
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingdependenciesPull requests that update a dependency filePull requests that update a dependency filedocumentationImprovements or additions to documentationImprovements or additions to documentationduplicateThis issue or pull request already existsThis issue or pull request already existsenhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomersinvalidThis doesn't seem rightThis doesn't seem rightjavascriptPull requests that update javascript codePull requests that update javascript codequestionFurther information is requestedFurther information is requested
Projects
Status
Backlog
Status
Todo