Skip to content

Conversation

@clairecng
Copy link
Contributor

What does this PR do?

  • Removes functionality
  • Adds new functionality
  • Alters existing functionality
  • Fixes a bug
  • Improves documentation or testing

Please briefly describe your changes as well as the motivation behind them:

This PR removes the disruption rollout functionality, per lack of usage.

Code Quality Checklist

  • The documentation is up to date.
  • My code is sufficiently commented and passes continuous integration checks.
  • I have signed my commit (see Contributing Docs).

Testing

  • I leveraged continuous integration testing
    • by depending on existing unit tests or end-to-end tests.
    • by adding new unit tests or end-to-end tests.
  • I manually tested the following steps:
    • x
    • locally.
    • as a canary deployment to a cluster.

@clairecng clairecng requested a review from a team as a code owner August 26, 2025 08:03
@clairecng clairecng force-pushed the claire.chong/chaosplt-1071/remove-disruptionrollout branch from 3a0b460 to d7b8c0b Compare August 26, 2025 08:05
@clairecng clairecng force-pushed the claire.chong/chaosplt-1071/remove-disruptionrollout branch from ce19b86 to cafe34b Compare August 26, 2025 08:06
@clairecng clairecng changed the base branch from main to major-release-deprecation August 26, 2025 08:34
Copy link
Contributor

@aymericDD aymericDD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the disruptionRolloutEnabled parameter in the chart/values.yaml file? Otherwise LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants