From 0e0eea02f759d49bc5b4d646944677e9c494bfe2 Mon Sep 17 00:00:00 2001 From: Noemi Frisina Date: Fri, 19 Jul 2024 14:22:39 +0100 Subject: [PATCH] re-enable external links to meta file --- CHANGELOG.md | 6 ++++++ src/nexgen/nxs_utils/detector.py | 6 +++--- src/nexgen/nxs_write/nxclass_writers.py | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 70b73d64..f3eebc50 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,12 @@ # CHANGELOG +## 0.#.# + +### Fixed +- External links to eiger meta file in NXdetector and detectorSpecific groups re-enabled. + + ## 0.9.4 ### Changed diff --git a/src/nexgen/nxs_utils/detector.py b/src/nexgen/nxs_utils/detector.py index f83135a5..70b508cf 100644 --- a/src/nexgen/nxs_utils/detector.py +++ b/src/nexgen/nxs_utils/detector.py @@ -29,9 +29,9 @@ class UnknownDetectorTypeError(Exception): "photon_energy": "_dectris/photon_energy", "software_version": "_dectris/software_version", "ntrigger": "/_dectris/ntrigger", - # "serial_number": "/_dectris/detector_number", - # "eiger_fw_version": "/_dectris/eiger_fw_version", - # "data_collection_date": "/_dectris/data_collection_date", + "serial_number": "/_dectris/detector_number", + "eiger_fw_version": "/_dectris/eiger_fw_version", + "data_collection_date": "/_dectris/data_collection_date", } TRISTAN_CONST = { diff --git a/src/nexgen/nxs_write/nxclass_writers.py b/src/nexgen/nxs_write/nxclass_writers.py index d1905912..4028aeea 100644 --- a/src/nexgen/nxs_write/nxclass_writers.py +++ b/src/nexgen/nxs_write/nxclass_writers.py @@ -749,7 +749,7 @@ def write_NXcollection( data=np.bytes_(detector_params.constants["software_version"]), ) if "EIGER" in detector_params.description.upper() and meta: - for field in ["ntrigger"]: # , "data_collection_date", "eiger_fw_version"]: + for field in ["ntrigger", "data_collection_date", "eiger_fw_version"]: grp[field] = h5py.ExternalLink(meta.name, detector_params.constants[field]) elif "TRISTAN" in detector_params.description.upper(): tick = ureg.Quantity(detector_params.constants["detector_tick"])