-
Notifications
You must be signed in to change notification settings - Fork 5
Censor non-string elements #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Unit tests have been modified, rather than hitting like Reddit JSON and XML feeds, use snapshots of the r/ProgrammerHumor JSON and RSS feeds stored in this repo. #78 will need to be merged first for the unit tests to pass. |
|
@nwithan8 if you're able, do you mind rebasing master here and we can get this merged in? The static test files have been merged already. |
|
@nwithan8 I appreciate the much smaller sample data, thanks! Feel free to rebase and I'll re-review. |
f29001f to
9a8e3a7
Compare
- Fix logic error causing XML inner values to be dropped rather than censored - Add unit test for testing text censoring on HTML data
Description
Closes #76
Testing
Pull Request Type
Please select the option(s) that are relevant to this PR.