Skip to content

Commit 361b985

Browse files
committed
doc: document the direction field in listpeerchannels.
We mentioned it in the schema (so it was allowed), but we didn't document it! Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
1 parent 22f7a62 commit 361b985

File tree

7 files changed

+19
-7
lines changed

7 files changed

+19
-7
lines changed

cln-grpc/proto/node.proto

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cln-grpc/src/convert.rs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

cln-rpc/src/model.rs

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

contrib/msggen/msggen/schema.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24159,6 +24159,12 @@
2415924159
"The short_channel_id (once locked in)."
2416024160
]
2416124161
},
24162+
"direction": {
24163+
"type": "integer",
24164+
"description": [
24165+
"The direction of the channel (i.e. 0 if we are the lesser node id, 1 if we are the greater)."
24166+
]
24167+
},
2416224168
"channel_id": {
2416324169
"type": "hash",
2416424170
"description": [

contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

doc/schemas/listpeerchannels.json

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -311,6 +311,12 @@
311311
"The short_channel_id (once locked in)."
312312
]
313313
},
314+
"direction": {
315+
"type": "integer",
316+
"description": [
317+
"The direction of the channel (i.e. 0 if we are the lesser node id, 1 if we are the greater)."
318+
]
319+
},
314320
"channel_id": {
315321
"type": "hash",
316322
"description": [

tests/test_plugin.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3613,6 +3613,8 @@ def test_sql(node_factory, bitcoind):
36133613
'type': 'string'},
36143614
{'name': 'short_channel_id',
36153615
'type': 'short_channel_id'},
3616+
{'name': 'direction',
3617+
'type': 'u32'},
36163618
{'name': 'channel_id',
36173619
'type': 'hash'},
36183620
{'name': 'funding_txid',
@@ -3715,9 +3717,7 @@ def test_sql(node_factory, bitcoind):
37153717
{'name': 'close_to_addr',
37163718
'type': 'string'},
37173719
{'name': 'last_tx_fee_msat',
3718-
'type': 'msat'},
3719-
{'name': 'direction',
3720-
'type': 'u32'}]},
3720+
'type': 'msat'}]},
37213721
'peerchannels_features': {
37223722
'columns': [{'name': 'row',
37233723
'type': 'u64'},

0 commit comments

Comments
 (0)