FPP 10: Add ability to dismiss low voltage warning as a banner, but still show it in Healthcheck

[patdelaney]

Is your feature request related to a problem? Please describe.
In 9.4 the threshold for the low voltage waring appears to be lower which results in the red banner being displayed. It appears on mostly on Hats that power the Pis. (The buck converters on the hats are only 3 amp) I would like a advanced setting the eliminates the red banner warning, but displays the warning in Health check.

If you are totally against that at least dismiss it until the next reboot.

[darylc]

@patdelaney The concern I have with this, is that it's a genuine problem and super useful to know when trying to troubleshoot someone's pi on zoom. I fear that this change (whilst I understand your motivation for suggesting it) will actually cause more wasted time trying to troubleshoot in the zoom room.

[darylc]

@patdelaney Is your concern about the warnings seen on each individual FPP (which I think should remain) or them bubbling up into the multisync page (which I think we could do something to solve somehow)

[agent462]

If we abstract this to a higher level, it might be nice in an advanced menu to allow a user to pick what warnings they want. This would be a much larger feature though.

[cybercop23]

We had several conversations around this in Slack and Zoom. Right now, my P5 and projector always have this warning. Based on logs, it is when it first starts up (I power off nightly) so now I'm stuck with this banner unnecessarily.

[darylc]

Given this is clearly controversial and that the FPP developers have previously discussed this without reaching a conclusion resulting in any change, this should be discussed further amongst the FPP developers (in the text chat or at the next dev meeting) prior to any implementation.

[bobreese]

Interesting conversation as I have multiple Pi's (with and without hats) that do not have this issue.
@patdelaney @cybercop23 What buck converters are you using?
The converters I use are from HiLetgo on Amazon and are 5amp.
https://a.co/d/fg4EJ3K

[cybercop23]

None. P5 and Kulp K8-PI, on 5v (as it should be) with LRS-5

[patdelaney]

@bobreese its the buck that is on the hat.

[patdelaney]

I thought my suggestions were a good compromise. It would still show up in Health check no matter what. It could also be display in the new UI about page or troubleshooting page.

[cybercop23]

These two generally have the warning, but I just started all my controls up to do some upgrades, and no warnings this time.
One interesting note, although I can't see how it could be, is that this time I asked Google to turn on Christmas lights, which is the same automation that starts them normally.

[agent462]

How about modifying the logic on what triggers the low voltage alert. Right now it's firing the alert on the 6th consecutive low voltage, roughly 6 seconds, it will reset the count on a normal reading. It also starts monitoring right when FPPD starts which might be detriment to when the samples are taking (I only have two k8-pi's in my show and I've never seen the alert so not sure I can test). A good compromise could be changing the logic with something like the below.

• Add a startup delay for monitoring voltage from when FPPD starts
• Increase from 5 samples to 30 (or some other value)
• Clear the alert when voltage is stable for 60 seconds (or some other timeframe)

// In httpAPI.h setup the ability to delay checking
std::time_t piPowerStartTime = 0;

// In httpAPI.cpp
// Change threshold from 5 to 30
if (piPowerWarningCount > 30 && !piPowerWarningAdded) {

// Code here

// If voltage recovers, clear the alert
} else {
    piPowerWarningCount = 0;
    // Reset warning if power has been stable for 60 seconds
    if (piPowerWarningAdded && piPowerGoodCount++ > 60) {
        WarningHolder::RemoveWarning(POWER_WARNING_ID, "Raspberry Pi Voltage Too Low");
        piPowerWarningAdded = false;
        piPowerGoodCount = 0;
    }
}

// Code here

// Delay the monitoring after FPPD startup
void PlayerResource::periodicWork() {
    if (piPowerFile > 0) {
#ifdef PLATFORM_PI
        if (piPowerStartTime == 0) {
            piPowerStartTime = std::time(nullptr);
        }
        if (std::time(nullptr) - piPowerStartTime < 30) {
            return;
        }
        // ... rest of monitoring code

[dkulp]

Removing the warning pretty much defeats the entire purpose of putting it up there. When the voltage dips, all kinds of strange things happen. Soundblasters stop outputting, wifi disconnects, strange issues with other peripherals, etc... Some may not be noticed immediately, but being able to go to the main page and see that there was a voltage warning is a very good indicator. If the warning is gone, you'd have no clue without digging through logs. Jason and I had a good conversation about that which is why it's implemented in a way that it persists.

[bcarriveau]

If the banner is hidden or removed, I encourage a non-removable small check engine style light in the header while low voltage is detected. 🥳