Manual search sometimes displays profiles which do not belong to the IdP in question

[restena-sw]

I am trying for a while to reproduce an issue where people use the "Manual Search" and then get profiles from another institution in the result set (but the logo is the correct one).

I was finally able to reproduce this today. IMHO it deserves an expedited fixing, since users might be installing the wrong profiles if they don't pay close attention.

The issue occurs if a previous search (like the automatic one on startup) yields as closest organisation one which has more than one user profile (like "Staff", "Students", "Alumni").

Using manual search after that will find the institution searched for, update the logo in the list, but will NOT update the list of profiles - it remains visible in UI unchanged.

A workaround is consequently to then do /another/ manual search for the same organisation, which works because then the previously selected organisation is the same.

To reproduce this:

• go to Manual Search for "coperni" and find "Nicolaus Copernicus University" (Poland) on top of the list. They have five user profiles.
• Turn off Manual Search, then on again, and find with "basel" the "University of Basel"
  -> UI displays the five profiles of the Polish university alongside the logo of Basel.

[GarethAyres]

Hi. Thanks for finding a way to reproduce this.
Now i have reproduced it on my virtual device i have identified a fix:
f869115

Ill push the fix to Play Store as beta next for testing.

Gareth

[GarethAyres]

OK beta is live on play. testers can update manually or wait for the auto update.
once i get confirmation of the fix ill release to the 800k installs on productions :-O

Gareth

[restena-sw]

I can confirm the fix in the current beta (on Android 9). From my POV, please go ahead and make the new release GA.
Please also tag the code so that F-Droid picks it up.
Finally, please upload the signed binary to the repo and I will update the Amazon App Store with the new version as well.

[GarethAyres]

OK great, thanks. Ive pushed to production and tagged a release on here with the latest signed binary.

[restena-sw]

1.2.14 is now live on the Amazon App Store.

Thanks!

[restena-sw]

I'm afraid I have to reopen this. A user just alerted me that this keeps happening also in version 1.2.14.

The test vector is:

• search manually for "Coperni" again -> Nicolaus Copernicus University, Poland, with multiple profiles
• search manually for "Heyro" afterwards -> Logo of "Heyrovsky institute of Physical Chemistry" (Czech Republic) is shown (some wave forms) but the profile list remains that of Nicolaus Copernicus University.

I've tried this on Android 9, the reporter has Android 8.

[GarethAyres]

Ah, thats disappointing.

ill start debugging it again...