Skip to content

Conversation

@ebeltran-g
Copy link

@ebeltran-g ebeltran-g commented Dec 1, 2025

Description

Adding a new Snippet code to use it as reference in the public doc. This will replace existing example which is only in the documentation
https://docs.cloud.google.com/dataflow/docs/guides/logging#df-integration

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@ebeltran-g ebeltran-g requested review from a team and yoshi-approver as code owners December 1, 2025 17:09
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: dataflow Issues related to the Dataflow API. labels Dec 1, 2025
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ebeltran-g, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new Dataflow sample that demonstrates the use of Mapped Diagnostic Context (MDC) for enhanced logging within a Dataflow pipeline. The sample reads messages from a Pub/Sub subscription and uses MDC to include the message ID in log statements, providing a clearer context for each log entry. This new snippet will be used to update the public documentation, offering a practical and up-to-date reference for Dataflow users.

Highlights

  • New Dataflow MDC Sample: A new Dataflow snippet, MdcSample.java, has been added to demonstrate the use of Mapped Diagnostic Context (MDC) for logging within a Dataflow pipeline.
  • Documentation Reference: This new sample is intended to replace an existing example in the public Dataflow documentation, providing an updated and runnable reference for users.
  • MDC Integration: The sample illustrates how to read messages from a Pub/Sub subscription and use MDC.putCloseable to associate the Pub/Sub message ID with log statements, enhancing log context.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new Dataflow snippet demonstrating how to use Mapped Diagnostic Context (MDC) for enhanced logging. The example is clear and serves its purpose well. I've provided a few suggestions to improve the code's robustness, error handling, and adherence to best practices, particularly concerning character encoding, logging efficiency, exception management, and pipeline execution.

ebeltran-g and others added 3 commits December 1, 2025 11:12
….java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
….java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
….java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dataflow Issues related to the Dataflow API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant