-
Notifications
You must be signed in to change notification settings - Fork 0
Add external_user_id to semantic search docs and update its desc in a… #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughTwo API endpoint documentation files are updated to clarify external_user_id parameter requirements. The ask-question endpoint's existing parameter description is refined to explicitly require UUID format, and the semantic-search endpoint receives a new external_user_id parameter with the same UUID requirement for per-user analytics. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Possibly related PRs
Pre-merge checks❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
api-reference/endpoints/semantic-search.mdx (1)
31-33: Align UUID requirement phrasing with ask-question endpoint.The description uses "It should be UUID" which is informal and grammatically incomplete. For consistency with the ask-question endpoint and professional API documentation standards, use more prescriptive phrasing with proper grammar.
<ParamField body="external_user_id" type="string"> - External user identifier. This allows you to track search queries per user in your analytics. It should be UUID. + External user identifier. This allows you to track search queries per user in your analytics. It must be a UUID. </ParamField>This aligns with the ask-question endpoint (with the grammar correction noted separately).
api-reference/endpoints/ask-question.mdx (1)
39-41: Correct grammar and align UUID requirement phrasing across endpoints.Line 40 has a grammatical error: "It needs to be UUID" should include the article "a." Additionally, align the phrasing with the semantic-search endpoint for consistency across the API documentation.
<ParamField body="external_user_id" type="string"> - External user identifier for tracking user-specific conversation sessions. When provided, this ID is stored in the session. If a session already exists with a different external_user_id, the request will be rejected. It needs to be UUID. + External user identifier for tracking user-specific conversation sessions. When provided, this ID is stored in the session. If a session already exists with a different external_user_id, the request will be rejected. It must be a UUID. </ParamField>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
api-reference/endpoints/ask-question.mdx(1 hunks)api-reference/endpoints/semantic-search.mdx(1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.mdx
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.mdx: Use MDX format for all documentation files
Use Mintlify components like , , for rich content
Include practical examples and code snippets in documentation
Use images from /images/ directory for visual guides
Files:
api-reference/endpoints/ask-question.mdxapi-reference/endpoints/semantic-search.mdx
api-reference/endpoints/**/*.mdx
📄 CodeRabbit inference engine (CLAUDE.md)
API endpoint docs follow the structure in /api-reference/endpoints/
Files:
api-reference/endpoints/ask-question.mdxapi-reference/endpoints/semantic-search.mdx
…sk question
Summary by CodeRabbit
Documentation
external_user_idparameter must be in UUID format for the Ask Question endpoint.New Features
external_user_idparameter to the Semantic Search endpoint for per-user analytics tracking.✏️ Tip: You can customize this high-level summary in your review settings.