From 2c4b88a6241f34ba9c0f825d08a77507dce94565 Mon Sep 17 00:00:00 2001 From: BrennaManning Date: Thu, 23 Mar 2017 23:05:16 -0400 Subject: [PATCH 1/5] catapp1 feedback --- lessons/03-express-templates/catApp/app.js | 2 ++ .../03-express-templates/catApp/feedback.txt | 34 +++++++++++++++++++ .../catApp/routes/index.js | 4 ++- 3 files changed, 39 insertions(+), 1 deletion(-) create mode 100644 lessons/03-express-templates/catApp/feedback.txt diff --git a/lessons/03-express-templates/catApp/app.js b/lessons/03-express-templates/catApp/app.js index e7c14d33..10c2b992 100644 --- a/lessons/03-express-templates/catApp/app.js +++ b/lessons/03-express-templates/catApp/app.js @@ -25,3 +25,5 @@ app.get('/cats/bycolor/:color',index.bycolor); app.get('/cats/delete/old', index.deleteOldCat); app.listen(3000); + +// It would be nice to have a few comments here, maybe for each section. \ No newline at end of file diff --git a/lessons/03-express-templates/catApp/feedback.txt b/lessons/03-express-templates/catApp/feedback.txt new file mode 100644 index 00000000..52151958 --- /dev/null +++ b/lessons/03-express-templates/catApp/feedback.txt @@ -0,0 +1,34 @@ + +Homework Feedback for Cat App + +The link you sent in the homework survey did not exist anymore, so I went back in your commit history to find your original cat app. In the commit I am looking at there are a lot of old/extra files you would want to remove, but I'm assuming you did this later after this commit. (Your "move cat app" commit appears to just remove the cat app instead of moving it.) + + +Functionality: + +All tasks completed!* Awesome job, and your app appears to be bug free. :D +Second submission + + +Completion: (20/20) + +Bug Free: (10/10) + + + +Quality: + +Your code was well organized and commented! It was very clear and readable. +Citing references when you took code from online was great. You should add comments +describing your functions for the functions you did not do this for. + + + +Good Coding Practices: (10/10) + +Readability: (9/10) + + +Summary: Nice work! Everything is functional and you followed good practices. + +(49/50). \ No newline at end of file diff --git a/lessons/03-express-templates/catApp/routes/index.js b/lessons/03-express-templates/catApp/routes/index.js index 26b7ecaf..de144f6d 100644 --- a/lessons/03-express-templates/catApp/routes/index.js +++ b/lessons/03-express-templates/catApp/routes/index.js @@ -15,7 +15,7 @@ function Cat(){ var cat = { name: names[Math.floor(Math.random()*names.length)], color: [colors[Math.floor(Math.random()*colors.length)],colors[Math.floor(Math.random()*colors.length)]], - age: Math.floor(Math.random() * 1001) + age: Math.floor(Math.random() * 1001) // These are old cats. }; return cat; } @@ -36,6 +36,7 @@ var newCat = function(req, res) { var cats = function(req, res) { allCats = db.getAll(); // adapted from http://stackoverflow.com/questions/1069666/sorting-javascript-object-by-property-value + // Awesome citing your references!!!!! allCats.sort(function(a, b) { return a.age - b.age; }); @@ -51,6 +52,7 @@ var bycolor = function(req,res) { rightCats.push(cat); } }); + console.log(rightCats) res.render("cats", {"cat": rightCats}); }; From 0673b8c3bda9d6ad08ff3de987540f60eb909651 Mon Sep 17 00:00:00 2001 From: BrennaManning Date: Tue, 28 Mar 2017 16:13:25 -0400 Subject: [PATCH 2/5] cat app feedback --- lessons/03-express-templates/catApp/feedback.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lessons/03-express-templates/catApp/feedback.txt b/lessons/03-express-templates/catApp/feedback.txt index 52151958..640942a3 100644 --- a/lessons/03-express-templates/catApp/feedback.txt +++ b/lessons/03-express-templates/catApp/feedback.txt @@ -31,4 +31,5 @@ Readability: (9/10) Summary: Nice work! Everything is functional and you followed good practices. -(49/50). \ No newline at end of file +(49/50 + From b186059b8034329b497c8c3a39d20b789497577c Mon Sep 17 00:00:00 2001 From: BrennaManning Date: Tue, 28 Mar 2017 16:18:09 -0400 Subject: [PATCH 3/5] Update feedback.txt --- lessons/03-express-templates/catApp/feedback.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lessons/03-express-templates/catApp/feedback.txt b/lessons/03-express-templates/catApp/feedback.txt index 640942a3..5f304429 100644 --- a/lessons/03-express-templates/catApp/feedback.txt +++ b/lessons/03-express-templates/catApp/feedback.txt @@ -31,5 +31,5 @@ Readability: (9/10) Summary: Nice work! Everything is functional and you followed good practices. -(49/50 +(49/50) From d5b64c532c4350f8312a4a423380e96bebce227e Mon Sep 17 00:00:00 2001 From: BrennaManning Date: Tue, 28 Mar 2017 16:25:40 -0400 Subject: [PATCH 4/5] Update feedback.txt --- lessons/03-express-templates/catApp/feedback.txt | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lessons/03-express-templates/catApp/feedback.txt b/lessons/03-express-templates/catApp/feedback.txt index 5f304429..4f48d164 100644 --- a/lessons/03-express-templates/catApp/feedback.txt +++ b/lessons/03-express-templates/catApp/feedback.txt @@ -1,13 +1,14 @@ +Do not merge this branch! -Homework Feedback for Cat App +**Homework Feedback for Cat App** -The link you sent in the homework survey did not exist anymore, so I went back in your commit history to find your original cat app. In the commit I am looking at there are a lot of old/extra files you would want to remove, but I'm assuming you did this later after this commit. (Your "move cat app" commit appears to just remove the cat app instead of moving it.) +The link you sent in the homework survey did not exist anymore, so I went back in your commit history to find your original cat app. In the commit I am looking at there are a lot of old/extra files you would want to remove, but I'm assuming you did this later after this commit. (Your "move cat app" commit appeared to removed the cat app instead of moving it.) Functionality: All tasks completed!* Awesome job, and your app appears to be bug free. :D -Second submission +*Second submission Completion: (20/20) @@ -19,8 +20,7 @@ Bug Free: (10/10) Quality: Your code was well organized and commented! It was very clear and readable. -Citing references when you took code from online was great. You should add comments -describing your functions for the functions you did not do this for. +Citing references when you took code from online was great. A good next step would be adding comments describing your functions for the functions you did not do this for. @@ -32,4 +32,3 @@ Readability: (9/10) Summary: Nice work! Everything is functional and you followed good practices. (49/50) - From c738e72f42086b07b113b6c41ba6a911f129bc47 Mon Sep 17 00:00:00 2001 From: BrennaManning Date: Tue, 28 Mar 2017 16:29:03 -0400 Subject: [PATCH 5/5] Update index.js --- lessons/03-express-templates/catApp/routes/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/lessons/03-express-templates/catApp/routes/index.js b/lessons/03-express-templates/catApp/routes/index.js index de144f6d..79946884 100644 --- a/lessons/03-express-templates/catApp/routes/index.js +++ b/lessons/03-express-templates/catApp/routes/index.js @@ -52,7 +52,6 @@ var bycolor = function(req,res) { rightCats.push(cat); } }); - console.log(rightCats) res.render("cats", {"cat": rightCats}); };