Modify condition in MultiDimClosure function #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, I am trying to load a
Array{Vector{Int64}, 4}using JSON.jl, which relies on StructUtils.jl. The inner vector is jagged, i.e. not the same length for every element, soArray{Int64, 5}is not an option. Now, without this stop condition, the multidimensional array continues untilf.cur_dim[] == 0and fails to set the dimension, unsurprisingly. With this condition it works flawlessly.Full disclaimer, I don't know if this will have a major impact elsewhere, so please review this PR carefully. But it would be nice if loading vectors in multi-dim arrays worked.