From 37c2ece940e024afdcdcbcf6e50677c0878ebe12 Mon Sep 17 00:00:00 2001
From: William Allen <16820599+williamjallen@users.noreply.github.com>
Date: Tue, 30 Dec 2025 15:03:00 -0500
Subject: [PATCH] Delete obsolete project(showipaddresses) column

---
 app/Models/Project.php                        |  2 -
 app/cdash/app/Model/Project.php               |  3 --
 .../tests/test_actualtrilinossubmission.php   |  1 -
 ..._30_195827_drop_showipaddresses_column.php | 14 +++++++
 phpstan-baseline.neon                         |  6 ---
 resources/js/vue/components/EditProject.vue   | 38 -------------------
 tests/Spec/edit-project.spec.js               |  1 -
 7 files changed, 14 insertions(+), 51 deletions(-)
 create mode 100644 database/migrations/2025_12_30_195827_drop_showipaddresses_column.php

diff --git a/app/Models/Project.php b/app/Models/Project.php
index 4c0591929a..8325da9b16 100644
--- a/app/Models/Project.php
+++ b/app/Models/Project.php
@@ -29,7 +29,6 @@
  * @property int $emailtesttimingchanged
  * @property int $emailbrokensubmission
  * @property int $emailredundantfailures
- * @property int $showipaddresses
  * @property string $cvsviewertype
  * @property int $testtimestd
  * @property int $testtimestdthreshold
@@ -77,7 +76,6 @@ class Project extends Model
         'emailtesttimingchanged',
         'emailbrokensubmission',
         'emailredundantfailures',
-        'showipaddresses',
         'cvsviewertype',
         'testtimestd',
         'testtimestdthreshold',
diff --git a/app/cdash/app/Model/Project.php b/app/cdash/app/Model/Project.php
index a2819bdc3c..c49d45c153 100644
--- a/app/cdash/app/Model/Project.php
+++ b/app/cdash/app/Model/Project.php
@@ -68,7 +68,6 @@ class Project
     public $TestTimeMaxStatus;
     public $EmailMaxItems = 5;
     public $EmailMaxChars = 255;
-    public $ShowIPAddresses = 0;
     public $DisplayLabels = 0;
     public $ShareLabelFilters = 0;
     public $ViewSubProjectsLink = 0;
@@ -130,7 +129,6 @@ public function Save(): bool
             'emailtesttimingchanged' => (int) $this->EmailTestTimingChanged,
             'emailbrokensubmission' => (int) $this->EmailBrokenSubmission,
             'emailredundantfailures' => (int) $this->EmailRedundantFailures,
-            'showipaddresses' => (int) $this->ShowIPAddresses,
             'displaylabels' => (int) $this->DisplayLabels,
             'sharelabelfilters' => (int) $this->ShareLabelFilters,
             'viewsubprojectslink' => (int) $this->ViewSubProjectsLink,
@@ -219,7 +217,6 @@ public function Fill(): void
             $this->EmailTestTimingChanged = $project->emailtesttimingchanged;
             $this->EmailBrokenSubmission = $project->emailbrokensubmission;
             $this->EmailRedundantFailures = $project->emailredundantfailures;
-            $this->ShowIPAddresses = $project->showipaddresses;
             $this->DisplayLabels = $project->displaylabels;
             $this->ShareLabelFilters = $project->sharelabelfilters;
             $this->ViewSubProjectsLink = $project->viewsubprojectslink;
diff --git a/app/cdash/tests/test_actualtrilinossubmission.php b/app/cdash/tests/test_actualtrilinossubmission.php
index ef06c5f814..4bfd75da1d 100644
--- a/app/cdash/tests/test_actualtrilinossubmission.php
+++ b/app/cdash/tests/test_actualtrilinossubmission.php
@@ -22,7 +22,6 @@ public function createProjectWithName($project)
             'Name' => $project,
             'Description' => $project . ' project created by test code in file [' . __FILE__ . ']',
             'EmailBrokenSubmission' => '1',
-            'ShowIPAddresses' => '1',
             'DisplayLabels' => '1',
             'NightlyTime' => '21:00:00 America/New_York',
             'ShareLabelFilters' => '1'];
diff --git a/database/migrations/2025_12_30_195827_drop_showipaddresses_column.php b/database/migrations/2025_12_30_195827_drop_showipaddresses_column.php
new file mode 100644
index 0000000000..4e5d111d95
--- /dev/null
+++ b/database/migrations/2025_12_30_195827_drop_showipaddresses_column.php
@@ -0,0 +1,14 @@
+<?php
+
+use Illuminate\Database\Migrations\Migration;
+
+return new class extends Migration {
+    public function up(): void
+    {
+        DB::statement('ALTER TABLE project DROP COLUMN showipaddresses');
+    }
+
+    public function down(): void
+    {
+    }
+};
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
index edf8f94d0e..ff5991e49f 100644
--- a/phpstan-baseline.neon
+++ b/phpstan-baseline.neon
@@ -11607,12 +11607,6 @@ parameters:
 			count: 1
 			path: app/cdash/app/Model/Project.php
 
-		-
-			rawMessage: Property CDash\Model\Project::$ShowIPAddresses has no type specified.
-			identifier: missingType.property
-			count: 1
-			path: app/cdash/app/Model/Project.php
-
 		-
 			rawMessage: Property CDash\Model\Project::$ShowTestTime has no type specified.
 			identifier: missingType.property
diff --git a/resources/js/vue/components/EditProject.vue b/resources/js/vue/components/EditProject.vue
index 625c99ccd2..039ad77a79 100644
--- a/resources/js/vue/components/EditProject.vue
+++ b/resources/js/vue/components/EditProject.vue
@@ -1646,44 +1646,6 @@
                       </span>
                     </td>
                   </tr>
-                  <tr>
-                    <td />
-                    <td>
-                      <div align="right">
-                        <strong>Show site IP addresses:</strong>
-                      </div>
-                    </td>
-                    <td>
-                      <input
-                        v-model="cdash.project.ShowIPAddresses"
-                        type="checkbox"
-                        name="showIPAddresses"
-                        true-value="1"
-                        false-value="0"
-                        @change="cdash.changesmade = true"
-                        @focus="showHelp('showSiteIPAddresses_help')"
-                      >
-                      <a
-                        href="http://www.cdash.org/Wiki/CDash:Administration#Creating_a_project"
-                        target="blank"
-                      >
-                        <img
-                          :src="$baseURL + '/img/help.gif'"
-                          border="0"
-                          @mouseover="showHelp('showSiteIPAddresses_help')"
-                        >
-                      </a>
-                      <span
-                        id="showSiteIPAddresses_help"
-                        class="help_content"
-                      >
-                        <b>Show Site IP Addresses</b>
-                        <br>
-                        Enable/Disable the display of IP addresses of the sites
-                        submitting to this project.
-                      </span>
-                    </td>
-                  </tr>
                   <tr>
                     <td />
                     <td>
diff --git a/tests/Spec/edit-project.spec.js b/tests/Spec/edit-project.spec.js
index 36d90e74d9..f5be948bc2 100644
--- a/tests/Spec/edit-project.spec.js
+++ b/tests/Spec/edit-project.spec.js
@@ -69,7 +69,6 @@ beforeEach(() => {
       Public: 1,
       ShareLabelFilters: 0,
       ShowCoverageCode: 1,
-      ShowIPAddresses: 0,
       ShowTestTime: 0,
       TestTimeMaxStatus: 3,
       TestTimeStd: 4,