From 623823bb6797b4d977680db05f5a1e82d76de5ef Mon Sep 17 00:00:00 2001 From: Vincent Vanlaer Date: Tue, 23 Dec 2025 01:29:56 +0100 Subject: [PATCH 1/3] pgplot: remove decorator null functions They are not used --- binary/Makefile | 1 - binary/defaults/pgbinary.defaults | 38 ++++----- binary/other/pgbinary_decorator.f90 | 47 ----------- star/Makefile | 2 - .../dev_TDC_Cepheid_6M/inlist_pgstar | 2 +- star/other/pgstar_decorator.f90 | 83 ------------------- star/private/init.f90 | 1 - .../12M_pre_ms_to_core_collapse/inlist_pgstar | 2 +- .../20M_pre_ms_to_core_collapse/inlist_pgstar | 2 +- .../20M_z2m2_high_rotation/inlist_pgstar | 6 +- star/test_suite/c13_pocket/inlist_pgstar | 2 +- star/test_suite/make_o_ne_wd/inlist_pgstar | 2 +- .../make_pre_ccsn_13bvn/inlist_pgstar | 4 +- star/test_suite/ns_c/inlist_pgstar | 2 +- star/test_suite/pisn/inlist_pgstar | 2 +- .../split_burn_big_net/inlist_pgstar | 2 +- star/test_suite/twin_studies/inlist_pgstar | 2 +- star/test_suite/zams_to_cc_80/inlist_pgstar | 2 +- star_data/public/star_pgstar.f90 | 34 ++++++++ 19 files changed, 68 insertions(+), 168 deletions(-) delete mode 100644 binary/other/pgbinary_decorator.f90 delete mode 100644 star/other/pgstar_decorator.f90 diff --git a/binary/Makefile b/binary/Makefile index e5988d378..c280eec81 100644 --- a/binary/Makefile +++ b/binary/Makefile @@ -43,7 +43,6 @@ SRCS := \ other/mod_other_e2.f90 \ other/mod_other_pgbinary_plots.f90 \ other/mod_other_tidal_deformation_switch_function.f90 \ - other/pgbinary_decorator.f90 ifeq ($(WITH_PGSTAR),yes) SRCS += \ diff --git a/binary/defaults/pgbinary.defaults b/binary/defaults/pgbinary.defaults index 94ccecd24..825bb8328 100644 --- a/binary/defaults/pgbinary.defaults +++ b/binary/defaults/pgbinary.defaults @@ -335,7 +335,7 @@ ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -426,7 +426,7 @@ History_Track1_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -512,7 +512,7 @@ History_Track2_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -598,7 +598,7 @@ History_Track3_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -684,7 +684,7 @@ History_Track4_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -770,7 +770,7 @@ History_Track5_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -856,7 +856,7 @@ History_Track6_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -942,7 +942,7 @@ History_Track7_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1028,7 +1028,7 @@ History_Track8_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1114,7 +1114,7 @@ History_Track9_fname = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1206,7 +1206,7 @@ History_Panels1_dymin(1) = -1 ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1285,7 +1285,7 @@ History_Panels2_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1364,7 +1364,7 @@ History_Panels3_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1443,7 +1443,7 @@ History_Panels4_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1530,7 +1530,7 @@ History_Panels5_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1608,7 +1608,7 @@ History_Panels6_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1687,7 +1687,7 @@ History_Panels7_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1766,7 +1766,7 @@ History_Panels8_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: @@ -1845,7 +1845,7 @@ History_Panels9_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/binary/other/pgbinary_decorator.f90`` + ! see ``$MESA_DIR/binary/public/binary_pgbinary.f90`` ! :: diff --git a/binary/other/pgbinary_decorator.f90 b/binary/other/pgbinary_decorator.f90 deleted file mode 100644 index f0d92484a..000000000 --- a/binary/other/pgbinary_decorator.f90 +++ /dev/null @@ -1,47 +0,0 @@ -! *********************************************************************** -! -! Copyright (C) 2010 Bill Paxton & The MESA Team -! -! This program is free software: you can redistribute it and/or modify -! it under the terms of the GNU Lesser General Public License -! as published by the Free Software Foundation, -! either version 3 of the License, or (at your option) any later version. -! -! This program is distributed in the hope that it will be useful, -! but WITHOUT ANY WARRANTY; without even the implied warranty of -! MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. -! See the GNU Lesser General Public License for more details. -! -! You should have received a copy of the GNU Lesser General Public License -! along with this program. If not, see . -! -! *********************************************************************** - -module pgbinary_decorator - - ! NOTE: remember to set X_use_decorator = .true. to enable this, - ! where X is the name of the pgbinary plot - ! and set s% X_pgbinary_decorator => your_function in your - ! run_binary_extras.f - - ! List of pgplot routines: http://www.astro.caltech.edu/~tjp/pgplot/annlist.html - - implicit none - -contains - - ! default does nothing - ! xmin, xmax, ymin, ymax: current plot boundary - ! plot_num: If a plot has multiple sub-panels, then this tells you which panel is being called - subroutine null_pgbinary_decorator(id, xmin, xmax, ymin, ymax, plot_num, ierr) - use binary_def - use const_def, only: dp - integer, intent(in) :: id - !Not doubles - real, intent(in) :: xmin, xmax, ymin, ymax - integer, intent(in) :: plot_num - integer, intent(out) :: ierr - ierr = 0 - end subroutine null_pgbinary_decorator - -end module pgbinary_decorator diff --git a/star/Makefile b/star/Makefile index c4d7209f6..ee22a471a 100644 --- a/star/Makefile +++ b/star/Makefile @@ -167,7 +167,6 @@ SRCS := \ ifeq ($(WITH_PGSTAR),yes) SRCS += \ - other/pgstar_decorator.f90 \ private/pgstar_ctrls_io.f90 \ private/pgstar_colors.f90 \ private/pgstar_support.f90 \ @@ -236,7 +235,6 @@ MODULES += pgstar_abundance.mod \ pgstar_color_magnitude.mod \ pgstar_colors.mod \ pgstar_ctrls_io.mod \ - pgstar_decorator.mod \ pgstar_dpg_dnu.mod \ pgstar_dynamo.mod \ pgstar_grid.mod \ diff --git a/star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_6M/inlist_pgstar b/star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_6M/inlist_pgstar index 4a101208a..ed4fcb203 100644 --- a/star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_6M/inlist_pgstar +++ b/star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_6M/inlist_pgstar @@ -563,7 +563,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star/other/pgstar_decorator.f90 b/star/other/pgstar_decorator.f90 deleted file mode 100644 index 6289b78ec..000000000 --- a/star/other/pgstar_decorator.f90 +++ /dev/null @@ -1,83 +0,0 @@ -! *********************************************************************** -! -! Copyright (C) 2010 The MESA Team -! -! This program is free software: you can redistribute it and/or modify -! it under the terms of the GNU Lesser General Public License -! as published by the Free Software Foundation, -! either version 3 of the License, or (at your option) any later version. -! -! This program is distributed in the hope that it will be useful, -! but WITHOUT ANY WARRANTY; without even the implied warranty of -! MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. -! See the GNU Lesser General Public License for more details. -! -! You should have received a copy of the GNU Lesser General Public License -! along with this program. If not, see . -! -! *********************************************************************** - -module pgstar_decorator - - ! NOTE: remember to set X_use_decorator = .true. to enable this, - ! where X is the name of the pgstar plot - ! and set s% pg% X_pgstar_decorator => your_function in your - ! run_star_extras.f - - ! List of pgplot routines: http://www.astro.caltech.edu/~tjp/pgplot/annlist.html - - implicit none - -contains - - ! default does nothing - ! xmin, xmax, ymin, ymax: current plot boundary - ! plot_num: If a plot has multiple sub-panels, then this tells you which panel is being called - subroutine null_pgstar_decorator(id, xmin, xmax, ymin, ymax, plot_num, ierr) - use star_def - use const_def, only: dp - integer, intent(in) :: id - !Not doubles - real, intent(in) :: xmin, xmax, ymin, ymax - integer, intent(in) :: plot_num - integer, intent(out) :: ierr - ierr = 0 - end subroutine null_pgstar_decorator - -! Example function to add squares and some text to the abundance plot -! subroutine Abundance_pgstar_decorator(id, xmin, xmax, ymin, ymax, plot_num, ierr) -! use star_def -! use const_def, only: dp -! use pgstar_colors -! integer, intent(in) :: id -! !Not dp -! real,intent(in) :: xmin, xmax, ymin, ymax -! real :: xcenter,ycenter,dx,dy,a -! integer, intent(out) :: ierr -! integer :: i -! type (star_info), pointer :: s - -! ierr = 0 -! call star_ptr(id, s, ierr) -! if (ierr /= 0) return - -! dx=(xmax-xmin) -! dy=(ymax-ymin) - -! xcenter=xmin+dx*0.5 -! ycenter=ymin+dy*0.5 - -! call pgsci(clr_Coral) - -! do i=1,4 -! a=(i/10.0) -! call pgline(5, (/xcenter-a*dx,xcenter-a*dx,xcenter+a*dx,xcenter+a*dx,xcenter-a*dx/),& -! (/ycenter-a*dy,ycenter+a*dy,ycenter+a*dy,ycenter-a*dy,ycenter-a*dy/)) -! end do - -! call pgptxt(xcenter,ycenter, 0.0, 1.0, 'Some added text on this plot') - -! end subroutine Abundance_pgstar_decorator - -end module pgstar_decorator - diff --git a/star/private/init.f90 b/star/private/init.f90 index 98bcc1ec0..9aefdf4b0 100644 --- a/star/private/init.f90 +++ b/star/private/init.f90 @@ -472,7 +472,6 @@ subroutine set_starting_star_data(s, ierr) use other_photo_read, only: default_other_photo_read use other_set_pgstar_controls, only: default_other_set_pgstar_controls use other_kap - use pgstar_decorator use star_utils, only: init_random type (star_info), pointer :: s diff --git a/star/test_suite/12M_pre_ms_to_core_collapse/inlist_pgstar b/star/test_suite/12M_pre_ms_to_core_collapse/inlist_pgstar index e64c47c42..09063dbe9 100644 --- a/star/test_suite/12M_pre_ms_to_core_collapse/inlist_pgstar +++ b/star/test_suite/12M_pre_ms_to_core_collapse/inlist_pgstar @@ -539,7 +539,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star/test_suite/20M_pre_ms_to_core_collapse/inlist_pgstar b/star/test_suite/20M_pre_ms_to_core_collapse/inlist_pgstar index fc95803e7..791dc494d 100644 --- a/star/test_suite/20M_pre_ms_to_core_collapse/inlist_pgstar +++ b/star/test_suite/20M_pre_ms_to_core_collapse/inlist_pgstar @@ -539,7 +539,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star/test_suite/20M_z2m2_high_rotation/inlist_pgstar b/star/test_suite/20M_z2m2_high_rotation/inlist_pgstar index e0ba4bcac..eda473091 100644 --- a/star/test_suite/20M_z2m2_high_rotation/inlist_pgstar +++ b/star/test_suite/20M_z2m2_high_rotation/inlist_pgstar @@ -483,7 +483,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. @@ -535,7 +535,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window TRho_fname = '' ! file name for extra TRho data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` TRho_use_decorator = .false. @@ -637,7 +637,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window show_Kipp_annotation3 = .false. ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` Kipp_use_decorator = .false. ! file output diff --git a/star/test_suite/c13_pocket/inlist_pgstar b/star/test_suite/c13_pocket/inlist_pgstar index 94fb5d7f1..66c9ea9dc 100644 --- a/star/test_suite/c13_pocket/inlist_pgstar +++ b/star/test_suite/c13_pocket/inlist_pgstar @@ -210,7 +210,7 @@ ! History_Panels2_points_name(:) = '' ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` History_Panels2_use_decorator = .false. History_Panels2_yaxis_name(1) = 'log_LH' diff --git a/star/test_suite/make_o_ne_wd/inlist_pgstar b/star/test_suite/make_o_ne_wd/inlist_pgstar index c4c4b2fe6..7b00dd797 100644 --- a/star/test_suite/make_o_ne_wd/inlist_pgstar +++ b/star/test_suite/make_o_ne_wd/inlist_pgstar @@ -544,7 +544,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star/test_suite/make_pre_ccsn_13bvn/inlist_pgstar b/star/test_suite/make_pre_ccsn_13bvn/inlist_pgstar index 84b83cdcc..7f01ad586 100644 --- a/star/test_suite/make_pre_ccsn_13bvn/inlist_pgstar +++ b/star/test_suite/make_pre_ccsn_13bvn/inlist_pgstar @@ -360,7 +360,7 @@ show_HR_annotation3 = .false. HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot -! see `$MESA_DIR/star/other/pgstar_decorator.f90` +! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. @@ -884,7 +884,7 @@ Grid1_file_aspect_ratio = -1 ! negative means use same value as for window History_Panels1_other_dymin(3) = -1 ! Enables calling a subroutine to add extra information to a plot - ! see ``$MESA_DIR/star/other/pgstar_decorator.f90`` + ! see ``$MESA_DIR/star_data/public/star_pgstar.f90`` ! :: diff --git a/star/test_suite/ns_c/inlist_pgstar b/star/test_suite/ns_c/inlist_pgstar index 67a5031bb..9a103c8ab 100644 --- a/star/test_suite/ns_c/inlist_pgstar +++ b/star/test_suite/ns_c/inlist_pgstar @@ -537,7 +537,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star/test_suite/pisn/inlist_pgstar b/star/test_suite/pisn/inlist_pgstar index b430aa0c3..9d5ac4892 100644 --- a/star/test_suite/pisn/inlist_pgstar +++ b/star/test_suite/pisn/inlist_pgstar @@ -583,7 +583,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star/test_suite/split_burn_big_net/inlist_pgstar b/star/test_suite/split_burn_big_net/inlist_pgstar index 36c086834..af46bda36 100644 --- a/star/test_suite/split_burn_big_net/inlist_pgstar +++ b/star/test_suite/split_burn_big_net/inlist_pgstar @@ -545,7 +545,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star/test_suite/twin_studies/inlist_pgstar b/star/test_suite/twin_studies/inlist_pgstar index c7605115b..ba5bd8494 100644 --- a/star/test_suite/twin_studies/inlist_pgstar +++ b/star/test_suite/twin_studies/inlist_pgstar @@ -537,7 +537,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star/test_suite/zams_to_cc_80/inlist_pgstar b/star/test_suite/zams_to_cc_80/inlist_pgstar index 5b9388177..f0d4f5201 100644 --- a/star/test_suite/zams_to_cc_80/inlist_pgstar +++ b/star/test_suite/zams_to_cc_80/inlist_pgstar @@ -538,7 +538,7 @@ Mixing_file_aspect_ratio = -1 ! negative means use same value as for window HR_fname = '' ! file name for extra HR data ! Enables calling a subroutine to add extra information to a plot - ! see `$MESA_DIR/star/other/pgstar_decorator.f90` + ! see `$MESA_DIR/star_data/public/star_pgstar.f90` HR_use_decorator = .false. diff --git a/star_data/public/star_pgstar.f90 b/star_data/public/star_pgstar.f90 index a1b7197a0..e94e15101 100644 --- a/star_data/public/star_pgstar.f90 +++ b/star_data/public/star_pgstar.f90 @@ -51,6 +51,40 @@ subroutine pgstar_decorator_interface(id, xmin, xmax, ymin, ymax, plot_num, ierr integer, intent(out) :: ierr end subroutine pgstar_decorator_interface + ! Example function to add squares and some text to the abundance plot + ! subroutine Abundance_pgstar_decorator(id, xmin, xmax, ymin, ymax, plot_num, ierr) + ! use star_def + ! use const_def, only: dp + ! use pgstar_colors + ! integer, intent(in) :: id + ! !Not dp + ! real,intent(in) :: xmin, xmax, ymin, ymax + ! real :: xcenter,ycenter,dx,dy,a + ! integer, intent(out) :: ierr + ! integer :: i + ! type (star_info), pointer :: s + + ! ierr = 0 + ! call star_ptr(id, s, ierr) + ! if (ierr /= 0) return + + ! dx=(xmax-xmin) + ! dy=(ymax-ymin) + + ! xcenter=xmin+dx*0.5 + ! ycenter=ymin+dy*0.5 + + ! call pgsci(clr_Coral) + + ! do i=1,4 + ! a=(i/10.0) + ! call pgline(5, (/xcenter-a*dx,xcenter-a*dx,xcenter+a*dx,xcenter+a*dx,xcenter-a*dx/),& + ! (/ycenter-a*dy,ycenter+a*dy,ycenter+a*dy,ycenter-a*dy,ycenter-a*dy/)) + ! end do + + ! call pgptxt(xcenter,ycenter, 0.0, 1.0, 'Some added text on this plot') + + ! end subroutine Abundance_pgstar_decorator end interface type pgstar_win_file_data From 899b638585ea84ac165a24d7da43cbcda0d9869c Mon Sep 17 00:00:00 2001 From: Vincent Vanlaer Date: Tue, 23 Dec 2025 10:36:57 +0100 Subject: [PATCH 2/3] binary: remove unused null_binary_controls from tests --- .../dev_TDC_Cepheid_6M/src/run_star_extras.f90 | 6 ------ .../dev_TDC_through_ppisn/src/run_star_extras.f90 | 6 ------ star/test_suite/ppisn/src/run_star_extras.f90 | 6 ------ 3 files changed, 18 deletions(-) diff --git a/star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_6M/src/run_star_extras.f90 b/star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_6M/src/run_star_extras.f90 index 36ef9a565..7feffebf1 100644 --- a/star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_6M/src/run_star_extras.f90 +++ b/star/dev_cases_TDC_Pulsation/dev_TDC_Cepheid_6M/src/run_star_extras.f90 @@ -552,12 +552,6 @@ subroutine my_before_struct_burn_mix(id, dt, res) res = keep_going end subroutine my_before_struct_burn_mix - subroutine null_binary_controls(id, binary_id, ierr) - integer, intent(in) :: id, binary_id - integer, intent(out) :: ierr - ierr = 0 - end subroutine null_binary_controls - ! returns either keep_going or terminate. integer function extras_finish_step(id) use run_star_support diff --git a/star/dev_cases_test_TDC/dev_TDC_through_ppisn/src/run_star_extras.f90 b/star/dev_cases_test_TDC/dev_TDC_through_ppisn/src/run_star_extras.f90 index 63647e533..ab7d152a9 100644 --- a/star/dev_cases_test_TDC/dev_TDC_through_ppisn/src/run_star_extras.f90 +++ b/star/dev_cases_test_TDC/dev_TDC_through_ppisn/src/run_star_extras.f90 @@ -1422,12 +1422,6 @@ subroutine my_before_struct_burn_mix(id, dt, res) res = keep_going end subroutine my_before_struct_burn_mix - subroutine null_binary_controls(id, binary_id, ierr) - integer, intent(in) :: id, binary_id - integer, intent(out) :: ierr - ierr = 0 - end subroutine null_binary_controls - ! returns either keep_going or terminate. integer function extras_finish_step(id) use run_star_support diff --git a/star/test_suite/ppisn/src/run_star_extras.f90 b/star/test_suite/ppisn/src/run_star_extras.f90 index b4489d6af..7c56aeadc 100644 --- a/star/test_suite/ppisn/src/run_star_extras.f90 +++ b/star/test_suite/ppisn/src/run_star_extras.f90 @@ -1334,12 +1334,6 @@ subroutine my_before_struct_burn_mix(id, dt, res) res = keep_going end subroutine my_before_struct_burn_mix - subroutine null_binary_controls(id, binary_id, ierr) - integer, intent(in) :: id, binary_id - integer, intent(out) :: ierr - ierr = 0 - end subroutine null_binary_controls - ! returns either keep_going or terminate. integer function extras_finish_step(id) use run_star_support From 8db1e193d92919e6faa0d4e862726deeb15b24f0 Mon Sep 17 00:00:00 2001 From: Vincent Vanlaer Date: Tue, 23 Dec 2025 10:55:12 +0100 Subject: [PATCH 3/3] kap: make other hooks init more consistent Whether this is the better choice vs keeping all function pointers set to null is potentially a future debate --- kap/public/kap_lib.f90 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kap/public/kap_lib.f90 b/kap/public/kap_lib.f90 index cfbf7e897..e798c9f2f 100644 --- a/kap/public/kap_lib.f90 +++ b/kap/public/kap_lib.f90 @@ -137,6 +137,7 @@ subroutine kap_setup_hooks(handle, ierr) use kap_def, only : Kap_General_Info, get_kap_ptr use other_elect_cond_opacity use other_compton_opacity + use other_radiative_opacity integer, intent(in) :: handle integer, intent(out):: ierr @@ -147,6 +148,7 @@ subroutine kap_setup_hooks(handle, ierr) rq% other_elect_cond_opacity => null_other_elect_cond_opacity rq% other_compton_opacity => null_other_compton_opacity + rq% other_radiative_opacity => null_other_radiative_opacity end subroutine kap_setup_hooks