-
Notifications
You must be signed in to change notification settings - Fork 563
docs: start restructuring and add local build automation #1528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Greptile OverviewGreptile SummaryThis PR adds local documentation build automation and begins restructuring the documentation organization. The changes include new build scripts ( Key improvements:
Issues found:
|
| Filename | Score | Overview |
|---|---|---|
| Makefile | 5/5 | Added docs-serve target to enable live documentation server with auto-rebuild functionality, along with corresponding help text |
| docs/serve.py | 5/5 | New Python script to run sphinx-autobuild with configurable port, host, and browser options, includes proper error handling |
| pyproject.toml | 5/5 | Added sphinx-design and sphinx-autobuild dependencies to the docs group for enhanced documentation features and live server |
| docs/index.md | 3/5 | Restructured main documentation page with new organization, removed old content inclusion, added placeholder "TBD" text, moved getting-started.md to tutorials section |
| docs/overview.md | 2/5 | New comprehensive overview with use cases and benefits, but contains broken references to deleted getting-started.md file |
| docs/how-it-works.md | 4/5 | New landing page with card-based navigation to guardrails process and architecture guides, includes repetitive introductory text |
Sequence Diagram
sequenceDiagram
participant Dev as Developer
participant Make as Makefile
participant Script as serve.py/serve.sh
participant Sphinx as sphinx-autobuild
participant Browser as Web Browser
Dev->>Make: make docs-serve
Make->>Script: cd docs && run sphinx-autobuild
Script->>Sphinx: Start with config (port 8000, watch patterns)
Sphinx->>Sphinx: Initial build from source
Sphinx->>Browser: Open http://127.0.0.1:8000
Browser->>Dev: Display documentation
loop Live Development
Dev->>Sphinx: Save .md, .rst, or .py file
Sphinx->>Sphinx: Detect change (1s debounce)
Sphinx->>Sphinx: Rebuild affected pages
Sphinx->>Browser: Push update via WebSocket
Browser->>Browser: Auto-refresh with new content
end
Dev->>Sphinx: Ctrl+C
Sphinx->>Make: Server stopped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 files reviewed, 4 comments
docs/overview.md
Outdated
|
|
||
| The input and output format for the `generate` method is similar to the [Chat Completions API](https://platform.openai.com/docs/guides/gpt/chat-completions-api) from OpenAI. | ||
|
|
||
| For more information, refer to the [Python API Guide](user-guides/python-api.md) and [Getting Started](getting-started.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Broken link - getting-started.md was deleted in this PR but is still referenced here
| For more information, refer to the [Python API Guide](user-guides/python-api.md) and [Getting Started](getting-started.md). | |
| For more information, refer to the [Python API Guide](user-guides/python-api.md) and [Installation Guide](getting-started/installation-guide.md). |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/overview.md
Line: 70:70
Comment:
**logic:** Broken link - `getting-started.md` was deleted in this PR but is still referenced here
```suggestion
For more information, refer to the [Python API Guide](user-guides/python-api.md) and [Installation Guide](getting-started/installation-guide.md).
```
How can I resolve this? If you propose a fix, please make it concise.
docs/overview.md
Outdated
| - **Community models**: Support for [LlamaGuard](user-guides/community/llama-guard.md), [Fiddler Guardrails](user-guides/community/fiddler.md), and other content safety solutions. | ||
| - **Third-party APIs**: Integration with [ActiveFence](user-guides/guardrails-library.md#activefence), [Cisco AI Defense](user-guides/community/ai-defense.md), and other moderation services. | ||
|
|
||
| For more information, refer to the [Content Safety section](user-guides/guardrails-library.md#content-safety) in the Guardrails Library and the [Getting Started guide](getting-started.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Broken link - getting-started.md was deleted in this PR but is still referenced here
| For more information, refer to the [Content Safety section](user-guides/guardrails-library.md#content-safety) in the Guardrails Library and the [Getting Started guide](getting-started.md). | |
| For more information, refer to the [Content Safety section](user-guides/guardrails-library.md#content-safety) in the Guardrails Library. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/overview.md
Line: 114:114
Comment:
**logic:** Broken link - `getting-started.md` was deleted in this PR but is still referenced here
```suggestion
For more information, refer to the [Content Safety section](user-guides/guardrails-library.md#content-safety) in the Guardrails Library.
```
How can I resolve this? If you propose a fix, please make it concise.
docs/about/how-it-works.md
Outdated
| # How It Works | ||
|
|
||
| NeMo Guardrails is a toolkit for building guardrails for your LLM applications. It provides a set of tools and libraries for building guardrails for your LLM applications. It works by using a set of tools and libraries to build guardrails for your LLM applications. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Repetitive text - same phrase appears three times in a row
| # How It Works | |
| NeMo Guardrails is a toolkit for building guardrails for your LLM applications. It provides a set of tools and libraries for building guardrails for your LLM applications. It works by using a set of tools and libraries to build guardrails for your LLM applications. | |
| # How It Works | |
| NeMo Guardrails is a toolkit for building guardrails for your LLM applications. It provides a set of tools and libraries that work together to protect and control LLM behavior. |
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/how-it-works.md
Line: 1:3
Comment:
**style:** Repetitive text - same phrase appears three times in a row
```suggestion
# How It Works
NeMo Guardrails is a toolkit for building guardrails for your LLM applications. It provides a set of tools and libraries that work together to protect and control LLM behavior.
```
How can I resolve this? If you propose a fix, please make it concise.
docs/index.md
Outdated
| ```{include} ../README.md | ||
| :start-after: <!-- start-documentation-reuse --> | ||
| :end-before: <!-- end-documentation-reuse -- | ||
| TBD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Placeholder "TBD" should be replaced with actual welcome text
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/index.md
Line: 8:8
Comment:
**style:** Placeholder "TBD" should be replaced with actual welcome text
How can I resolve this? If you propose a fix, please make it concise.
Documentation preview |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
fff2055 to
bd11671
Compare
Description
Related Issue(s)
Checklist