Skip to content

Conversation

@miyoungc
Copy link
Collaborator

@miyoungc miyoungc commented Dec 2, 2025

Description

Related Issue(s)

Checklist

  • I've read the CONTRIBUTING guidelines.
  • I've updated the documentation if applicable.
  • I've added tests if applicable.
  • @mentions of the person or team responsible for reviewing proposed changes.

@miyoungc miyoungc self-assigned this Dec 2, 2025
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 2, 2025

Greptile Overview

Greptile Summary

This PR adds local documentation build automation and begins restructuring the documentation organization. The changes include new build scripts (serve.py, serve.sh) and a Makefile target (docs-serve) for running a live documentation server with auto-rebuild, along with comprehensive usage documentation in LIVE_DOCS.md and README.md. The documentation structure is reorganized with new landing pages (overview.md, how-it-works.md) and a tutorials index, while consolidating content from the deleted getting-started.md.

Key improvements:

  • Added sphinx-autobuild and sphinx_design dependencies for enhanced documentation workflow
  • Created multiple methods to serve live documentation (Makefile, Python script, bash script)
  • Reorganized documentation with clearer information architecture
  • Updated project name to "NVIDIA NeMo Guardrails Toolkit"

Issues found:

  • Two broken links in overview.md referencing the deleted getting-started.md file (lines 70 and 114)
  • Placeholder "TBD" text in main index.md needs replacement
  • Repetitive introductory text in how-it-works.md

Confidence Score: 3/5

  • This PR has critical broken links that will cause 404 errors in production documentation
  • Score reflects two critical broken documentation links that must be fixed before merge. The build automation changes are solid, but the broken references to the deleted getting-started.md file will result in broken user experience. Additionally, placeholder content ("TBD") should be resolved.
  • Pay close attention to docs/overview.md (broken links) and docs/index.md (placeholder content)

Important Files Changed

File Analysis

Filename Score Overview
Makefile 5/5 Added docs-serve target to enable live documentation server with auto-rebuild functionality, along with corresponding help text
docs/serve.py 5/5 New Python script to run sphinx-autobuild with configurable port, host, and browser options, includes proper error handling
pyproject.toml 5/5 Added sphinx-design and sphinx-autobuild dependencies to the docs group for enhanced documentation features and live server
docs/index.md 3/5 Restructured main documentation page with new organization, removed old content inclusion, added placeholder "TBD" text, moved getting-started.md to tutorials section
docs/overview.md 2/5 New comprehensive overview with use cases and benefits, but contains broken references to deleted getting-started.md file
docs/how-it-works.md 4/5 New landing page with card-based navigation to guardrails process and architecture guides, includes repetitive introductory text

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Make as Makefile
    participant Script as serve.py/serve.sh
    participant Sphinx as sphinx-autobuild
    participant Browser as Web Browser
    
    Dev->>Make: make docs-serve
    Make->>Script: cd docs && run sphinx-autobuild
    Script->>Sphinx: Start with config (port 8000, watch patterns)
    Sphinx->>Sphinx: Initial build from source
    Sphinx->>Browser: Open http://127.0.0.1:8000
    Browser->>Dev: Display documentation
    
    loop Live Development
        Dev->>Sphinx: Save .md, .rst, or .py file
        Sphinx->>Sphinx: Detect change (1s debounce)
        Sphinx->>Sphinx: Rebuild affected pages
        Sphinx->>Browser: Push update via WebSocket
        Browser->>Browser: Auto-refresh with new content
    end
    
    Dev->>Sphinx: Ctrl+C
    Sphinx->>Make: Server stopped
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 files reviewed, 4 comments

Edit Code Review Agent Settings | Greptile

docs/overview.md Outdated

The input and output format for the `generate` method is similar to the [Chat Completions API](https://platform.openai.com/docs/guides/gpt/chat-completions-api) from OpenAI.

For more information, refer to the [Python API Guide](user-guides/python-api.md) and [Getting Started](getting-started.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Broken link - getting-started.md was deleted in this PR but is still referenced here

Suggested change
For more information, refer to the [Python API Guide](user-guides/python-api.md) and [Getting Started](getting-started.md).
For more information, refer to the [Python API Guide](user-guides/python-api.md) and [Installation Guide](getting-started/installation-guide.md).
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/overview.md
Line: 70:70

Comment:
**logic:** Broken link - `getting-started.md` was deleted in this PR but is still referenced here

```suggestion
For more information, refer to the [Python API Guide](user-guides/python-api.md) and [Installation Guide](getting-started/installation-guide.md).
```

How can I resolve this? If you propose a fix, please make it concise.

docs/overview.md Outdated
- **Community models**: Support for [LlamaGuard](user-guides/community/llama-guard.md), [Fiddler Guardrails](user-guides/community/fiddler.md), and other content safety solutions.
- **Third-party APIs**: Integration with [ActiveFence](user-guides/guardrails-library.md#activefence), [Cisco AI Defense](user-guides/community/ai-defense.md), and other moderation services.

For more information, refer to the [Content Safety section](user-guides/guardrails-library.md#content-safety) in the Guardrails Library and the [Getting Started guide](getting-started.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

logic: Broken link - getting-started.md was deleted in this PR but is still referenced here

Suggested change
For more information, refer to the [Content Safety section](user-guides/guardrails-library.md#content-safety) in the Guardrails Library and the [Getting Started guide](getting-started.md).
For more information, refer to the [Content Safety section](user-guides/guardrails-library.md#content-safety) in the Guardrails Library.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/overview.md
Line: 114:114

Comment:
**logic:** Broken link - `getting-started.md` was deleted in this PR but is still referenced here

```suggestion
For more information, refer to the [Content Safety section](user-guides/guardrails-library.md#content-safety) in the Guardrails Library.
```

How can I resolve this? If you propose a fix, please make it concise.

Comment on lines 1 to 3
# How It Works

NeMo Guardrails is a toolkit for building guardrails for your LLM applications. It provides a set of tools and libraries for building guardrails for your LLM applications. It works by using a set of tools and libraries to build guardrails for your LLM applications.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Repetitive text - same phrase appears three times in a row

Suggested change
# How It Works
NeMo Guardrails is a toolkit for building guardrails for your LLM applications. It provides a set of tools and libraries for building guardrails for your LLM applications. It works by using a set of tools and libraries to build guardrails for your LLM applications.
# How It Works
NeMo Guardrails is a toolkit for building guardrails for your LLM applications. It provides a set of tools and libraries that work together to protect and control LLM behavior.
Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/how-it-works.md
Line: 1:3

Comment:
**style:** Repetitive text - same phrase appears three times in a row

```suggestion
# How It Works

NeMo Guardrails is a toolkit for building guardrails for your LLM applications. It provides a set of tools and libraries that work together to protect and control LLM behavior.
```

How can I resolve this? If you propose a fix, please make it concise.

docs/index.md Outdated
```{include} ../README.md
:start-after: <!-- start-documentation-reuse -->
:end-before: <!-- end-documentation-reuse --
TBD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Placeholder "TBD" should be replaced with actual welcome text

Prompt To Fix With AI
This is a comment left during a code review.
Path: docs/index.md
Line: 8:8

Comment:
**style:** Placeholder "TBD" should be replaced with actual welcome text

How can I resolve this? If you propose a fix, please make it concise.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Documentation preview

https://nvidia-nemo.github.io/Guardrails/review/pr-1528

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant