Skip to content

Feature/cstackex 22: Shared NFS pool and volume creation - Approach 1 #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
piyush5netapp wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Feature/cstackex 22: Shared NFS pool and volume creation - Approach 1 #22

piyush5netapp wants to merge 25 commits into from

Conversation

@piyush5netapp
Copy link

@piyush5netapp piyush5netapp commented Dec 4, 2025 •
edited
Loading

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  1. Create Storage Pool Type as NetworkFileSystem
image 2. Storage Pool is mounted on host . image 3. Ontap volume mapped to storage pool is created with custom export policy with host IPs allowed as clients. image 4. Create a VM instance with disk offering same as storage pool disk offering. image image image 5. Attach a volume to already existing vm instance image 6. All volume are as a file inside storage pool volume image

How did you try to break this feature and the system with this change?

rajiv-jain-netapp
rajiv-jain-netapp reviewed Dec 5, 2025
View reviewed changes
...ap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java
break;
case ISCSI:
parameters.setType(Storage.StoragePoolType.Iscsi);
path = "iqn.1992-08.com.netapp:" + details.get(Constants.SVM_NAME) + "." + storagePoolName;
Copy link

@rajiv-jain-netapp rajiv-jain-netapp Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove all these hard-coded values. You can keep them as commented code if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rajiv-jain-netapp rajiv-jain-netapp rajiv-jain-netapp left review comments

@sandeeplocharla sandeeplocharla Awaiting requested review from sandeeplocharla

@suryag1201 suryag1201 Awaiting requested review from suryag1201

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@piyush5netapp @rajiv-jain-netapp