From a90cbb43fd3eb115855edefefe061bc50fecf775 Mon Sep 17 00:00:00 2001 From: Jeel Dobariya <136002730+JeelDobariya38@users.noreply.github.com> Date: Thu, 13 Nov 2025 22:20:41 +0530 Subject: [PATCH 1/2] chore/feat: Disable copy password button based on feature flag Remove feature flag check for copy password button --- .../com/jeeldobariya/passcodes/ui/ViewPasswordActivity.kt | 2 -- 1 file changed, 2 deletions(-) diff --git a/app/src/main/kotlin/com/jeeldobariya/passcodes/ui/ViewPasswordActivity.kt b/app/src/main/kotlin/com/jeeldobariya/passcodes/ui/ViewPasswordActivity.kt index 7629b2c0..e927e5d1 100644 --- a/app/src/main/kotlin/com/jeeldobariya/passcodes/ui/ViewPasswordActivity.kt +++ b/app/src/main/kotlin/com/jeeldobariya/passcodes/ui/ViewPasswordActivity.kt @@ -67,8 +67,6 @@ class ViewPasswordActivity : AppCompatActivity() { } } - binding.copyPasswordBtn.isEnabled = FeatureFlagManager.get(this).latestFeaturesEnabled - // Add event onclick listener addOnClickListenerOnButton() From 9a1ea0c13200f67d7dc55d91b0edc53ec9126a14 Mon Sep 17 00:00:00 2001 From: Jeel Dobariya <136002730+JeelDobariya38@users.noreply.github.com> Date: Thu, 13 Nov 2025 22:30:43 +0530 Subject: [PATCH 2/2] chore: Revise pull request template for improved guidance Updated pull request template for clarity and conciseness. --- .github/pull_request_template.md | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 867bd495..7e64e384 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -4,17 +4,17 @@ - summary 2. - ... -> summary here should be in one line (write consise so that review without take look at code, can say/determine what changed).. -> they should provide structure overview that read and understand what changed -> not a detail guide, you can provide further infomation in notes section or it would be expictily ask in pr comments at review if need..) +> Summary here, should be in one line (write consise so that reviewer without take look at code, can say/determine what changed).. +> summary above should provide structure overview that one can read and understand what changed. +> summary should not be a detail guide, just short description. +> you can provide further infomation in notes section or it would be expictily ask in pr comments at time of review if need..) # Breaking Changes -- [Write about any breaking changes, like architure change or databse changes etc.. If none, remove the sectio compeletly]. +- [Write about any breaking changes, like architecture changes or database changes etc.. If none, remove the section compeletly]. ## Notes -[if any, otherwise remove the section] - +[write notes if any, otherwise remove the section]