From d3b8acda3e37f5299dd901812b31948ccbe7e3c3 Mon Sep 17 00:00:00 2001
From: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Date: Sat, 6 Dec 2025 22:28:49 +0000
Subject: [PATCH 1/4] Add deprecation notice to package.xml

---
 parameter_traits/package.xml | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/parameter_traits/package.xml b/parameter_traits/package.xml
index dec2879..805a3bf 100644
--- a/parameter_traits/package.xml
+++ b/parameter_traits/package.xml
@@ -25,5 +25,11 @@
 
   <export>
     <build_type>ament_cmake</build_type>
+    <export>
+    <deprecated>
+      This package will be removed in Lyrical Luth. Instead, use the
+      rsl or tl_expected packages directly for similar functionality.
+    </deprecated>
+</export>
   </export>
 </package>

From 17fa967a19a327d4971ecfd5a5b549f4177c51a0 Mon Sep 17 00:00:00 2001
From: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Date: Sat, 6 Dec 2025 22:32:47 +0000
Subject: [PATCH 2/4] Add deprecation notice to header file

---
 .../include/parameter_traits/parameter_traits.hpp        | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/parameter_traits/include/parameter_traits/parameter_traits.hpp b/parameter_traits/include/parameter_traits/parameter_traits.hpp
index a44b484..894be68 100644
--- a/parameter_traits/include/parameter_traits/parameter_traits.hpp
+++ b/parameter_traits/include/parameter_traits/parameter_traits.hpp
@@ -32,6 +32,15 @@
 #include <rsl/algorithm.hpp>
 #include <tl_expected/expected.hpp>
 
+#define PARAMETER_TRAITS_HEADER_DEPRECATION This header is obsolete, \
+  please include "rsl/algorithm.hpp" for rsl::contains and rsl::is_unique, \
+  and "tl_expected/expected.hpp" for tl::expected.
+#ifdef _MSC_VER
+#pragma message(PARAMETER_TRAITS_HEADER_DEPRECATION)
+#else
+#warning PARAMETER_TRAITS_HEADER_DEPRECATION
+#endif
+
 namespace parameter_traits {
 
 using Result

From 5e70e281c559a06797074484223e1758be462ef8 Mon Sep 17 00:00:00 2001
From: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Date: Sat, 6 Dec 2025 23:00:44 +0000
Subject: [PATCH 3/4] Fix warning string

---
 .../include/parameter_traits/parameter_traits.hpp    | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/parameter_traits/include/parameter_traits/parameter_traits.hpp b/parameter_traits/include/parameter_traits/parameter_traits.hpp
index 894be68..db10ab0 100644
--- a/parameter_traits/include/parameter_traits/parameter_traits.hpp
+++ b/parameter_traits/include/parameter_traits/parameter_traits.hpp
@@ -32,13 +32,15 @@
 #include <rsl/algorithm.hpp>
 #include <tl_expected/expected.hpp>
 
-#define PARAMETER_TRAITS_HEADER_DEPRECATION This header is obsolete, \
-  please include "rsl/algorithm.hpp" for rsl::contains and rsl::is_unique, \
-  and "tl_expected/expected.hpp" for tl::expected.
 #ifdef _MSC_VER
-#pragma message(PARAMETER_TRAITS_HEADER_DEPRECATION)
+#pragma message( \
+    "This header is obsolete, \
+  please include \"rsl/algorithm.hpp\" for rsl::contains and rsl::is_unique, \
+  and \"tl_expected/expected.hpp\" for tl::expected.")
 #else
-#warning PARAMETER_TRAITS_HEADER_DEPRECATION
+#warning This header is obsolete, \
+  please include "rsl/algorithm.hpp" for rsl::contains and rsl::is_unique, \
+  and "tl_expected/expected.hpp" for tl::expected.
 #endif
 
 namespace parameter_traits {

From 9f7dca215e9104ae778a2854dda2e6c2403f75ae Mon Sep 17 00:00:00 2001
From: Christoph Froehlich <christoph.froehlich@ait.ac.at>
Date: Sat, 6 Dec 2025 23:03:33 +0000
Subject: [PATCH 4/4] Silence it in our own header

---
 .../jinja_templates/cpp/parameter_library_header               | 3 +++
 parameter_traits/include/parameter_traits/parameter_traits.hpp | 2 ++
 2 files changed, 5 insertions(+)

diff --git a/generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header b/generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
index 9ce83fc..9c5a4a6 100644
--- a/generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
+++ b/generate_parameter_library_py/generate_parameter_library_py/jinja_templates/cpp/parameter_library_header
@@ -21,7 +21,10 @@
 #include <fmt/format.h>
 #include <fmt/ranges.h>
 
+// silence deprecation warnings for parameter_traits, needed for backwards compatibility
+#define SILENCE_DEPRECATION_WARNINGS
 #include <parameter_traits/parameter_traits.hpp>
+#undef SILENCE_DEPRECATION_WARNINGS
 
 #include <rsl/static_string.hpp>
 #include <rsl/static_vector.hpp>
diff --git a/parameter_traits/include/parameter_traits/parameter_traits.hpp b/parameter_traits/include/parameter_traits/parameter_traits.hpp
index db10ab0..d7174de 100644
--- a/parameter_traits/include/parameter_traits/parameter_traits.hpp
+++ b/parameter_traits/include/parameter_traits/parameter_traits.hpp
@@ -32,6 +32,7 @@
 #include <rsl/algorithm.hpp>
 #include <tl_expected/expected.hpp>
 
+#ifndef SILENCE_DEPRECATION_WARNINGS
 #ifdef _MSC_VER
 #pragma message( \
     "This header is obsolete, \
@@ -42,6 +43,7 @@
   please include "rsl/algorithm.hpp" for rsl::contains and rsl::is_unique, \
   and "tl_expected/expected.hpp" for tl::expected.
 #endif
+#endif
 
 namespace parameter_traits {