[DM/MFD] Update MFD #10995
[DM/MFD] Update MFD #10995
Conversation
Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-12-05 15:45 CST)
📝 Review Instructions
|
| #define EDU_REG_CARD_LIVENESS 0x04 | ||
| #define EDU_REG_VALUE 0x08 | ||
| #define EDU_REG_STATUS 0x20 | ||
| #define EDU_REG_STATUS_IRQ 0x80 |
There was a problem hiding this comment.
这里主要是寄存器的位域，便于区分就这样写了
There was a problem hiding this comment.
Pull request overview
This PR adds a QEMU EDU (Educational) device driver for PCI study and updates the MFD Kconfig to support Device Manager imports. The EDU device is a simple PCI device provided by QEMU for learning PCI driver development, implementing both character device operations (factorial calculation) and DMA controller functionality.
Key Changes:
- New QEMU EDU PCI device driver with DMA support for educational purposes
- Kconfig updates to add RT_MFD_EDU option and support for SOC-specific MFD driver imports via osource directive
- Build script integration for conditional compilation of the new driver
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 13 comments.
| File | Description |
|---|---|
| components/drivers/mfd/mfd-edu.c | New QEMU EDU PCI device driver implementing character device interface and DMA controller for educational/testing purposes |
| components/drivers/mfd/SConscript | Added conditional compilation support for RT_MFD_EDU configuration option |
| components/drivers/mfd/Kconfig | Added RT_MFD_EDU configuration option and osource directive for Device Manager integration |
Note: Several critical issues were identified in the implementation including resource management problems, race conditions, undefined function calls, and incomplete DMA operation implementations. Please review all comments carefully before merging.
EDU Support DMA (lower 32 bits) and factorial, MSI-X, user can change device or driver to study PCI. Signed-off-by: GuEe-GUI <2991707448@qq.com>
|
@Rbb666 AI 要求问题已修改 |
2 participants
拉取/合并请求描述：(PR description)
[
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up