Skip to content

Doubt about resetting the root fontsize after a breakpoint #39

@ao2

Description

@ao2

Hi,

I see that the media() mixin resets the root font size after applying the content to a breakpoint, and this is expected, however it always reset the value base on breakpoint 0: https://github.com/StudioThick/megatype/blob/master/megatype/_media.scss#L74

In case of nested media queries this could be incorrect.

Should the media mixin remember the last root fontsize and reset the value to that, instead of always reset based on breakpoint 0?

I have not experienced the problem myself, and I guess that nested media queries are not widely used, the doubt jut came by reading the code and I thought about asking about it.

Ciao,
Antonio

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions