From 0846987906cddfe41b1931dde0abb129794e6dd0 Mon Sep 17 00:00:00 2001
From: Oliver Kwun-Morfitt <oliverkwunmorfitt@gmail.com>
Date: Sat, 15 Nov 2025 17:31:30 -0500
Subject: [PATCH 1/6] some intial state and ctx for auth

---
 cli/cmd/root.go | 68 ++++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 62 insertions(+), 6 deletions(-)

diff --git a/cli/cmd/root.go b/cli/cmd/root.go
index dc03e11..98b8c81 100644
--- a/cli/cmd/root.go
+++ b/cli/cmd/root.go
@@ -1,28 +1,84 @@
 package cmd
 
 import (
+	"encoding/json"
+	"net/http"
+	"os"
+	"path/filepath"
+	"time"
+
 	"github.com/alecthomas/kong"
 )
 
+type Config struct {
+	AccessToken string `json:"access_token"`
+	// maybe APIBaseURL, etc.
+}
+
+type AppContext struct {
+	Config     *Config
+	HTTPClient *http.Client
+}
+
+type Globals struct {
+	ConfigPath string `name:"config" help:"Path to config file" default:"${config_path}"`
+}
+
 type CLI struct {
-	// Define your CLI structure here: Top Level Commands 
+	Globals
+
+	// Define your CLI structure here: Top Level Commands
 	Auth AuthCmd `cmd:"" help:"Authentication commands"`
 	Job  JobCmd  `cmd:"" help:"Job management commands"`
 	// Config ConfigCmd `cmd:"" help:"Configuration commands"`
 	Help HelpCmd `cmd:"" help:"Show help information"`
-	Config ConfigCmd `cmd:"" help: "Display Cluster Configuration"`
+	// Config ConfigCmd `cmd:"" help: "Display Cluster Configuration"`
+}
+
+func defaultConfigPath() string {
+	dir, err := os.UserConfigDir()
+	if err != nil {
+		home, _ := os.UserHomeDir()
+		return filepath.Join(home, ".config", "mist", "config.json")
+	}
+	return filepath.Join(dir, "mist", "config.json")
+}
+
+func loadConfig(path string) (*Config, error) {
+	b, err := os.ReadFile(path)
+	if err != nil {
+		return nil, err
+	}
+
+	var cfg Config
+	if err := json.Unmarshal(b, &cfg); err != nil {
+		return nil, err
+	}
+
+	return &cfg, nil
 }
 
 func Main() {
 	var cli CLI
-	// Read command-line arguments 
-	ctx := kong.Parse(&cli,
+	// Read command-line arguments
+
+	appCtx := &AppContext{
+		HTTPClient: &http.Client{Timeout: 10 * time.Second},
+	}
+
+	kctx := kong.Parse(&cli,
 		kong.Name("mist"),
 		kong.Description("MIST CLI - Manage your MIST jobs and configurations"),
 		kong.UsageOnError(),
+		kong.Vars{"config_path": defaultConfigPath()},
+		kong.Bind(appCtx),
 	)
 
-	err := ctx.Run()
-	ctx.FatalIfErrorf(err)
+	if cfg, err := loadConfig(cli.ConfigPath); err == nil {
+		appCtx.Config = cfg
+	}
+
+	err := kctx.Run()
+	kctx.FatalIfErrorf(err)
 	// fmt.Println("Command executed successfully")
 }

From 7095f52cdc4f60ef959dd005ad51541a62d3ddc8 Mon Sep 17 00:00:00 2001
From: Oliver Kwun-Morfitt <oliverkwunmorfitt@gmail.com>
Date: Sat, 15 Nov 2025 19:37:40 -0500
Subject: [PATCH 2/6] added app context to every command

---
 cli/cmd/auth_login.go |  2 +-
 cli/cmd/config.go     | 20 +++++++++-----------
 cli/cmd/job_cancel.go | 24 +++++++++++-------------
 cli/cmd/job_list.go   |  2 +-
 cli/cmd/job_status.go |  2 +-
 cli/cmd/job_submit.go |  3 +--
 6 files changed, 24 insertions(+), 29 deletions(-)

diff --git a/cli/cmd/auth_login.go b/cli/cmd/auth_login.go
index 1f24521..f1230bb 100644
--- a/cli/cmd/auth_login.go
+++ b/cli/cmd/auth_login.go
@@ -23,7 +23,7 @@ func verifyUser(username, password string) error {
 // TODO: Figure out how to handle password input without exposing it in the terminal historyn  (go get golang.org/x/term)
 // TODO: Where are we storing auth token? Are we getting JWT?
 
-func (l *LoginCmd) Run() error {
+func (l *LoginCmd) Run(ctx *AppContext) error {
 	// mist auth login
 
 	fmt.Print("Username: ")
diff --git a/cli/cmd/config.go b/cli/cmd/config.go
index acb9ba8..5869954 100644
--- a/cli/cmd/config.go
+++ b/cli/cmd/config.go
@@ -2,28 +2,26 @@ package cmd
 
 import "fmt"
 
-
-// Config flags 
-type ConfigCmd struct{
+// Config flags
+type ConfigCmd struct {
 	DefaultCluster string `help:"Set the default compute cluster." optional: ""`
-	Show bool `help:"Show current configuration."`
-
+	Show           bool   `help:"Show current configuration."`
 }
 
-func (h *ConfigCmd) Run() error {
-	// Some dummy config; Call API or something 
+func (h *ConfigCmd) Run(ctx *AppContext) error {
+	// Some dummy config; Call API or something
 	defaultConfig := map[string]string{
 		"defaultCluster": "AMD-cluster-1",
-		"region": "us-east",
+		"region":         "us-east",
 	}
 
-	if h.Show && h.DefaultCluster!= "" {
+	if h.Show && h.DefaultCluster != "" {
 		fmt.Printf("Cannot use --show and --default-cluster together")
 		return nil
 	}
 
 	if h.DefaultCluster != "" {
-		// This is not actually set. 
+		// This is not actually set.
 		fmt.Printf("Setting default cluster to: %s\n", h.DefaultCluster)
 		return nil
 	}
@@ -36,7 +34,7 @@ func (h *ConfigCmd) Run() error {
 		return nil
 	}
 
-    fmt.Println("No config action specified. Use --help for options.")
+	fmt.Println("No config action specified. Use --help for options.")
 
 	return nil
 }
diff --git a/cli/cmd/job_cancel.go b/cli/cmd/job_cancel.go
index 446787a..949a885 100644
--- a/cli/cmd/job_cancel.go
+++ b/cli/cmd/job_cancel.go
@@ -8,13 +8,12 @@ import (
 	"time"
 )
 
-
 type JobCancelCmd struct {
-	ID  string `arg:"" help:"ID of job you want to cancel"`
+	ID string `arg:"" help:"ID of job you want to cancel"`
 }
 
-func (c *JobCancelCmd) Run() error {
-	// Same Mock data from job list. 
+func (c *JobCancelCmd) Run(ctx *AppContext) error {
+	// Same Mock data from job list.
 	jobs := []Job{
 		{
 			ID:        "ID:1",
@@ -39,36 +38,35 @@ func (c *JobCancelCmd) Run() error {
 		},
 	}
 
-	// Check if job exists 
+	// Check if job exists
 	if !jobExists(jobs, c.ID) {
 		fmt.Printf("%s does not exist in your jobs.\n", c.ID)
 		fmt.Printf("Use the command \"job list\" for your list of jobs.")
-		return nil 
+		return nil
 	}
 
-
 	fmt.Printf("Are you sure you want to cancel %s? (y/n): \n", c.ID)
 
 	reader := bufio.NewReader(os.Stdin)
 	input, _ := reader.ReadString('\n')
 	input = strings.TrimSpace(strings.ToLower(input))
 
-	if input == "y" || input == "yes"{
+	if input == "y" || input == "yes" {
 		fmt.Println("Confirmed, proceeding job cancellation....")
 
-		// Confirmed job cancellation logic 
+		// Confirmed job cancellation logic
 
 		fmt.Println("Cancelling job with ID:", c.ID)
 		fmt.Printf("Job cancelled successfully with ID: %s\n", c.ID)
 		return nil
-	} else if input == "n" || input == "no"{
+	} else if input == "n" || input == "no" {
 		fmt.Println("Cancelled.")
 		return nil
-	} else{
+	} else {
 		fmt.Println("Invalid response.")
 		return nil
 	}
 
-	return nil 
+	return nil
 
-}
\ No newline at end of file
+}
diff --git a/cli/cmd/job_list.go b/cli/cmd/job_list.go
index 118df0e..9e4787d 100644
--- a/cli/cmd/job_list.go
+++ b/cli/cmd/job_list.go
@@ -19,7 +19,7 @@ type Job struct {
 	CreatedAt time.Time
 }
 
-func (l *ListCmd) Run() error {
+func (l *ListCmd) Run(ctx *AppContext) error {
 	// Mock data - pull from API in real implementation
 	jobs := []Job{
 		{
diff --git a/cli/cmd/job_status.go b/cli/cmd/job_status.go
index cff9187..20634c8 100644
--- a/cli/cmd/job_status.go
+++ b/cli/cmd/job_status.go
@@ -11,7 +11,7 @@ type JobStatusCmd struct {
 	ID string `arg:"" help:"The ID of the job to check the status for"`
 }
 
-func (j *JobStatusCmd) Run() error {
+func (j *JobStatusCmd) Run(ctx *AppContext) error {
 	// Mock data - pull from API in real implementation
 	jobs := []Job{{
 		ID:        "ID:1",
diff --git a/cli/cmd/job_submit.go b/cli/cmd/job_submit.go
index d090934..22b793f 100644
--- a/cli/cmd/job_submit.go
+++ b/cli/cmd/job_submit.go
@@ -12,8 +12,7 @@ type JobSubmitCmd struct {
 	Compute string `help:"Type of compute required for the job: AMD|TT|CPU" default:"AMD"`
 }
 
-
-func (j *JobSubmitCmd) Run() error {
+func (j *JobSubmitCmd) Run(ctx *AppContext) error {
 	// mist job submit <script> <compute_type>
 
 	// TODO: ADD AUTH CHECK

From a09619ca7c8d9ccbdd7b9b359ed282ce42f63ca7 Mon Sep 17 00:00:00 2001
From: Oliver Kwun-Morfitt <oliverkwunmorfitt@gmail.com>
Date: Sun, 16 Nov 2025 14:30:55 -0500
Subject: [PATCH 3/6] added browser opening and token saving

---
 cli/cmd/auth_login.go | 70 ++++++++++++++++++++++++++++++++-----------
 cli/cmd/root.go       | 10 -------
 cli/cmd/testutil.go   | 11 ++++++-
 3 files changed, 62 insertions(+), 29 deletions(-)

diff --git a/cli/cmd/auth_login.go b/cli/cmd/auth_login.go
index f1230bb..ee44bb5 100644
--- a/cli/cmd/auth_login.go
+++ b/cli/cmd/auth_login.go
@@ -2,45 +2,79 @@ package cmd
 
 import (
 	"bufio"
-	"errors"
+	"encoding/json"
 	"fmt"
 	"os"
+	"os/exec"
+	"path/filepath"
+	"runtime"
 	"strings"
 )
 
-// TODO: What credentials are we taking?
+// TODO: Update with real auth URL
+const authUrl = "https://example.com/login"
+
 type LoginCmd struct {
 }
 
-func verifyUser(username, password string) error {
-	// Placeholder for actual authentication logic
-	if username == "admin" && password == "password" {
-		return nil
+func openUrl() error {
+
+	var cmd *exec.Cmd
+	url := authUrl
+	switch runtime.GOOS {
+	case "darwin":
+		cmd = exec.Command("open", url)
+	case "windows":
+		cmd = exec.Command("rundll32", "url.dll,FileProtocolHandler", url)
+	default: // Linux, BSD, etc.
+		cmd = exec.Command("xdg-open", url)
 	}
-	return errors.New("invalid credentials")
+
+	return cmd.Start()
 }
 
-// TODO: Figure out how to handle password input without exposing it in the terminal historyn  (go get golang.org/x/term)
-// TODO: Where are we storing auth token? Are we getting JWT?
+func saveTokenToConfig(ctx *AppContext, token string) error {
+	configPath := defaultConfigPath()
+	if err := os.MkdirAll(filepath.Dir(configPath), 0o755); err != nil {
+		return fmt.Errorf("failed to create config directory: %w", err)
+	}
+	cfg := &Config{
+		AccessToken: token,
+	}
+	data, err := json.MarshalIndent(cfg, "", "  ")
+	if err != nil {
+		return fmt.Errorf("failed to marshal config: %w", err)
+	}
+	if err := os.WriteFile(configPath, data, 0o600); err != nil {
+		return fmt.Errorf("failed to write config file: %w", err)
+	}
+	fmt.Println("Token saved:", token)
+	return nil
+}
 
 func (l *LoginCmd) Run(ctx *AppContext) error {
 	// mist auth login
-
-	fmt.Print("Username: ")
+	if ctx.Config != nil && ctx.Config.AccessToken != "" {
+		fmt.Println("Already logged in with token:", ctx.Config.AccessToken)
+	}
+	fmt.Println("Opening browser for authentication...")
+	err := openUrl()
+	if err != nil {
+		fmt.Println("Error opening browser:", err)
+		return err
+	}
+	fmt.Print("token: ")
 
 	reader := bufio.NewReader(os.Stdin)
-	username, _ := reader.ReadString('\n')
-	username = strings.TrimSpace(strings.ToLower(username))
+	token, _ := reader.ReadString('\n')
+	token = strings.TrimSpace(strings.ToLower(token))
 
-	fmt.Print("Password: ")
-	password, _ := reader.ReadString('\n')
-	password = strings.TrimSpace(strings.ToLower(password))
-	err := verifyUser(username, password)
+	err = saveTokenToConfig(ctx, token)
 	if err != nil {
 		fmt.Println("Error during authentication:", err)
 	}
 
-	fmt.Println("Logging in with username:", username)
+	fmt.Println("Saved token to config")
 
 	return nil
 }
diff --git a/cli/cmd/root.go b/cli/cmd/root.go
index 98b8c81..13d2477 100644
--- a/cli/cmd/root.go
+++ b/cli/cmd/root.go
@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 	"net/http"
 	"os"
-	"path/filepath"
 	"time"
 
 	"github.com/alecthomas/kong"
@@ -35,15 +34,6 @@ type CLI struct {
 	// Config ConfigCmd `cmd:"" help: "Display Cluster Configuration"`
 }
 
-func defaultConfigPath() string {
-	dir, err := os.UserConfigDir()
-	if err != nil {
-		home, _ := os.UserHomeDir()
-		return filepath.Join(home, ".config", "mist", "config.json")
-	}
-	return filepath.Join(dir, "mist", "config.json")
-}
-
 func loadConfig(path string) (*Config, error) {
 	b, err := os.ReadFile(path)
 	if err != nil {
diff --git a/cli/cmd/testutil.go b/cli/cmd/testutil.go
index 2b0cb51..8838f12 100644
--- a/cli/cmd/testutil.go
+++ b/cli/cmd/testutil.go
@@ -7,6 +7,7 @@ import (
 	"fmt"
 	"io"
 	"os"
+	"path/filepath"
 	// "strings"
 )
 
@@ -21,7 +22,6 @@ func MockInput(input string, f func()) {
 	os.Stdin = old
 }
 
-
 func CaptureOutput(f func()) string {
 	old := os.Stdout
 	r, w, _ := os.Pipe()
@@ -59,5 +59,14 @@ func findJobByID(jobs []Job, id string) (Job, error) {
 	return Job{}, fmt.Errorf("job with ID %s not found", id)
 }
 
+func defaultConfigPath() string {
+	dir, err := os.UserConfigDir()
+	if err != nil {
+		home, _ := os.UserHomeDir()
+		return filepath.Join(home, ".config", "mist", "config.json")
+	}
+	return filepath.Join(dir, "mist", "config.json")
+}
+
 // Creating a helper function for capturing
 // Stdout outputs

From 48771a06e9917473def625febc87295cc2ed6f7c Mon Sep 17 00:00:00 2001
From: Oliver Kwun-Morfitt <oliverkwunmorfitt@gmail.com>
Date: Sun, 16 Nov 2025 15:41:42 -0500
Subject: [PATCH 4/6] updaded to get long lived token

---
 cli/cmd/auth_login.go | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/cli/cmd/auth_login.go b/cli/cmd/auth_login.go
index ee44bb5..a3eeeab 100644
--- a/cli/cmd/auth_login.go
+++ b/cli/cmd/auth_login.go
@@ -52,6 +52,12 @@ func saveTokenToConfig(ctx *AppContext, token string) error {
 	return nil
 }
 
+func getLongLivedToken(shortLivedToken string) (string, error) {
+	// Placeholder for actual implementation to exchange short-lived token for long-lived token
+	// In a real scenario, this would involve making an HTTP request to the auth server
+	return shortLivedToken + "_long_lived", nil
+}
+
 func (l *LoginCmd) Run(ctx *AppContext) error {
 	// mist auth login
 	if ctx.Config != nil && ctx.Config.AccessToken != "" {
@@ -69,9 +75,16 @@ func (l *LoginCmd) Run(ctx *AppContext) error {
 	token, _ := reader.ReadString('\n')
 	token = strings.TrimSpace(strings.ToLower(token))
 
+	token, err = getLongLivedToken(token)
+	if err != nil {
+		fmt.Println("Error obtaining long-lived token:", err)
+		return err
+	}
+
 	err = saveTokenToConfig(ctx, token)
 	if err != nil {
-		fmt.Println("Error during authentication:", err)
+		fmt.Println("Error during token saving")
+		return err
 	}
 
 	fmt.Println("Saved token to config")

From 5a52be7818c9d45dfc88567dd6e8da7b52a032b2 Mon Sep 17 00:00:00 2001
From: Oliver Kwun-Morfitt <oliverkwunmorfitt@gmail.com>
Date: Sun, 16 Nov 2025 15:50:19 -0500
Subject: [PATCH 5/6] added confirmation to log in command and url prints to
 console

---
 cli/cmd/auth_login.go | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/cli/cmd/auth_login.go b/cli/cmd/auth_login.go
index a3eeeab..0446ad7 100644
--- a/cli/cmd/auth_login.go
+++ b/cli/cmd/auth_login.go
@@ -61,9 +61,22 @@ func getLongLivedToken(shortLivedToken string) (string, error) {
 func (l *LoginCmd) Run(ctx *AppContext) error {
 	// mist auth login
 	if ctx.Config != nil && ctx.Config.AccessToken != "" {
+
+		// Already logged in, ask if they want to re-login
 		fmt.Println("Already logged in with token:", ctx.Config.AccessToken)
+		fmt.Print("Re-enter token? (y/N): ")
+		reader := bufio.NewReader(os.Stdin)
+		answer, _ := reader.ReadString('\n')
+		answer = strings.TrimSpace(strings.ToLower(answer))
+		if answer != "y" && answer != "yes" {
+			fmt.Println("Aborting login.")
+			return nil
+		}
 	}
+
 	fmt.Println("Opening browser for authentication...")
+	fmt.Printf("If your browser didn't open, click here: \033]8;;%s\033\\%s\033]8;;\033\\\n", authUrl, authUrl)
+
 	err := openUrl()
 	if err != nil {
 		fmt.Println("Error opening browser:", err)

From 591f5aad5de22af5c057b5dbb426aac60c01c4cb Mon Sep 17 00:00:00 2001
From: Oliver Kwun-Morfitt <oliverkwunmorfitt@gmail.com>
Date: Tue, 18 Nov 2025 11:32:12 -0500
Subject: [PATCH 6/6] cleaned up and added a few more edge checks

---
 cli/cmd/auth_login.go | 11 +++++++----
 cli/cmd/root.go       |  4 +++-
 2 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/cli/cmd/auth_login.go b/cli/cmd/auth_login.go
index 0446ad7..9209865 100644
--- a/cli/cmd/auth_login.go
+++ b/cli/cmd/auth_login.go
@@ -38,10 +38,13 @@ func saveTokenToConfig(ctx *AppContext, token string) error {
 	if err := os.MkdirAll(filepath.Dir(configPath), 0o755); err != nil {
 		return fmt.Errorf("failed to create config directory: %w", err)
 	}
-	cfg := &Config{
-		AccessToken: token,
+
+	if ctx.Config == nil {
+		ctx.Config = &Config{}
 	}
-	data, err := json.MarshalIndent(cfg, "", "  ")
+	ctx.Config.AccessToken = token
+
+	data, err := json.MarshalIndent(ctx.Config, "", "  ")
 	if err != nil {
 		return fmt.Errorf("failed to marshal config: %w", err)
 	}
@@ -86,7 +89,7 @@ func (l *LoginCmd) Run(ctx *AppContext) error {
 
 	reader := bufio.NewReader(os.Stdin)
 	token, _ := reader.ReadString('\n')
-	token = strings.TrimSpace(strings.ToLower(token))
+	token = strings.TrimSpace(token)
 
 	token, err = getLongLivedToken(token)
 	if err != nil {
diff --git a/cli/cmd/root.go b/cli/cmd/root.go
index 13d2477..4221b35 100644
--- a/cli/cmd/root.go
+++ b/cli/cmd/root.go
@@ -66,9 +66,11 @@ func Main() {
 
 	if cfg, err := loadConfig(cli.ConfigPath); err == nil {
 		appCtx.Config = cfg
+	} else if !os.IsNotExist(err) {
+		// config file is present but broken
+		kctx.FatalIfErrorf(err)
 	}
 
 	err := kctx.Run()
 	kctx.FatalIfErrorf(err)
-	// fmt.Println("Command executed successfully")
 }