Skip to content

Conversation

@LFDanLu
Copy link
Member

@LFDanLu LFDanLu commented Dec 5, 2025

See commits

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

🧢 Your Project:

@LFDanLu LFDanLu added the release label Dec 5, 2025
@LFDanLu LFDanLu changed the title fix: (WIP) Release audit fixes fix: Release audit fixes Dec 5, 2025
import {StyleString} from './types';

export {baseColor, color, edgeToText, lightDark, linearGradient, colorMix, size, style} from './spectrum-theme';
export {baseColor, color, lightDark, colorMix, size, style} from './spectrum-theme';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted to keep color public since it helps handle light dark for people, useful for styling arbitrary elements IMO

@LFDanLu LFDanLu marked this pull request as ready for review December 5, 2025 22:56
snowystinger
snowystinger previously approved these changes Dec 5, 2025
reidbarber
reidbarber previously approved these changes Dec 5, 2025
@LFDanLu LFDanLu dismissed stale reviews from reidbarber and snowystinger via 1468d05 December 5, 2025 23:49
@rspbot
Copy link

rspbot commented Dec 6, 2025

@rspbot
Copy link

rspbot commented Dec 6, 2025

## API Changes

@react-spectrum/s2

/@react-spectrum/s2:AccordionItemState

+AccordionItemState {
+  collapse: () => void
+  expand: () => void
+  isExpanded: boolean
+  setExpanded: (boolean) => void
+  toggle: () => void
+}

/@react-spectrum/s2:AccordionItemRenderProps

+AccordionItemRenderProps {
+  isDisabled: boolean
+  isExpanded: boolean
+  isFocusVisibleWithin: boolean
+  state: AccordionItemState
+}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants