From feb8bdeabaa935cbb7881e2065e9c96ea26d0af2 Mon Sep 17 00:00:00 2001 From: "HTMLGuy, LLC" Date: Tue, 30 Jan 2024 16:21:53 -0500 Subject: [PATCH 1/4] Fix for undefined var response If you see this line: https://github.com/akamai/cli-netstorage/blob/master/src/netstorage_auth.js#L68 There is an instance where only an error is returned to the callback. The logic I've modified originally didn't handle this scenario. --- src/netstorage.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/netstorage.js b/src/netstorage.js index 9f149de..653eb5b 100644 --- a/src/netstorage.js +++ b/src/netstorage.js @@ -543,7 +543,9 @@ class NetStorage { return new Promise ((resolve, reject) => { this._nsClient.auth(request) this._nsClient.send((data, response) => { - if (response.statusCode != 200) { + if (!response){ + reject("Unable to complete action. " + data); + }else if(response.statusCode != 200) { reject("Unable to complete action. Status code " + response.statusCode) } else { resolve(response) From aa421df58f4698482d2ad32b045db8fdd10bced4 Mon Sep 17 00:00:00 2001 From: HTMLGuy Date: Wed, 31 Jan 2024 10:08:19 -0500 Subject: [PATCH 2/4] Update netstorage.js --- src/netstorage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/netstorage.js b/src/netstorage.js index 653eb5b..f7c759e 100644 --- a/src/netstorage.js +++ b/src/netstorage.js @@ -545,7 +545,7 @@ class NetStorage { this._nsClient.send((data, response) => { if (!response){ reject("Unable to complete action. " + data); - }else if(response.statusCode != 200) { + } else if(response.statusCode != 200) { reject("Unable to complete action. Status code " + response.statusCode) } else { resolve(response) From d5e941348f402dd51c310c7434b2c113b51101f9 Mon Sep 17 00:00:00 2001 From: HTMLGuy Date: Wed, 31 Jan 2024 10:08:48 -0500 Subject: [PATCH 3/4] Update netstorage.js --- src/netstorage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/netstorage.js b/src/netstorage.js index f7c759e..5a6bae5 100644 --- a/src/netstorage.js +++ b/src/netstorage.js @@ -543,7 +543,7 @@ class NetStorage { return new Promise ((resolve, reject) => { this._nsClient.auth(request) this._nsClient.send((data, response) => { - if (!response){ + if (!response) { reject("Unable to complete action. " + data); } else if(response.statusCode != 200) { reject("Unable to complete action. Status code " + response.statusCode) From ebd56aa72af4e76b50df8aa2c1c965d0b95e606e Mon Sep 17 00:00:00 2001 From: HTMLGuy Date: Wed, 31 Jan 2024 10:09:07 -0500 Subject: [PATCH 4/4] Update netstorage.js --- src/netstorage.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/netstorage.js b/src/netstorage.js index 5a6bae5..024fdc7 100644 --- a/src/netstorage.js +++ b/src/netstorage.js @@ -545,7 +545,7 @@ class NetStorage { this._nsClient.send((data, response) => { if (!response) { reject("Unable to complete action. " + data); - } else if(response.statusCode != 200) { + } else if (response.statusCode != 200) { reject("Unable to complete action. Status code " + response.statusCode) } else { resolve(response)