Skip to content

Conversation

@NixFrog
Copy link

@NixFrog NixFrog commented Dec 4, 2025

🧭 What and Why

Update the documentation schema to note that virtual replicas now support optional filters.

🎟 JIRA Ticket: SRCH-8369

Changes included:

  • Update the SearchParams docmentation

🧪 Test

N/A - no functional changes

@NixFrog NixFrog requested a review from jojva December 4, 2025 14:50
@NixFrog NixFrog added documentation Improvements or additions to documentation do not merge the pull request is not yet ready labels Dec 4, 2025
@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 4, 2025

✔️ Code generated!

Name Link
🪓 Triggered by d3cc80aa384d21432f7a9043108c98ac6a910c20
🍃 Generated commit 3f55dc16edcc600496498038dc2b73d9a9c7c927
🌲 Generated branch generated/blm/SRCH-8369/optional-filters-in-vrs
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
go 2635
javascript 2403
php 1902
csharp 1476
python 1390
java 1186
ruby 890
swift 636
scala 23

@NixFrog
Copy link
Author

NixFrog commented Dec 4, 2025

Marked as do not merge while we deploy the feature

@NixFrog NixFrog marked this pull request as ready for review December 8, 2025 13:52
@NixFrog NixFrog requested a review from a team as a code owner December 8, 2025 13:52
- Optional filters don't work on virtual replicas.
- Optional filters are applied _after_ sort-by attributes.
- On virtual replicas, optional filters are applied _after_ the replica's [relevant sort](https://www.algolia.com/doc/guides/managing-results/refine-results/sorting/in-depth/relevant-sort).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would put this line anywhere but here. Lines 413 and 415 describe how optional filters apply in a primary index/standard replica, so it's a bit weird to put the virtual replica behavior in-between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge the pull request is not yet ready documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants