Support C-n and C-p for moving up and down the list (emacs-style)

[fullofcaffeine]

Hi alk,

I'm wondering how hard would it be to add support for those two keybindings. I'm willing to create PR, but some guidance would be cool. I'm so used to using it in MacVim's command-t to move up and down the list, that I really miss them when using gpicker.

Cheers,

Marcelo.

[alk]

It's likely possible, but I'm not sure how.

Default logic disables focus-ability of treeview but delegates all key presses from entry to it. See key_events_delegator in main.c (and how it's wired in setup_signals). So Ctrl-P and Ctrl-N are sent to treeview.

The problem is how tree view handles them. It actually doesn't move selected row. I.e. see screenshot of what happens on my box if I disable focus logic and try Ctrl-P on tree view: http://i.imgur.com/C7VKXSa.png

There might be some way to manually sync 'soft' selection to actually selected row. I have to admit that I've forgot much of Gtk and I'm not even sure how those two 'selections' are named and if the former is even exposed.

Below is the patch that allows you to play with focusable treeview:

diff --git a/main.c b/main.c
index 4bd6e26..e3c0511 100644
--- a/main.c
+++ b/main.c
@@ -467,11 +467,11 @@ gboolean key_events_delegator(GtkWidget *w, GdkEventKey *e, gpointer dummy)
                                                          &sel_start, &sel_end);
        old_cursor_pos = gtk_editable_get_position(GTK_EDITABLE(name_entry));

-       g_object_set(G_OBJECT(tree_view), "can-focus", TRUE, NULL);
+       /* g_object_set(G_OBJECT(tree_view), "can-focus", TRUE, NULL); */
        gtk_widget_grab_focus(GTK_WIDGET(tree_view));
        rv = gtk_widget_event(GTK_WIDGET(tree_view), (GdkEvent *)e);
        gtk_widget_grab_focus(GTK_WIDGET(name_entry));
-       g_object_set(G_OBJECT(tree_view), "can-focus", FALSE, NULL);
+       /* g_object_set(G_OBJECT(tree_view), "can-focus", FALSE, NULL); */

        gtk_editable_set_position(GTK_EDITABLE(name_entry), old_cursor_pos);
        if (had_selection)
@@ -491,7 +491,7 @@ void setup_signals(void)
        g_signal_connect(tree_view, "row-activated", G_CALLBACK(choice_made), 0);
        g_signal_connect(name_entry, "changed", G_CALLBACK(on_entry_changed), 0);

-       g_object_set(G_OBJECT(tree_view), "can-focus", FALSE, NULL);
+       /* g_object_set(G_OBJECT(tree_view), "can-focus", FALSE, NULL); */
        g_signal_connect_after(name_entry, "key-press-event", G_CALLBACK(key_events_delegator), 0);
        g_signal_connect_after(name_entry, "key-release-event", G_CALLBACK(key_events_delegator), 0);
 }

[alk]

One possible (but not very clean way) to deal with that is to "manually" handle Ctrl-P and Ctrl-N and either convert them to / or to move selected row. But I'd prefer a more generic solution (i.e. because gtk actually allows you to change Ctrl-P and Ctrl-N bindings to different keys).

[alk]

I've merged a fix. Consider testing please.

[fullofcaffeine]

Freaking awesome, @alk. Fast turnaround! I'll test it right away.

[fullofcaffeine]

@alk It does work for C-n, but C-p doesn't seem to be working. Check the following screenshot:

https://www.dropbox.com/s/1n0on565pn3cn5k/gpicker.jpg

When I move the cursor down with C-p, it doesn't unselect the previous items (not sure if this is only a rendering problem). The behavior now is that it just select the last item on focus, but if I try to navigate back with C-p, it doesn't go navigate back.

In the screenshot example, when I press , it will always select the last selected item I navigated to with C-n, which is the gtd.org.backup, in this case.

[alk]

Interesting. What is your gtk version? It works on my boxes.
On Jan 19, 2014 1:17 PM, "Marcelo de Moraes Serpa" notifications@github.com
wrote:

@alk https://github.com/alk It does work for C-n, but C-p doesn't seem
to be working. Check the following screenshot:

https://www.dropbox.com/s/1n0on565pn3cn5k/gpicker.jpg

When I move the cursor down with C-p, it doesn't unselect the previous
items (not sure if this is only a rendering problem). The behavior now is
that it just select the last item on focus, but if I try to navigate back
with C-p, it doesn't go navigate back.

In the screenshot example, when I press , it will always select the last
selected item I navigated to with C-n.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-32720167
.

[alk]

Also please ensure that you run latest version. I've recently fixed similar
problem but with arrow keys
On Jan 19, 2014 1:17 PM, "Marcelo de Moraes Serpa" notifications@github.com
wrote:

@alk https://github.com/alk It does work for C-n, but C-p doesn't seem
to be working. Check the following screenshot:

https://www.dropbox.com/s/1n0on565pn3cn5k/gpicker.jpg

When I move the cursor down with C-p, it doesn't unselect the previous
items (not sure if this is only a rendering problem). The behavior now is
that it just select the last item on focus, but if I try to navigate back
with C-p, it doesn't go navigate back.

In the screenshot example, when I press , it will always select the last
selected item I navigated to with C-n.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/11#issuecomment-32720167
.

[alk]

Just tried 2.3 package on ubuntu 12.04 and everything works.

It's quite possible that the way I made Ctrl-{N,P} work relies too heavily on some quirks inside certain versions of Gtk.

In order to help you I really need to know which gtk and/or distro you are using.

[fullofcaffeine]

@alk Had a busy week. I currently do not have access to my Linux box, but will try on the weekend and let you know.

Thanks you very much for taking your time to look into it, by the way :)