From 6dfad1598a4a38b2c8d40e89c8a4d9465c27e4fd Mon Sep 17 00:00:00 2001
From: Dmitry Kryukov <dk2k@ya.ru>
Date: Tue, 1 Apr 2025 10:23:23 +0300
Subject: [PATCH] Fixed string comparison in TezSplitGrouper

---
 .../org/apache/tez/mapreduce/grouper/TezSplitGrouper.java   | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/grouper/TezSplitGrouper.java b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/grouper/TezSplitGrouper.java
index 067acca9e6..ac633bc774 100644
--- a/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/grouper/TezSplitGrouper.java
+++ b/tez-mapreduce/src/main/java/org/apache/tez/mapreduce/grouper/TezSplitGrouper.java
@@ -398,7 +398,7 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,
 
         // One split group created
         String[] groupLocation = {location};
-        if (location == emptyLocation) {
+        if (emptyLocation.equals(location)) {
           groupLocation = null;
         } else if (doingRackLocal) {
           for (SplitContainer splitH : group) {
@@ -417,7 +417,7 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,
             new GroupedSplitContainer(group.size(), wrappedInputFormatName,
                 groupLocation,
                 // pass rack local hint directly to AM
-                ((doingRackLocal && location != emptyLocation)?location:null));
+                ((doingRackLocal && !emptyLocation.equals(location))?location:null));
         for (SplitContainer groupedSplitContainer : group) {
           groupedSplit.addSplit(groupedSplitContainer);
           Preconditions.checkState(groupedSplitContainer.isProcessed() == false,
@@ -473,7 +473,7 @@ public List<GroupedSplitContainer> getGroupedSplits(Configuration conf,
         Map<String, LocationHolder> rackLocations = createLocationsMap(conf);
         for (String location : distinctLocations.keySet()) {
           String rack = emptyLocation;
-          if (location != emptyLocation) {
+          if (!emptyLocation.equals(location)) {
             rack = RackResolver.resolve(location).getNetworkLocation();
           }
           locToRackMap.put(location, rack);