chore: convert bdd tests to e2e tests #7539
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smilkuri
force-pushed
the
cucumber-to-vitest
branch
from
79c8ad9 to
e15aef3
Compare
kuhe
reviewed
Dec 3, 2025
| "extract:docs": "api-extractor run --local", | ||
| "generate:client": "node ../../scripts/generate-clients/single-service --solo acm" | ||
| "generate:client": "node ../../scripts/generate-clients/single-service --solo acm", | ||
| "test:e2e": "yarn g:vitest run -c vitest.config.e2e.mts" |
Contributor
There was a problem hiding this comment.
include a test:e2e:watch script counterpart for all test scripts
kuhe
reviewed
Dec 3, 2025
|
|
||
| expect(result).toBeDefined(); | ||
| expect(result.CertificateSummaryList).toBeDefined(); | ||
| expect(Array.isArray(result.CertificateSummaryList)).toBe(true); |
Contributor
There was a problem hiding this comment.
no need for a triple chain of assertions, since the third one covers all 3
kuhe
reviewed
Dec 3, 2025
|
|
||
| expect(result).toBeDefined(); | ||
| expect(result.items).toBeDefined(); | ||
| expect(Array.isArray(result.items)).toBe(true); |
kuhe
reviewed
Dec 3, 2025
| }); | ||
|
|
||
| describe("Describing stacks", () => { | ||
| it("should return stacks list when describing stacks is called", async () => { |
Contributor
There was a problem hiding this comment.
DescribeStacks is the operation name, not describing stacks
kuhe
reviewed
Dec 3, 2025
| for await (const page of paginator) { | ||
| pageCount++; | ||
| lastPage = page; | ||
| if (pageCount >= 3) break; // Get at least three pages |
Contributor
There was a problem hiding this comment.
this test doesn't match the original test
"the last page must not contain a marker" i'm guessing this refers to the pagination token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Issue number, if available, prefixed with "#"
Description
What does this implement/fix? Explain your changes.
Testing
How was this change tested?
Additional context
Add any other context about the PR here.
Checklist
*.integ.spec.ts).@publictag and enable doc generation on the package?By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.