Implement versioned ERC-4337 user op hashing and user-op Kafka queue #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentUserOpsQueue
rayyan224
changed the title
rayyan224
requested review from
chunter-cb,
danyalprout and
wlawt
and removed request for
wlawt
wlawt
reviewed
Dec 8, 2025
Contributor
wlawt
left a comment
wlawt
left a comment
There was a problem hiding this comment.
lgtm on the ingress-rpc side!
i just realized, should we also update the README with the new account-abstraction-core crate too?
| .expect("Producer creation failed"); | ||
|
|
||
| let publisher = KafkaQueuePublisher::new(producer, "tips-ingress-rpc".to_string()); | ||
| let publisher = KafkaMessageQueue::new(producer); |
Contributor
There was a problem hiding this comment.
nit: could we call BundleQueuePublisher here so we can call .publish over .publish_raw?
| } | ||
|
|
||
| pub struct UserOpQueuePublisher<Q: MessageQueue> { | ||
| queue: std::sync::Arc<Q>, |
Contributor
There was a problem hiding this comment.
nit: seems like std::sync::Arc is used frequently, maybe we can import it?
| #[async_trait] | ||
| pub trait QueuePublisher: Send + Sync { | ||
| async fn publish(&self, bundle: &AcceptedBundle, bundle_hash: &B256) -> Result<()>; | ||
| pub trait MessageQueue: Send + Sync { |
Comment on lines
+105
to
+109
| queue_connection.clone(), | ||
| config.user_operation_topic, | ||
| ), | ||
| bundle_queue_publisher: BundleQueuePublisher::new( | ||
| queue_connection.clone(), |
Contributor
There was a problem hiding this comment.
nit: i wonder for styling/clarity, Gemini suggests to use Arc::clone(&queue_connection), WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This MR adds a versioned user operation model with hashing, introduces shared entry point constants, and refactors Kafka usage behind queue interfaces.
Changes