-
Notifications
You must be signed in to change notification settings - Fork 10
feat(): spatial indexing #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d7d9cf7 to
7df5bff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR shows that after #26 it is trivial to use the repo with a spatial index so I am OK with not having it part of the repo as long as we export the essentials.
But if we provide a built in index that would be valuable.
7df5bff to
c3ce263
Compare
c3ce263 to
441467f
Compare
|
There is a problem with types on CI, please check. |
59a777c to
620b301
Compare
620b301 to
46a1f90
Compare
|
@ShaMan123 I turned this into a draft, I believe it is not complete (yet). |
|
What are you missing? An actual impl in tests? |
|
@ShaMan123 I'm not sure what this PR is, is it a work in progress draft? Is it a proposal for a new API? The tests don't run and as a maintainer of this library I wonder if they should. |
|
Please rebase this PR on top of #31 /
They did not make it into |
|
#32 is open to pre-allocate |
Proposed Changes
Closes #26
Rebase onto #27, diff
Introduces a spatial index interface that allows to query curve bbox and boost performance.
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/srtoolCloses {LINK_TO_ISSUE}orRelated to {LINK_TO_ISSUE}