-
Notifications
You must be signed in to change notification settings - Fork 346
Open
Description
Context
Presumably related to => #487 + #474
Hello, firstly thanks for this great tool. 🙇
I have an issue that started to occur when I switched to github-api for commit mode.
This switch is due to:
- Using my own GitHub App(bot) with its own token (instead of default GITHUB_TOKEN, that does not trigger the following workflows sequentially/intentionally)
- Using Signed commits to avoid GitHub Ghost Bot User, also not worrying to setup a git user in workflows as a bot since its just making things worst
- To using GitHub Tags/Releases when publish(instead of PR creation)
And,
The github-api mode closes and reopens the pull-request, rather then updating the current PRs (git-cli)
- By my lookup on this repos' issues/PRs, this is mentioned as an expected scenario for
github-api.
Issue
Scenario 1:
- There was an opened PR, A merged happened to
main, workflows runs(changesets-action), identifies the existing PR correctly, logs as updating that PR, completes the workflow ✅ - The open PR gets a push from bot, then closes the PR ❓ ✅
- And if the merge on
maindoes not contain a new changeset entry, PRs never opens again ❌- did not see opened again
- just rerun changesets-actions workflows again, closed PR opened correctly ✅
Scenario 1-A
- since the PR closed but branch remains in GitHub
- another merged happened to
main, with our without a new changeset entry - workflows runs(changesets-action), reopens that closed PR again ✅
- since
workflow-dispatchmanual run will do the same
- since
Scenario2:
- There was an opened PR, A merged happened to
main, workflows runs(changesets-action), identifies the existing PR correctly, logs as updating that PR, completes the workflow ✅ - The open PR gets a push(latest main) from bot, then closes the PR ✅
- The merge on
mainwas containing a new changeset entry ℹ️ - The bot reopens that PR again, with new changeset entry also considered ✅ ❌
- some workflows opens, some not
- just rerun changesets-actions workflows again, closed PR opened correctly ✅
Additional Info
Presumably does not matter but its Cloud Enterprise with Data Residency => https://github.com/enterprise/data-residency
- Which means, GH API is not
api.github.com, it isapi.XXXXX.ghe.com, in case that info is needed - Version in use =>
changesets/action@v1
Metadata
Metadata
Assignees
Labels
No labels