OpenStack ConfigDrive metadata service cannot set admin user password

[xuehaonan27]

Problem is as the title.
I browsed the source code. It seems that methods can_post_password and is_password_set are not overrided by BaseOpenStackService, nor by BaseConfigDriveService, nor by ConfigDriveService. So they would always return False when set user password plugins trying to modify admin user password, preventing the plugin do further works.

[xuehaonan27]

It seems that if CreateUserPlugin is enabled and run before SetUserPasswordPlugin, then the control flow would eventually result in BaseCreateUserPlugin._get_password returning a random generated password.
If we are using HTTP service, that doesn't matter much. However, when using ConfigDriveService, there's no way getting POSTed new password. Then no one could login to the Windows instance anymore.

[ITJamie]

+1
the code should be adjusted for ConfigDriveService to never run the random generation.
If a cloudinit drive is removed from a configured vm and the vm rebooted, it can end up unsetting the vm password to something random