From f8ddbac93e1491081ade5fd03e4b54fde5e5836b Mon Sep 17 00:00:00 2001
From: "codeflash-ai[bot]"
 <148906541+codeflash-ai[bot]@users.noreply.github.com>
Date: Thu, 13 Nov 2025 03:04:42 +0000
Subject: [PATCH] Optimize _allowed_routes_check
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The optimized code achieves a **324% speedup** through two key optimizations that reduce expensive operations in the hot loop:

**Key Optimizations:**

1. **Cached Enum Members Lookup**: The original code repeatedly accessed `LiteLLMRoutes.__members__` on every iteration (61% of total runtime). The optimized version caches this as a local variable `members = LiteLLMRoutes.__members__` outside the loop, eliminating redundant global attribute lookups.

2. **Reordered Conditional Logic**: The optimized version checks for direct string equality (`allowed_route == user_route`) first, before the more expensive enum membership and value lookup. Since direct matches are faster than enum operations, this puts the cheaper operation first in the conditional chain.

**Why This Matters:**

The function is called from `allowed_routes_check()` in authentication flows where users access proxy routes. Based on the test results, the optimization is particularly effective for:
- **Large allowed_routes lists**: Shows 260-500% speedup when processing hundreds of routes
- **Mixed enum/string scenarios**: 380-470% improvement when combining LiteLLMRoutes enums with direct string matches
- **Authentication hot paths**: Since this validates every route access, even small per-call improvements compound significantly

The line profiler shows the optimization eliminates the expensive `LiteLLMRoutes.__members__` lookup (9.94ms → 0ms in total time) while maintaining identical functionality and return values across all test cases.
---
 litellm/proxy/auth/auth_checks.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/litellm/proxy/auth/auth_checks.py b/litellm/proxy/auth/auth_checks.py
index d95b7bd03d6a..975e76e9dc64 100644
--- a/litellm/proxy/auth/auth_checks.py
+++ b/litellm/proxy/auth/auth_checks.py
@@ -365,13 +365,11 @@ def _allowed_routes_check(user_route: str, allowed_routes: list) -> bool:
     - allowed_routes: List[str|LiteLLMRoutes] - the list of allowed routes for the user.
     """
 
+    members = LiteLLMRoutes.__members__
     for allowed_route in allowed_routes:
-        if (
-            allowed_route in LiteLLMRoutes.__members__
-            and user_route in LiteLLMRoutes[allowed_route].value
-        ):
+        if allowed_route == user_route:
             return True
-        elif allowed_route == user_route:
+        elif allowed_route in members and user_route in members[allowed_route].value:
             return True
     return False