Skip to content

Conversation

@yangdanny97
Copy link

@yangdanny97 yangdanny97 commented Dec 6, 2025

Change try/except import to use sys.version_info check instead, so that type checkers can statically determine the type.

Since podman only supports Python 3.9+, the custom cached_property impl for older versions is no longer necessary.

See facebook/pyrefly#1758 for context

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 6, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yangdanny97
Once this PR has been reviewed and has the lgtm label, please assign luap99 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@inknos inknos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yangdanny97 thanks for the PR. would you mind change the subject line length of the commit to <72 chars so the bot is happy?

also, podman-py supports python > 3.9, so the if line can be removed.

@yangdanny97
Copy link
Author

Oh, we can just delete that file entirely then if Python 3.8 support is dropped

@inknos
Copy link
Contributor

inknos commented Dec 9, 2025

yes, and the references in other files. do you plan to take care of it as part of this PR?

Signed-off-by: yangdanny97 <dzy4@cornell.edu>
@yangdanny97
Copy link
Author

Yep, the updated version of the PR deletes the custom cached_property entirely and updates all the call sites to use functools.cached_property

@yangdanny97 yangdanny97 changed the title Change cached_property to use a sys.version_info check Delete custom cached_property in favor of functools.cached_property Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants