Enable retry for POST requests in streaming error handling #523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add POST method to Faraday retry configuration (not retried by default) - Add tests verifying retry behavior for both Faraday 1.x and 2.x code paths - Add `expected_url_for` helper for URL assertions in error tests - Reduce retry intervals in test configuration for faster test execution
brunoluigi
commented
Dec 3, 2025
| RSpec.describe RubyLLM::Chat do | ||
| include_context 'with configured RubyLLM' | ||
|
|
||
| before do |
Author
There was a problem hiding this comment.
I've done this since those tests running with retry enable were changing the VCR recorded requests and I wasn't sure if it was supposed to happen, need some help here =)
brunoluigi
commented
Dec 3, 2025
| config.retry_interval = 1 | ||
| config.retry_backoff_factor = 3 | ||
| config.retry_interval_randomness = 0.5 | ||
| config.max_retries = 2 |
Author
There was a problem hiding this comment.
Once retry is enabled the tests at spec/ruby_llm/chat_streaming_spec.rb:57 starts to wait between retries and with the current settings it takes a lot of time so I adjusted to something more adequate for test environments.
One question is, should the faraday-retry middleware actually wait in the test environment or it could be set to simply skip the waiting and retry right away?
brunoluigi
commented
Dec 3, 2025
| end.to raise_error(expected_error_for(provider)) | ||
| end | ||
|
|
||
| it 'retries the request' do |
Author
There was a problem hiding this comment.
Inspired by the test that @AlexVPopov suggested in the issue #417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
expected_url_forhelper for URL assertions in error testsType of change
Scope check
Quality check
overcommit --installand all hooks passbundle exec rake vcr:record[provider_name]bundle exec rspecmodels.json,aliases.json)API changes
Related issues
Fixes #417