From b1c58a42fb27d5c6fb821d566a61f05219cfb629 Mon Sep 17 00:00:00 2001 From: Brett Zamir Date: Fri, 15 May 2020 13:46:33 +0800 Subject: [PATCH 1/3] - Update: Change to Rollup 2.0-supporting API `transformBundle` -> `renderChunk`; fixes #8 - npm: Add recommended `package.json` fields (homepage, bugs, contributors) and use URL for repo (IDEs can make auto-clickable) - npm: Update devDeps. to fix vulnerability --- package.json | 9 +++++++-- postprocess.js | 4 ++-- test.js | 2 +- 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/package.json b/package.json index ae6ff1e..5536f58 100644 --- a/package.json +++ b/package.json @@ -27,13 +27,18 @@ "index.js", "dist" ], - "repository": "developit/rollup-plugin-postprocess", + "repository": "https://github.com/developit/rollup-plugin-postprocess", + "homepage": "https://github.com/developit/rollup-plugin-postprocess", + "bugs": "https://github.com/developit/rollup-plugin-postprocess/issues", "author": "Jason Miller (http://jasonformat.com)", + "contributors": [ + "Brett Zamir" + ], "license": "MIT", "devDependencies": { "eslint": "^4.13.1", "eslint-config-developit": "^1.1.1", - "microbundle": "^0.4.1" + "microbundle": "^0.12.0" }, "dependencies": { "magic-string": "^0.22.4" diff --git a/postprocess.js b/postprocess.js index c2b902b..811e25d 100644 --- a/postprocess.js +++ b/postprocess.js @@ -6,7 +6,7 @@ const replacer = (str, index) => currentToken[index]; export default function postprocess(allReplacements) { return { name: 'postprocess', - transformBundle(code, { sourceMap, format }) { + renderChunk(code, { sourceMap, format }) { let str = new MagicString(code); let replacements = typeof allReplacements==='function' ? allReplacements({ code, sourceMap, format }) : allReplacements; @@ -38,4 +38,4 @@ export default function postprocess(allReplacements) { }; } }; -} \ No newline at end of file +} diff --git a/test.js b/test.js index ed481ed..de294fb 100644 --- a/test.js +++ b/test.js @@ -17,7 +17,7 @@ var out = postprocess([ } return str; }] -]).transformBundle(code, { sourceMap: false }); +]).renderChunk(code, { sourceMap: false }); assert.equal(out.code, 'module.exports=function t(t,o,e,i){for(i=0,o=o.split?o.split("."):o;t&&i Date: Fri, 15 May 2020 14:41:32 +0800 Subject: [PATCH 2/3] - Linting: Check whole directory by default, with .eslintignore (allows IDEs to auto-detect files to ignore) - npm: Add separate lint script - npm: Update magic-string and devDeps - Testing: Check string replacement; prefer `const`/`let` - Testing: Add nyc for checking coverage --- .eslintignore | 1 + package.json | 12 +++++++----- test.js | 17 ++++++++++++----- 3 files changed, 20 insertions(+), 10 deletions(-) create mode 100644 .eslintignore diff --git a/.eslintignore b/.eslintignore new file mode 100644 index 0000000..1521c8b --- /dev/null +++ b/.eslintignore @@ -0,0 +1 @@ +dist diff --git a/package.json b/package.json index 5536f58..ed4674d 100644 --- a/package.json +++ b/package.json @@ -6,8 +6,9 @@ "module": "dist/rollup-plugin-postprocess.m.js", "source": "postprocess.js", "scripts": { + "lint": "eslint .", "prepare": "microbundle --external all --target node --format cjs,es --no-compress", - "test": "eslint postprocess.js && npm run -s prepare && node test", + "test": "npm run lint && npm run -s prepare && nyc node test", "release": "npm run -s prepare && npm test && git commit -am $npm_package_version && git tag $npm_package_version && git push && git push --tags && npm publish" }, "eslintConfig": { @@ -36,11 +37,12 @@ ], "license": "MIT", "devDependencies": { - "eslint": "^4.13.1", - "eslint-config-developit": "^1.1.1", - "microbundle": "^0.12.0" + "eslint": "^7.0.0", + "eslint-config-developit": "^1.2.0", + "microbundle": "^0.12.0", + "nyc": "^15.0.1" }, "dependencies": { - "magic-string": "^0.22.4" + "magic-string": "^0.25.7" } } diff --git a/test.js b/test.js index de294fb..cb3a127 100644 --- a/test.js +++ b/test.js @@ -1,12 +1,12 @@ /* eslint-disable */ -var assert = require('assert'); -var postprocess = require('.'); +const assert = require('assert'); +const postprocess = require('.'); -var code = 'function t(t,o,e,i){for(i=0,o=o.split?o.split("."):o;t&&i Date: Sat, 15 Aug 2020 16:19:54 +0800 Subject: [PATCH 3/3] - npm: Bump devDeps. --- package.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/package.json b/package.json index ed4674d..6b92c58 100644 --- a/package.json +++ b/package.json @@ -37,10 +37,10 @@ ], "license": "MIT", "devDependencies": { - "eslint": "^7.0.0", + "eslint": "^7.7.0", "eslint-config-developit": "^1.2.0", - "microbundle": "^0.12.0", - "nyc": "^15.0.1" + "microbundle": "^0.12.3", + "nyc": "^15.1.0" }, "dependencies": { "magic-string": "^0.25.7"