Require files loaded by the PHPDriver to return a Closure
#487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
changed the title
PHPDriver to return a Closure
GromNaN
force-pushed
the
php-config-closure
branch
from
0f70c20 to
4f61a7e
Compare
There was a problem hiding this comment.
Pull request overview
This PR enforces that PHP mapping files loaded by the PHPDriver must return a Closure, removing the deprecated legacy behavior that allowed direct metadata manipulation. This is a breaking change that improves type safety and code consistency.
Key Changes:
- Removed deprecated fallback code that allowed PHP mapping files to execute without returning a Closure
- Updated error handling to throw
MappingExceptionwhen files don't return a Closure - Removed test cases for the deprecated legacy behavior
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Mapping/Driver/PHPDriver.php | Removed deprecated fallback logic and error handling for non-Closure returns |
| src/Mapping/MappingException.php | Added new exception method for invalid PHP mapping files |
| tests/Mapping/PHPDriverTest.php | Updated test to verify exception is thrown for non-Closure files |
| tests/Mapping/_files/Doctrine.Tests.Persistence.Mapping.PHPTestEntity.php | Removed legacy mapping code to support new test expectations |
| tests/Mapping/_files/Doctrine.Tests.Persistence.Mapping.PHPTestEntityAssert.php | Deleted legacy test fixture file |
| UPGRADE.md | Added migration guide with before/after examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
GromNaN
force-pushed
the
php-config-closure
branch
from
4f61a7e to
df9df46
Compare
greg0ire
approved these changes
Dec 7, 2025
GromNaN
force-pushed
the
php-config-closure
branch
from
df9df46 to
21884b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up #450