chore: Enable nullable for job/characteristics relating code #2900
+163
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filzrev
commented
Dec 6, 2025
| false); | ||
|
|
||
| public static Characteristic<T> Create<TOwner, [DynamicallyAccessedMembers(CharacteristicObject.CharacteristicMemberTypes)] T>(string memberName, Func<CharacteristicObject, T, T> resolver, T fallbackValue, bool ignoreOnApply) | ||
| public static Characteristic<T> Create<TOwner, [DynamicallyAccessedMembers(CharacteristicObject.CharacteristicMemberTypes)] T>(string memberName, Func<CharacteristicObject, T?, T> resolver, T fallbackValue, bool ignoreOnApply) |
Contributor
Author
There was a problem hiding this comment.
It need to allow null because some characteristics expected to return null(e.g. RuntimeCharacteristic/EnvironmentVariablesCharacteristic)
filzrev
commented
Dec 6, 2025
|
|
||
| if (result.Length == 0) | ||
| result = IdCharacteristic.FallbackValue; | ||
| result = IdCharacteristic.FallbackValue!; |
Contributor
Author
There was a problem hiding this comment.
IdCharacteristic specify Default as fallback value. so it must not be null.
filzrev
commented
Dec 6, 2025
| public InfrastructureMode Infrastructure => InfrastructureCharacteristic[this]; | ||
| public AccuracyMode Accuracy => AccuracyCharacteristic[this]; | ||
| public MetaMode Meta => MetaCharacteristic[this]; | ||
| public EnvironmentMode Environment => EnvironmentCharacteristic[this]!; |
Contributor
Author
There was a problem hiding this comment.
Following getter field are set by constructor and should not be null.
- Environment
- Run
- Accuracy
- Meta
filzrev
force-pushed
the
chore-enable-nullable-2
branch
from
f21f56d to
d7ebe52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix a part issue of #2815
What's changed in this PR
Add
#nullable enablesetting and fix nullable annotations.And fix nullable errors.
Other changes
Remove
nullableannotation fromCharacteristicObjectconstructor'sidparameter.when
nullor""is passed to CharacteristicObject constructor.It skip setting
IdCharacteristic. andDefaultis used when getting Id as fallback value.