Skip to content

Conversation

@ananthasai-2006
Copy link

Fix #1254: MLFlow runs not properly closed after error

Added try-except block around log_scores() call to ensure MLFlow runs are properly closed with FAILED status when metrics file doesn't exist or other errors occur during score logging. Previously, runs would remain in RUNNING state indefinitely when errors occurred.

Description

Issue Number

Is this PR a draft? Mark it as draft.

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

Fix ecmwf#1254: MLFlow runs not properly closed after error

Added try-except block around log_scores() call to ensure MLFlow runs are properly closed with FAILED status when metrics file doesn't exist or other errors occur during score logging. Previously, runs would remain in RUNNING state indefinitely when errors occurred.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

MLFLow runs are not properly closed after an error

1 participant