Fix exception handling in Wait For Events In Fx Application Thread

Wait For Events In Fx Application Thread passed even if an exception due
to exceeding the timeout was thrown. Exceptions in the anonymous thread
are now handled with an UncaughtExceptionHandler, so the keyword will
fail when the timeout is exceeded.

Author: psaikkonen

src/main/java/javafxlibrary/keywords/AdditionalKeywords/ConvenienceKeywords.java

@@ -1144,8 +1144,9 @@ public static Object getProgressBarValue(Object locator) {
             + "``timeout`` is the maximum time in seconds that the events will be waited for. If the timeout is "
             + "exceeded the keyword will fail. Default timeout is 5 seconds.\n\n")
     @ArgumentNames({ "timeout=" })
-    public static void waitForEventsInFxApplicationThread(int timeout) {
+    public static void waitForEventsInFxApplicationThread(int timeout) throws Throwable {
 
+        final Throwable[] threadException = new JavaFXLibraryNonFatalException[1];
         try {
             Semaphore semaphore = new Semaphore(0);
             Platform.runLater(() -> semaphore.release());
@@ -1165,16 +1166,21 @@ public static void waitForEventsInFxApplicationThread(int timeout) {
                             "Fx Application Thread: " + e.getMessage());
                 }
             });
+            t.setUncaughtExceptionHandler((thread, e) -> threadException[0] = e);
             t.start();
             semaphore.acquire();
+
+            if (threadException[0] != null)
+                throw threadException[0];
+
         } catch (InterruptedException e) {
             throw new JavaFXLibraryNonFatalException("Wait For Events in Fx Application Thread was interrupted: "
                     + e.getMessage());
         }
     }
 
     @RobotKeywordOverload
-    public static void waitForEventsInFxApplicationThread() {
+    public static void waitForEventsInFxApplicationThread() throws Throwable {
         waitForEventsInFxApplicationThread(HelperFunctions.getWaitUntilTimeout());
     }
 }

src/test/robotframework/acceptance/MiscTests.robot

@@ -103,6 +103,7 @@ Set Node Visibility (Call Method With Argument Types That Require Casting)
 Wait For Events In Fx Application Thread
     [Tags]                                          smoke    demo-set
     Set Test Application                            javafxlibrary.testapps.TestBoundsLocation
+    Set Timeout                                     3
     ${node}                                         Find        id=red
     Call Object Method In Fx Application Thread     ${node}     changeFillAfterTwoSeconds
     Wait For Events In Fx Application Thread
@@ -113,6 +114,7 @@ Wait For Events In Fx Application Thread
     Wait For Events In Fx Application Thread
     ${result}                                       Find        id=red
     Should End With                                 ${result}   fill=0xff0000ff]
+    Set Timeout                                     0
 
 Find From Node
     [Tags]                  smoke

src/test/robotframework/acceptance/NodeLookupTest.robot

@@ -43,14 +43,15 @@ Root Node Of XPath Query
     Should Be Equal     ${ROOT_NODE}        ${TARGET}
 
 Root Node Of Node That Does Not Exist
-    [Tags]              smoke
+    [Tags]              smoke    negative
     ${MSG}              Run Keyword And Expect Error    *    Get Root Node Of    id=non-existent-node-id
     Should Contain      ${MSG}    Unable to find any node with query: "id=non-existent-node-id"
 
 *** Keywords ***
 Setup all tests
-    Launch Javafx Application    ${TEST_APPLICATION}
-    Set Screenshot Directory     ${OUTPUT_DIR}${/}report-images
+    Launch Javafx Application       ${TEST_APPLICATION}
+    Set Screenshot Directory        ${OUTPUT_DIR}${/}report-images
+    Set Timeout                     1
 
 Teardown all tests
-    Close Javafx Application
+    Close Javafx Application