Skip to content

Improvements over make_psmap_plots #644

@HealthyPear

Description

@HealthyPear

Feature Request

Is your feature request related to a problem? Please describe.

I think make_psmap_plots is doing too many things and the way it returns does not leave much freedom.

Describe the solution you'd like

The function right now is creating figures, saving them and then closing them returning anything.

If you just return the axis for each plot the user can make of it whatever needed and it will also be possible to show the plot in a jupyter notebook without loading the saved image which is not editable a posteriori

I propose to refactor it in three methods (1 per plot) and make each of them return the axis object
so the user can combine the plots as he/she pleases.
Let all kwargs be injected for whichever plot by setting defaults and let the user override them instead of hardcoding e.g. the colormap or the parameters or the maps or the binning.

gta.psmap with make_plots=True should just call all three with defaults and e.g. savefig=True

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions