sys-kernel/coreos-modules: Enable Netkit flag #3524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timbuchwaldt
force-pushed
the
main
branch
3 times, most recently
from
fc75bc9 to
9c42188
Compare
timbuchwaldt
temporarily deployed
to
development
GitHub Actions
Inactive
tormath1
reviewed
Dec 1, 2025
chewi
requested changes
Dec 1, 2025
sdk_container/src/third_party/coreos-overlay/sys-kernel/coreos-modules/files/commonconfig-6.12
Outdated
Show resolved
Hide resolved
Closes flatcar/Flatcar#1959 Signed-off-by: Tim Buchwaldt <tim.buchwaldt@deepl.com>
timbuchwaldt
temporarily deployed
to
development
GitHub Actions
Inactive
Contributor
|
Images are available here: https://github.com/flatcar/scripts/actions/runs/19855010770?pr=3524 and netkit is enabled: Two tests are failing but it's unrelated (because the PR comes from a fork). @timbuchwaldt any chance to try the provided images? |
Contributor
|
Will this make our Cilium tests more reliable? 🤔 |
Contributor
Not really, it seems it has to be explicitely opt-in. What we can do is to add a variant to our Cilium Kubernetes tests to test netkit, similar to this: https://github.com/flatcar/mantle/blob/c4e298d8328977f03869d2f73ddd4c61cc836a0d/kola/tests/kubeadm/kubeadm.go#L50-L54 |
Author
|
Currently out sick from work, will have a look at testing once back |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable Netkit flag
Enable the netkit config flag, closes flatcar/Flatcar#1959
How to use
Load netkit module, enjoy Cilium performance improvements.
Testing done
[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.